-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(toggle): add helperText and errorText properties #30161
Open
brandyscarney
wants to merge
8
commits into
feature-8.5
Choose a base branch
from
ROU-11552
base: feature-8.5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d1260b2
feat(toggle): add helper and error text properties and design
brandyscarney bc8eb22
test(toggle): add e2e tests for bottom content
brandyscarney 78c7e6c
chore(): add updated snapshots
brandyscarney a1b6e8c
test(toggle): add e2e test and screenshots for end placement
brandyscarney 4242757
style: typo
brandyscarney 5eb665e
docs: helper and error text description
brandyscarney fa65cfb
fix(toggle): reduce padding to match md guidelines
brandyscarney a3a8f2c
Merge branch 'feature-8.5' into ROU-11552
brandyscarney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
132 changes: 132 additions & 0 deletions
132
core/src/components/toggle/test/bottom-content/index.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,132 @@ | ||
<!DOCTYPE html> | ||
<html lang="en" dir="ltr"> | ||
<head> | ||
<meta charset="UTF-8" /> | ||
<title>Toggle - Bottom Content</title> | ||
<meta | ||
name="viewport" | ||
content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no" | ||
/> | ||
<link href="../../../../../css/ionic.bundle.css" rel="stylesheet" /> | ||
<link href="../../../../../scripts/testing/styles.css" rel="stylesheet" /> | ||
<script src="../../../../../scripts/testing/scripts.js"></script> | ||
<script nomodule src="../../../../../dist/ionic/ionic.js"></script> | ||
<script type="module" src="../../../../../dist/ionic/ionic.esm.js"></script> | ||
<style> | ||
.grid { | ||
display: grid; | ||
grid-template-columns: repeat(auto-fit, minmax(200px, 1fr)); | ||
grid-row-gap: 20px; | ||
grid-column-gap: 20px; | ||
} | ||
h2 { | ||
font-size: 12px; | ||
font-weight: normal; | ||
|
||
color: #6f7378; | ||
|
||
margin-top: 10px; | ||
} | ||
ion-toggle { | ||
width: 100%; | ||
} | ||
</style> | ||
</head> | ||
|
||
<body> | ||
<ion-app> | ||
<ion-header> | ||
<ion-toolbar> | ||
<ion-title>Toggle - Bottom Content</ion-title> | ||
</ion-toolbar> | ||
</ion-header> | ||
|
||
<ion-content id="content" class="ion-padding"> | ||
<div class="grid"> | ||
<div class="grid-item"> | ||
<h2>No Hint</h2> | ||
<ion-toggle>Label</ion-toggle> | ||
</div> | ||
|
||
<div class="grid-item"> | ||
<h2>No Hint: Stacked</h2> | ||
<ion-toggle label-placement="stacked">Label</ion-toggle> | ||
</div> | ||
|
||
<div class="grid-item"> | ||
<h2>Helper Text: Label Start</h2> | ||
<ion-toggle helper-text="Helper text" error-text="Error text">Label</ion-toggle> | ||
</div> | ||
|
||
<div class="grid-item"> | ||
<h2>Helper Text: Label End</h2> | ||
<ion-toggle label-placement="end" helper-text="Helper text" error-text="Error text">Label</ion-toggle> | ||
</div> | ||
|
||
<div class="grid-item"> | ||
<h2>Helper Text: Label Stacked</h2> | ||
<ion-toggle label-placement="stacked" helper-text="Helper text" error-text="Error text">Label</ion-toggle> | ||
</div> | ||
|
||
<div class="grid-item"> | ||
<h2>Helper Text: Label Fixed</h2> | ||
<ion-toggle label-placement="fixed" helper-text="Helper text" error-text="Error text">Label</ion-toggle> | ||
</div> | ||
|
||
<div class="grid-item"> | ||
<h2>Error Text: Label Start</h2> | ||
<ion-toggle helper-text="Helper text" error-text="Error text" class="ion-invalid ion-touched" | ||
>Label</ion-toggle | ||
> | ||
</div> | ||
|
||
<div class="grid-item"> | ||
<h2>Error Text: Label End</h2> | ||
<ion-toggle | ||
label-placement="end" | ||
helper-text="Helper text" | ||
error-text="Error text" | ||
class="ion-invalid ion-touched" | ||
>Label</ion-toggle | ||
> | ||
</div> | ||
|
||
<div class="grid-item"> | ||
<h2>Error Text: Label Stacked</h2> | ||
<ion-toggle | ||
label-placement="stacked" | ||
helper-text="Helper text" | ||
error-text="Error text" | ||
class="ion-invalid ion-touched" | ||
>Label</ion-toggle | ||
> | ||
</div> | ||
|
||
<div class="grid-item"> | ||
<h2>Error Text: Label Fixed</h2> | ||
<ion-toggle | ||
label-placement="fixed" | ||
helper-text="Helper text" | ||
error-text="Error text" | ||
class="ion-invalid ion-touched" | ||
>Label</ion-toggle | ||
> | ||
</div> | ||
</div> | ||
|
||
<button onclick="toggleValid()" class="expand">Toggle error</button> | ||
|
||
<script> | ||
const toggles = document.querySelectorAll('ion-toggle[helper-text]'); | ||
|
||
function toggleValid() { | ||
toggles.forEach((toggle) => { | ||
toggle.classList.toggle('ion-invalid'); | ||
toggle.classList.toggle('ion-touched'); | ||
}); | ||
} | ||
</script> | ||
</ion-content> | ||
</ion-app> | ||
</body> | ||
</html> |
196 changes: 196 additions & 0 deletions
196
core/src/components/toggle/test/bottom-content/toggle.e2e.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,196 @@ | ||
import { expect } from '@playwright/test'; | ||
import { configs, test } from '@utils/test/playwright'; | ||
|
||
/** | ||
* Functionality is the same across modes & directions | ||
*/ | ||
configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => { | ||
test.describe(title('toggle: bottom content functionality'), () => { | ||
test('should not render bottom content if no hint is enabled', async ({ page }) => { | ||
await page.setContent(`<ion-toggle>Label</ion-toggle>`, config); | ||
|
||
const bottomEl = page.locator('ion-toggle .toggle-bottom'); | ||
await expect(bottomEl).toHaveCount(0); | ||
}); | ||
test('helper text should be visible initially', async ({ page }) => { | ||
await page.setContent(`<ion-toggle helper-text="Helper text" error-text="Error text">Label</ion-toggle>`, config); | ||
|
||
const helperText = page.locator('ion-toggle .helper-text'); | ||
const errorText = page.locator('ion-toggle .error-text'); | ||
await expect(helperText).toBeVisible(); | ||
await expect(helperText).toHaveText('Helper text'); | ||
await expect(errorText).toBeHidden(); | ||
}); | ||
test('input should have an aria-describedby attribute when helper text is present', async ({ page }) => { | ||
await page.setContent(`<ion-toggle helper-text="Helper text" error-text="Error text">Label</ion-toggle>`, config); | ||
|
||
const input = page.locator('ion-toggle input[type=checkbox]'); | ||
const helperText = page.locator('ion-toggle .helper-text'); | ||
const helperTextId = await helperText.getAttribute('id'); | ||
const ariaDescribedBy = await input.getAttribute('aria-describedby'); | ||
|
||
expect(ariaDescribedBy).toBe(helperTextId); | ||
}); | ||
test('error text should be visible when toggle is invalid', async ({ page }) => { | ||
await page.setContent( | ||
`<ion-toggle class="ion-invalid ion-touched" helper-text="Helper text" error-text="Error text">Label</ion-toggle>`, | ||
config | ||
); | ||
|
||
const helperText = page.locator('ion-toggle .helper-text'); | ||
const errorText = page.locator('ion-toggle .error-text'); | ||
await expect(helperText).toBeHidden(); | ||
await expect(errorText).toBeVisible(); | ||
await expect(errorText).toHaveText('Error text'); | ||
}); | ||
|
||
test('input should have an aria-describedby attribute when error text is present', async ({ page }) => { | ||
await page.setContent( | ||
`<ion-toggle class="ion-invalid ion-touched" helper-text="Helper text" error-text="Error text">Label</ion-toggle>`, | ||
config | ||
); | ||
|
||
const input = page.locator('ion-toggle input[type=checkbox]'); | ||
const errorText = page.locator('ion-toggle .error-text'); | ||
const errorTextId = await errorText.getAttribute('id'); | ||
const ariaDescribedBy = await input.getAttribute('aria-describedby'); | ||
|
||
expect(ariaDescribedBy).toBe(errorTextId); | ||
}); | ||
test('input should have aria-invalid attribute when toggle is invalid', async ({ page }) => { | ||
await page.setContent( | ||
`<ion-toggle class="ion-invalid ion-touched" helper-text="Helper text" error-text="Error text">Label</ion-toggle>`, | ||
config | ||
); | ||
|
||
const input = page.locator('ion-toggle input[type=checkbox]'); | ||
|
||
await expect(input).toHaveAttribute('aria-invalid'); | ||
}); | ||
test('input should not have aria-invalid attribute when toggle is valid', async ({ page }) => { | ||
await page.setContent(`<ion-toggle helper-text="Helper text" error-text="Error text">Label</ion-toggle>`, config); | ||
|
||
const input = page.locator('ion-toggle input[type=checkbox]'); | ||
|
||
await expect(input).not.toHaveAttribute('aria-invalid'); | ||
}); | ||
test('input should not have aria-describedby attribute when no hint or error text is present', async ({ page }) => { | ||
await page.setContent(`<ion-toggle>Label</ion-toggle>`, config); | ||
|
||
const input = page.locator('ion-toggle input[type=checkbox]'); | ||
|
||
await expect(input).not.toHaveAttribute('aria-describedby'); | ||
}); | ||
}); | ||
}); | ||
|
||
/** | ||
* Rendering is different across modes | ||
*/ | ||
configs({ modes: ['ios', 'md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { | ||
test.describe(title('toggle: helper text rendering'), () => { | ||
// Check the default label placement, end, and stacked | ||
[undefined, 'end', 'stacked'].forEach((labelPlacement) => { | ||
test(`${ | ||
labelPlacement ? `${labelPlacement} label - ` : '' | ||
}should not have visual regressions when rendering helper text`, async ({ page }) => { | ||
await page.setContent( | ||
`<ion-toggle ${ | ||
labelPlacement ? `label-placement="${labelPlacement}"` : '' | ||
} helper-text="Helper text">Label</ion-toggle>`, | ||
config | ||
); | ||
|
||
const bottomEl = page.locator('ion-toggle'); | ||
await expect(bottomEl).toHaveScreenshot( | ||
screenshot(`toggle-helper-text${labelPlacement ? `-${labelPlacement}` : ''}`) | ||
); | ||
}); | ||
|
||
test(`${ | ||
labelPlacement ? `${labelPlacement} label - ` : '' | ||
}should not have visual regressions when rendering helper text with wrapping text`, async ({ page }) => { | ||
await page.setContent( | ||
`<ion-toggle ${ | ||
labelPlacement ? `label-placement="${labelPlacement}"` : '' | ||
} helper-text="Helper text helper text helper text helper text helper text helper text helper text helper text helper text">Label</ion-toggle>`, | ||
config | ||
); | ||
|
||
const bottomEl = page.locator('ion-toggle'); | ||
await expect(bottomEl).toHaveScreenshot( | ||
screenshot(`toggle-helper-text${labelPlacement ? `-${labelPlacement}` : ''}-wrapping`) | ||
); | ||
}); | ||
}); | ||
}); | ||
|
||
test.describe(title('toggle: error text rendering'), () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why does error text not get a check for the end or fixed placement? |
||
test('should not have visual regressions when rendering error text', async ({ page }) => { | ||
await page.setContent( | ||
`<ion-toggle class="ion-invalid ion-touched" error-text="Error text">Label</ion-toggle>`, | ||
config | ||
); | ||
|
||
const bottomEl = page.locator('ion-toggle'); | ||
await expect(bottomEl).toHaveScreenshot(screenshot(`toggle-error-text`)); | ||
}); | ||
test('should not have visual regressions when rendering error text with a stacked label', async ({ page }) => { | ||
await page.setContent( | ||
`<ion-toggle class="ion-invalid ion-touched" error-text="Error text" label-placement="stacked">Label</ion-toggle>`, | ||
config | ||
); | ||
|
||
const bottomEl = page.locator('ion-toggle'); | ||
await expect(bottomEl).toHaveScreenshot(screenshot(`toggle-error-text-stacked-label`)); | ||
}); | ||
}); | ||
}); | ||
|
||
/** | ||
* Customizing supporting text is the same across modes and directions | ||
*/ | ||
configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { | ||
test.describe(title('toggle: supporting text customization'), () => { | ||
test('should not have visual regressions when rendering helper text with custom css', async ({ page }) => { | ||
await page.setContent( | ||
` | ||
<style> | ||
ion-toggle::part(supporting-text) { | ||
font-size: 20px; | ||
} | ||
|
||
ion-toggle::part(helper-text) { | ||
color: green; | ||
} | ||
</style> | ||
<ion-toggle helper-text="Helper text">Label</ion-toggle> | ||
`, | ||
config | ||
); | ||
|
||
const helperText = page.locator('ion-toggle'); | ||
await expect(helperText).toHaveScreenshot(screenshot(`toggle-helper-text-custom-css`)); | ||
}); | ||
test('should not have visual regressions when rendering error text with custom css', async ({ page }) => { | ||
await page.setContent( | ||
` | ||
<style> | ||
ion-toggle::part(supporting-text) { | ||
font-size: 20px; | ||
} | ||
|
||
ion-toggle::part(error-text) { | ||
color: purple; | ||
} | ||
</style> | ||
<ion-toggle class="ion-invalid ion-touched" error-text="Error text">Label</ion-toggle> | ||
`, | ||
config | ||
); | ||
|
||
const errorText = page.locator('ion-toggle'); | ||
await expect(errorText).toHaveScreenshot(screenshot(`toggle-error-text-custom-css`)); | ||
}); | ||
}); | ||
}); |
Binary file added
BIN
+2.84 KB
...le.e2e.ts-snapshots/toggle-error-text-custom-css-md-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.23 KB
...e.e2e.ts-snapshots/toggle-error-text-custom-css-md-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.73 KB
...le.e2e.ts-snapshots/toggle-error-text-custom-css-md-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.52 KB
...ntent/toggle.e2e.ts-snapshots/toggle-error-text-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.87 KB
...tent/toggle.e2e.ts-snapshots/toggle-error-text-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.56 KB
...ntent/toggle.e2e.ts-snapshots/toggle-error-text-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.32 KB
...ontent/toggle.e2e.ts-snapshots/toggle-error-text-md-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.48 KB
...ntent/toggle.e2e.ts-snapshots/toggle-error-text-md-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.14 KB
...ontent/toggle.e2e.ts-snapshots/toggle-error-text-md-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.26 KB
...2e.ts-snapshots/toggle-error-text-stacked-label-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.83 KB
...e.ts-snapshots/toggle-error-text-stacked-label-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.25 KB
...2e.ts-snapshots/toggle-error-text-stacked-label-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.85 KB
...e2e.ts-snapshots/toggle-error-text-stacked-label-md-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.12 KB
...2e.ts-snapshots/toggle-error-text-stacked-label-md-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.7 KB
...e2e.ts-snapshots/toggle-error-text-stacked-label-md-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.86 KB
...e.e2e.ts-snapshots/toggle-helper-text-custom-css-md-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.58 KB
....e2e.ts-snapshots/toggle-helper-text-custom-css-md-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.64 KB
...e.e2e.ts-snapshots/toggle-helper-text-custom-css-md-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.52 KB
.../toggle.e2e.ts-snapshots/toggle-helper-text-end-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.69 KB
...toggle.e2e.ts-snapshots/toggle-helper-text-end-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.55 KB
.../toggle.e2e.ts-snapshots/toggle-helper-text-end-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.25 KB
...t/toggle.e2e.ts-snapshots/toggle-helper-text-end-md-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.3 KB
.../toggle.e2e.ts-snapshots/toggle-helper-text-end-md-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.06 KB
...t/toggle.e2e.ts-snapshots/toggle-helper-text-end-md-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.1 KB
...2e.ts-snapshots/toggle-helper-text-end-wrapping-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.1 KB
...e.ts-snapshots/toggle-helper-text-end-wrapping-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+3.26 KB
...2e.ts-snapshots/toggle-helper-text-end-wrapping-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.66 KB
...e2e.ts-snapshots/toggle-helper-text-end-wrapping-md-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+4.54 KB
...2e.ts-snapshots/toggle-helper-text-end-wrapping-md-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.73 KB
...e2e.ts-snapshots/toggle-helper-text-end-wrapping-md-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.51 KB
...tent/toggle.e2e.ts-snapshots/toggle-helper-text-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.69 KB
...ent/toggle.e2e.ts-snapshots/toggle-helper-text-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.54 KB
...tent/toggle.e2e.ts-snapshots/toggle-helper-text-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.31 KB
...ntent/toggle.e2e.ts-snapshots/toggle-helper-text-md-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.33 KB
...tent/toggle.e2e.ts-snapshots/toggle-helper-text-md-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.12 KB
...ntent/toggle.e2e.ts-snapshots/toggle-helper-text-md-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.27 KB
...gle.e2e.ts-snapshots/toggle-helper-text-stacked-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.66 KB
...le.e2e.ts-snapshots/toggle-helper-text-stacked-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.28 KB
...gle.e2e.ts-snapshots/toggle-helper-text-stacked-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+1.85 KB
...ggle.e2e.ts-snapshots/toggle-helper-text-stacked-md-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.04 KB
...gle.e2e.ts-snapshots/toggle-helper-text-stacked-md-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+1.73 KB
...ggle.e2e.ts-snapshots/toggle-helper-text-stacked-md-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+3.46 KB
...s-snapshots/toggle-helper-text-stacked-wrapping-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+5.51 KB
...-snapshots/toggle-helper-text-stacked-wrapping-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+3.52 KB
...s-snapshots/toggle-helper-text-stacked-wrapping-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.81 KB
...ts-snapshots/toggle-helper-text-stacked-wrapping-md-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+5.6 KB
...s-snapshots/toggle-helper-text-stacked-wrapping-md-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.54 KB
...ts-snapshots/toggle-helper-text-stacked-wrapping-md-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+3.07 KB
...le.e2e.ts-snapshots/toggle-helper-text-wrapping-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+5.07 KB
...e.e2e.ts-snapshots/toggle-helper-text-wrapping-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+3.23 KB
...le.e2e.ts-snapshots/toggle-helper-text-wrapping-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.69 KB
...gle.e2e.ts-snapshots/toggle-helper-text-wrapping-md-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+4.58 KB
...le.e2e.ts-snapshots/toggle-helper-text-wrapping-md-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+2.79 KB
...gle.e2e.ts-snapshots/toggle-helper-text-wrapping-md-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reasoning for not checking
fixed
?