-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCSS imports doesn't work for third party library #248
Comments
^ this sort of thing has actually been the biggest reservation I've had with StencilJS (and why the design system I lead up is sticking around with SkateJS... for now). If the "magic" of Stencil was exposed via a default WebPack config which others could extend or configure to their heart's content this sort of problem (or the dozens of others like including a custom Sass function / plugin that lets us output Sass Maps as JSON data or that we use an off the shelf Sass importer for automatically resolving npm namespaces) wouldn't be much of an issue... Absolutely love love love the ideas I'm seeing being put into this. Just wish incorporating all this hard work into an existing Gulp / Webpack / Frontend workflow (vs replacing or side stepping) was more approachable. 😞 |
@sghoweri my experience with SkateJS is quite opposite as when building component library, tooling part could get really complicated and actually could negatively affect development. Therefore I'm happy with StencilJS approach where you can focus on components only as long as they will allow to tweak necessary configs as in this SCSS case. IMHO Webpack is not good fit for library bundling it is possible but feels awkward. |
to allow sass compile fine tunning Closes ionic-team#248
to allow sass compile fine tunning Closes ionic-team#248
For others who can't wait to tweak scss config in stencil here is naive fix elmariofredo@116a965 also for this particular case one can use very unexpected hotfix $ |
to allow sass compile fine tunning Closes #248
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run
npm list @stencil/core
from a terminal/cmd prompt and paste output below):I'm submitting a ... (check one with "x")
[ ] bug report
[x] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
look at example repo here elmariofredo/bulma-elements#1 where I'm trying to stencilize material design button. In example I'm importing scss from material design package which is trying to import another scss file from other md package. This will end up with following error
this issue is well documented under material-components-web project
material-components/material-components-web#351 with resolution to add
node_modules
toincludePaths
in scss compiler settings.Expected behavior:
Can we allow set scss config from stencil config?
Steps to reproduce:
checkout elmariofredo/bulma-elements#1 branch and run
npm install && npm start
Related code:
stencil/src/compiler/transpile/transpile.ts
Lines 254 to 256 in 9f3f347
Other information:
The text was updated successfully, but these errors were encountered: