Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add sassConfig option #255

Merged
merged 1 commit into from
Oct 24, 2017

Conversation

elmariofredo
Copy link
Contributor

to allow sass compile fine tunning

Closes #248

to allow sass compile fine tunning

Closes ionic-team#248
@elmariofredo
Copy link
Contributor Author

I'm not sure what is your approach as you seems to have facade as you are doing with outputStyle here https://github.com/elmariofredo/stencil/blob/master/src/compiler/bundle/component-styles.ts#L175 but I'm not sure if this approach is feasible in long run.

@adamdbradley adamdbradley merged commit d0db160 into ionic-team:master Oct 24, 2017
@adamdbradley
Copy link
Contributor

looks great, thanks!

@adamdbradley
Copy link
Contributor

Regarding the output style, it really doesn't matter because later on in the build we use CleanCSS on the bundled css file it generates. Only reason we put in the compressed option when minifying css is just to help out clean-css with less work from the start, but really probably doesn't matter much.

@elmariofredo
Copy link
Contributor Author

Yeah I meant more what approach should we take regarding stenciljs config API, if it's better to make facade with custom config keys to prevent issues when there will be need to change sass backend or as I have proposed simply use pass thru options.

Anyway glad you like it

Cheers 🍻

@dertuerke
Copy link

How i can use it?

@elmariofredo
Copy link
Contributor Author

@dertuerke you can just add property sassConfig to your stencil.config.js and add whatever options you desire.

@adamdbradley we should properly document this feature, so I have created ionic-team/stencil-site#110 but not sure if that is correct location. Let me know.

@dertuerke
Copy link

dertuerke commented Dec 22, 2017

@elmariofredo i try it but it dosent work

sassConfig: './node_modules/material-design-lite/src/ material-design-lite.scss'

@elmariofredo
Copy link
Contributor Author

@dertuerke it should be

sassConfig: {
  includePaths: ['./node_modules']
}

check https://github.com/sass/node-sass#includepaths for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants