-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Capacitor bindings wallet plugin #2465
Conversation
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
...ckend/bindings/capacitor/android/src/main/java/org/iota/fireflyactorsystem/WalletPlugin.java
Outdated
Show resolved
Hide resolved
…iota/fireflyactorsystem/WalletPlugin.java Co-authored-by: Rajiv Shah <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
yarn lint does not fix any file |
This error is coming from prettier, so |
I've been executed yarn format too but same 🤔 |
Oooh this one is coming up for me on
|
Ah nvm it might be from old dependencies |
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
cloned in a new folder, installed from clean, fixed format and pushed, in my console I get this: fix/capacitor-wallet-plugin $ yarn format-check
yarn run v1.22.17
$ prettier -c "**/*.{ts,js,json,scss,css,svelte}"
Checking formatting...
All matched files use Prettier code style!
✨ Done in 6.47s. but seems here's some I missing 🤔 |
The CI is running on the code after it's merged with |
ahh yes I blame myself 😬, this was from the previous merged PR, thanks! 😊 |
Summary
Android project as incorrect folder names as Java conventions, producing errors at build time.
On Desktop the name of Stronghold directory name is
__storage__
, we currently are usingdatabase
on the plugin code, so will change it.Also added error handling to avoid crashes on Java code and update Capacitor plugin dependencies to latest version.
Changelog
Relevant Issues
Closes #2464
Type of Change
Please select any type below that is applicable to your changes, and delete those that are not.
Testing
Platforms
Please select any platforms where your changes have been tested.
Instructions
Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.
Checklist
Please tick all of the following boxes that are relevant to your changes, and delete those that are not.