Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Capacitor bindings wallet plugin #2465

Merged
merged 18 commits into from
May 17, 2022
Merged

Conversation

amadeu2
Copy link
Contributor

@amadeu2 amadeu2 commented Mar 2, 2022

Summary

Android project as incorrect folder names as Java conventions, producing errors at build time.
On Desktop the name of Stronghold directory name is __storage__, we currently are using database on the plugin code, so will change it.
Also added error handling to avoid crashes on Java code and update Capacitor plugin dependencies to latest version.

Changelog

 change to use storage folder as in desktop
 handle exceptions on android
 fix rename directory to new package name on android
 update capacitor core deps to latest version

Relevant Issues

Closes #2464

Type of Change

Please select any type below that is applicable to your changes, and delete those that are not.

  • Breaking - any change that would cause existing functionality to not work as expected
  • Chore - refactoring, build scripts or anything else that isn't user-facing
  • Docs - changes to the documentation
  • Fix - a change which fixes an issue
  • New - a change which implements a new feature
  • Update - a change which updates existing functionality

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Checklist

Please tick all of the following boxes that are relevant to your changes, and delete those that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@amadeu2 amadeu2 requested a review from cvarley100 as a code owner March 2, 2022 02:39
@amadeu2 amadeu2 self-assigned this Mar 2, 2022
@amadeu2 amadeu2 added this to the Mobile 1.0.0-alpha milestone Mar 2, 2022
@maxwellmattryan maxwellmattryan changed the title Fix: Capacitor Bindings Wallet plugin fix: Capacitor bindings wallet plugin Mar 16, 2022
@amadeu2 amadeu2 requested a review from rajivshah3 May 12, 2022 02:17
@amadeu2
Copy link
Contributor Author

amadeu2 commented May 12, 2022

yarn lint does not fix any file

@rajivshah3
Copy link
Member

yarn lint does not fix any file

This error is coming from prettier, so yarn format should fix it

@amadeu2
Copy link
Contributor Author

amadeu2 commented May 12, 2022

I've been executed yarn format too but same 🤔

@rajivshah3
Copy link
Member

Oooh this one is coming up for me on develop:

[error] packages/shared/components/Text.svelte: Valid <svelte:...> tag names are svelte:head, svelte:options, svelte:window, svelte:body, svelte:self or svelte:component
[error]   4 |
[error]   5 | <span class="text-component">
[error] > 6 |     <svelte:element this={type} class={`${customClassesString} ${classes}`}>
[error]     |     ^
[error]   7 |         <slot />
[error]   8 |     </svelte:element>
[error]   9 | </span> (6:5)
[error] 4: 
[error] 5: <span class="text-component">
[error] 6:     <svelte:element this={type} class={`${customClassesString} ${classes}`}>
[error]         ^
[error] 7:         <slot />
[error] 8:     </svelte:element>

@rajivshah3
Copy link
Member

Ah nvm it might be from old dependencies

amadeu2 added 2 commits May 12, 2022 00:11
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
@amadeu2
Copy link
Contributor Author

amadeu2 commented May 12, 2022

cloned in a new folder, installed from clean, fixed format and pushed, in my console I get this:

 fix/capacitor-wallet-plugin $ yarn format-check
yarn run v1.22.17
$ prettier -c "**/*.{ts,js,json,scss,css,svelte}"
Checking formatting...
All matched files use Prettier code style!
✨  Done in 6.47s.

but seems here's some I missing 🤔

@rajivshah3
Copy link
Member

rajivshah3 commented May 12, 2022

The CI is running on the code after it's merged with develop. It seems like there's issues on develop that aren't from this PR. I can fix them in a separate PR

@amadeu2
Copy link
Contributor Author

amadeu2 commented May 12, 2022

ahh yes I blame myself 😬, this was from the previous merged PR, thanks! 😊

@amadeu2 amadeu2 requested a review from rajivshah3 May 13, 2022 12:34
* develop:
  New Crowdin translations by Github Action (#3220)
  New Crowdin translations by Github Action (#2964)
  feat: mobile rename profile (#2512)
  chore: sync strings from Desktop 1.5.2 to develop (#3184)
  fix: receive qr responsiveness (#3159)

Signed-off-by: Amadeo Marchioni <[email protected]>
@amadeu2 amadeu2 merged commit b66e4cc into develop May 17, 2022
@amadeu2 amadeu2 deleted the fix/capacitor-wallet-plugin branch May 17, 2022 01:34
@rajivshah3 rajivshah3 mentioned this pull request May 17, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix: Capacitor Bindings Wallet plugin
2 participants