Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

chore: refactor common types #3449

Merged
merged 22 commits into from
Dec 18, 2020
Merged

chore: refactor common types #3449

merged 22 commits into from
Dec 18, 2020

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Dec 16, 2020

This pull request targets #3442 and addresses following issue #3442 (comment) by refactoring some of the common types used by root APIs as per #3413

Gozala and others added 17 commits December 11, 2020 11:46
@Gozala
trigger ci
02402c7
@Gozala
chore: change cid dep to use git pull
0da1850
@Gozala
Revert "chore: change cid dep to use git pull"
58134d5 
This reverts commit 0da1850.
@Gozala
fix: regression introduced by new cid & multicodec
01a75cd
@Gozala
Merge remote-tracking branch 'upstream/master' into chore/verify-cid-fix
83dcdac
@Gozala
Revert "chore: fixed cid and multicodec versions (#3445)"
446da30 
This reverts commit eceb0d4.
@Gozala
chore: fix remaning type missmatches
2d3268f
@Gozala
fix: regressions in examples
a51a6e5
@Gozala
chore: revert bundle size
58d5d0c
@achingbrain
chore: fix failing test
f032cbd
@achingbrain
chore: update require
8b185ae
@achingbrain
chore: update deps
f5a37a6
@achingbrain
chore: use daemon class instead of cli which does not have it any more
b568e26
@achingbrain
Merge remote-tracking branch 'origin/master' into chore/verify-cid-fix
acb7378
@achingbrain
chore: align versions and remove ts-ignore
a699b9d
@Gozala
chore: factor out types into ipfs-interface
c2ec920
@Gozala
chore: revert ts-expect-error
7dd1e72
@Gozala Gozala force-pushed the chore/refactor-common-types branch from 0a69b24 to 0cd45dc Compare December 16, 2020 08:47
Base automatically changed from chore/verify-cid-fix to master December 16, 2020 09:29
@achingbrain achingbrain changed the title Chore/refactor common types chore: refactor common types Dec 16, 2020
@achingbrain
Copy link
Member

Please could you rebase on top of master?

@achingbrain
Copy link
Member

Also, if we could not have ipfs-interface and interface-ipfs-core it would help everyone's sanity. The interface term is used in loads of other places so let's call it something different.

How about calling it types-ipfs or ipfs-types?

ipfs-types is taken on npm already, @bluelovers would you consider donating the name so we can have first-class type support with regular releases done in sync with the main implementation etc?

@Gozala Gozala mentioned this pull request Dec 17, 2020
Merged
3 tasks
achingbrain
achingbrain approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achingbrain achingbrain merged commit 34e1492 into master Dec 18, 2020
@achingbrain achingbrain deleted the chore/refactor-common-types branch December 18, 2020 14:09
SgtPooki referenced this pull request in ipfs/js-kubo-rpc-client Aug 18, 2022
@Gozala @achingbrain
chore: refactor common types (#3449)
73d1436 
Addresses ipfs/js-ipfs#3442 (comment) by refactoring some of the common types used by root APIs as per #3413 

Co-authored-by: achingbrain <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achingbrain achingbrain achingbrain approved these changes

@hugomrdias hugomrdias Awaiting requested review from hugomrdias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gozala @achingbrain