Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

More dag.api goodness #783

Merged
merged 9 commits into from
Mar 13, 2017
Merged

More dag.api goodness #783

merged 9 commits into from
Mar 13, 2017

Conversation

daviddias
Copy link
Member

@daviddias daviddias commented Mar 9, 2017 •
edited
Loading

@daviddias daviddias added the status/in-progress In progress label Mar 9, 2017
@daviddias daviddias self-assigned this Mar 9, 2017
dignifiedquire
dignifiedquire reviewed Mar 12, 2017
View reviewed changes
src/core/components/dag.js Outdated
return callback(err)
}
callback(null, results)
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just run pull.collect(callback) instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! (you know when you open a callback for testing? :P)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never :P

@daviddias daviddias merged commit eebd9b5 into master Mar 13, 2017
@daviddias daviddias deleted the feat/more-dag-api branch March 13, 2017 16:03
@daviddias daviddias removed the status/in-progress In progress label Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dignifiedquire dignifiedquire dignifiedquire approved these changes

Assignees

@daviddias daviddias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviddias @dignifiedquire