This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
API update #80
Merged
API update #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dignifiedquire would like your review on this PR, I'm sure your fresh view will bring a clear perspective on how to simplify it. I'll also look into it again tomorrow rested :) |
dignifiedquire
suggested changes
Mar 13, 2017
src/index.js
Outdated
| options = options || {} | ||
|
|
||
| // non recursive | ||
| const p = pullPushable() |
There was a problem hiding this comment.
why do you need to use a push stream? you should be able to return source stream that only walks the next thing if it actually needs to
There was a problem hiding this comment.
wanna exemplify what you mean?
test/ipld-dag-cbor.js
Outdated
| @@ -113,7 +113,7 @@ module.exports = (repo) => { | |||
| }) | |||
| }) | |||
|
|
|||
| describe('public api', () => { | |||
| describe.only('public api', () => { | |||
src/index.js
Outdated
| p.end() | ||
| }) | ||
| }) | ||
| } |
There was a problem hiding this comment.
this could be written as
if (!options.recursive) {
p = pullDefer.source()
waterfall([
(cb) => this.bs.get(cid, cb),
(block, cb) => r.resolver.tree(block, cb)
], (err, paths) => {
if (err) {
return p.abort(err)
}
p.resolve(pull.values(paths))
})
}
src/index.js
Outdated
| } | ||
| }), | ||
| pull.filter((el) => el && el.length > 0), | ||
| pullSort((a, b) => a.localeCompare(b)) |
There was a problem hiding this comment.
pullSort has to buffer everything, you should try and avoid this sorting
There was a problem hiding this comment.
suggestion being: let the user do the sorting themselves? sgtm if that is what you propose
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs: