Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP API - Content-Type returned by get command should be application/x-tar #1824

Open
hjoest opened this issue Oct 10, 2015 · 1 comment
Open

HTTP API - Content-Type returned by get command should be application/x-tar #1824

hjoest opened this issue Oct 10, 2015 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws) status/deferred Conscious decision to pause or backlog topic/commands Topic commands

Comments

@hjoest
Copy link

hjoest commented Oct 10, 2015

The get command, e.g. POST /api/v0/get?arg=QmedYJNEKn656faSHaMv5UFVkgfSzwYf9u4zsYoXqgvnch, always returns a TAR stream. However it doesn't set the Content-Type header accordingly. It should be application/x-tar.
@hjoest hjoest changed the title HTTP API - HTTP API - Content-Type returned by get command should be application/x-tar Oct 10, 2015
@whyrusleeping whyrusleeping added kind/bug A bug in existing code (including security flaws) topic/commands Topic commands labels Oct 11, 2015
@rht rht mentioned this issue Nov 24, 2015
Closed
@jbenet jbenet added the status/in-progress In progress label Nov 24, 2015
@rht rht mentioned this issue Jan 30, 2016
Closed
@RichardLitt
Copy link
Member

Same for tar cat.

@RichardLitt RichardLitt mentioned this issue Mar 1, 2016
Merged
@RichardLitt RichardLitt mentioned this issue May 12, 2016
Closed
RichardLitt added a commit that referenced this issue May 12, 2016
@RichardLitt
Set correct content-type for ipfs get
14bb435 
This is a version of #2004, with CR from @jbenet integrated in, and should close #1824

License: MIT
Signed-off-by: Richard Littauer <[email protected]>
@RichardLitt RichardLitt mentioned this issue May 12, 2016
Closed
Kubuxu pushed a commit that referenced this issue May 31, 2016
@RichardLitt @Kubuxu
Set correct content-type for ipfs get
ddb8585 
This is a version of #2004, with CR from @jbenet integrated in, and should close #1824

License: MIT
Signed-off-by: Richard Littauer <[email protected]>
@Kubuxu Kubuxu added status/deferred Conscious decision to pause or backlog and removed status/in-progress In progress labels Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) status/deferred Conscious decision to pause or backlog topic/commands Topic commands
Projects
None yet
Milestone
No milestone
6 participants
@hjoest @jbenet @rht @RichardLitt @whyrusleeping @Kubuxu