ipfs get: set correct content-type on resp #2004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: rht <[email protected]>
|
mmm... i see you PRing against master... i'll allow this one though. fairly trivial. LGTM |
| @@ -232,7 +234,9 @@ func sendResponse(w http.ResponseWriter, r *http.Request, res cmds.Response, req | |||
| if _, ok := res.Output().(io.Reader); ok { | |||
| // set streams output type to text to avoid issues with browsers rendering | |||
| // html pages on priveleged api ports | |||
| mime = "text/plain" | |||
| if mime != mimeTypes[cmds.Tar] && mime != mimeTypes[cmds.Gzip] { | |||
There was a problem hiding this comment.
maybe can make it something like:
if !xssSafeMimeType(mime) {
mime = mimeTypes[cmds.Text]
}and elsewhere something like:
var xssSafeMimeTypes = []string{
mimeTypes[cmds.Tar],
mimeTypes[cmds.GZip],
mimeTypes[cmds.Text],
mimeTypes[cmds.JSON],
}
func xssSafeMimeType(mime string) {
for _, t := range xssSafeMimeTypes {
if t == mime {
return true
}
}
return false
}to make it clear why this is happening, and easier to broaden the safety boundary, in a single place.
this probably could be a separate package, and may already exist somewhere.
There was a problem hiding this comment.
No such package exists elsewhere yet.
|
one comment above, otherwise LGTM |
ghost
added
|
@rht update here? |
|
@rht doesn't have commit access |
RichardLitt
added a commit
that referenced
this pull request
May 12, 2016
This is a version of #2004, with CR from @jbenet integrated in, and should close #1824 License: MIT Signed-off-by: Richard Littauer <[email protected]>
Kubuxu
pushed a commit
that referenced
this pull request
May 31, 2016
This is a version of #2004, with CR from @jbenet integrated in, and should close #1824 License: MIT Signed-off-by: Richard Littauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1824