-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daemon panic: concurrent write to websocket connection #6197
Comments
Dammit! I thought that was fixed. |
Are you seeing any other stack traces? I'm having trouble reproducing this. I'm pretty sure this isn't a concurrent write/close issue. It looks like a concurrent write issue when negotiating the security transport but I'm not sure how this is possible. |
For what it's worth, we're seeing this. But that's IPFS v0.4.19 and on Android. |
Thanks. Unfortunately, I'm still going to need to do some work to figure out what's actually causing this. |
Nope, that's all I got. It's only ever happened twice, both on the same day. |
@Kycklingar Same with me, no panic now. |
Interesting... I wonder if this can only be triggered by a non-ipfs websocket client (someone may have been scanning). |
@Stebalien seem look like it , but ipfs node should not panic. |
I agree. I'm just trying to reproduce it so I can fix it. |
Make sure to wait until we're done writing before returning. The close should interrupt this process but we should still wait. might be related to ipfs/kubo#6197
may be related to ipfs/kubo#6197 (but I can't find one)
may be related to ipfs/kubo#6197 (but I can't find one)
That makes sure we aren't still writing/reading after we relinquish control. fixes #40 may be related to ipfs/kubo#6197?
I have this crash daily, running with --enable-pubsub-experiment --enable-namesys-pubsub --enable-mplex-experiment
|
I also see this crash just running go-ipfs version: 0.4.22- Running on a Raspberry Pi 3B+ |
@MatthewSteeples could you try running go-ipfs master? We believe this may be fixed. |
This issue is also happening with general usage of libp2p websockets. I'm getting this issue outside of go-ipfs as well. libp2p/go-ws-transport#56 is my bug report on go-ws-transport This is a bug within go-ws-transport and makes websockets completely unusable. I have a custom node that's crashing every 30 minutes due to bug. OP opened report using go-ws-transport v0.0.2 and it's still present in the latest master branch |
Follow up: Edit: https://gist.github.com/djdv/1d6cd8c552d2d2983cfe11f7918058d2 |
I just pushed a |
Also seeing this on my node:
|
Can you try running with the |
Can you post an image on docker hub? If so I would happily test it. Right now I am just using 0.5.0-dev on master.On Nov 19, 2019 12:28 PM, vyzo <[email protected]> wrote:Can you try running with the debug/issue-6197 branch? It should eliminate the panic and also print stack traces to help us debug the issue.
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.
|
@zquestz Here you go: |
@vyzo Here is a stack trace of
|
Same issue here, go-ipfs 0.4.22 , swarm, api and read only gateway open ... |
same here ... |
This should be fixed by #6804. |
fixes #6197 related to libp2p/go-libp2p#732
fixes #6197 related to libp2p/go-libp2p#732
fixes #6197 related to libp2p/go-libp2p#732
fixes #6197 related to libp2p/go-libp2p#732
fixes #6197 related to libp2p/go-libp2p#732
fixes #6197 related to libp2p/go-libp2p#732
fixes #6197 related to libp2p/go-libp2p#732
This was causing a double-write. fixes libp2p/go-libp2p-pnet#31 probably fixes ipfs/kubo#6802 fixes ipfs/kubo#6197
fixes ipfs#6197 related to libp2p/go-libp2p#732
fixes ipfs#6197 related to libp2p/go-libp2p#732
fixes ipfs#6197 related to libp2p/go-libp2p#732
Make sure to wait until we're done writing before returning. The close should interrupt this process but we should still wait. might be related to ipfs/kubo#6197
may be related to ipfs/kubo#6197 (but I can't find one)
fixes ipfs/kubo#6197 related to libp2p/go-libp2p#732
Version information:
go-ipfs version: 0.4.20-rc1-495f12c02
Repo version: 7
System version: amd64/linux
Golang version: go1.12.2
Type:
panic
Description:
The text was updated successfully, but these errors were encountered: