-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't write from the read function #50
Conversation
This was causing a double-write. fixes libp2p/go-libp2p-pnet#31 probably fixes ipfs/kubo#6802 fixes ipfs/kubo#6197
cc @bonedaddy |
After we merge this, we can revert libp2p/go-ws-transport#65. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modulo a question.
err := delimWriteBuffered(rw, []byte("messages over 64k are not allowed")) | ||
if err != nil { | ||
return nil, err | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we reporting this error anywhere now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back to the user. We don't bother sending it to the other side. If someone establishes a connection and sends us garbage, we'll reset the connection and walk away.
Actually fixed in multiformats/go-multistream#50 This reverts commit f6ca84a.
Actually fixed in multiformats/go-multistream#50 This reverts commit 3d337a9.
This was causing a double-write.
fixes libp2p/go-libp2p-pnet#31
probably fixes ipfs/kubo#6802
fixes ipfs/kubo#6197