Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace ioutil with io and os #8903

Closed
wants to merge 1 commit into from
Closed

chore: replace ioutil with io and os #8903

wants to merge 1 commit into from

Conversation

estensen
Copy link
Contributor

ioutil was depcrecated in Go 1.16

@estensen estensen requested a review from lidel as a code owner April 22, 2022 12:33
@welcome

This comment was marked as resolved.

Sign in to view
@BigLep BigLep requested review from guseggert and removed request for lidel April 22, 2022 15:25
@BigLep BigLep added this to the Best Effort Track milestone Apr 22, 2022
@guseggert
Copy link
Contributor

What is your motivation for this?

The io/ioutil package remains and will continue to work as before

@estensen
Copy link
Contributor Author

ioutil will continue to work as before yes, but not improved. If you are walking a directory tree then os.ReadDir is more efficient than ioutil.ReadDir because of less system calls.

You can see the discussion on the proposal here

@Jorropo Jorropo self-requested a review May 2, 2022 13:07
Jorropo
Jorropo reviewed May 2, 2022
View reviewed changes
Copy link
Contributor

@Jorropo Jorropo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, it's mostly good.

I'll do the changes myself and open a new PR (because of circle CI perms issues it isn't running).
(I belive this issue is when you open create a PR from a fork that is an organisation)

coverage/main/main.go Outdated Show resolved Hide resolved
fuse/ipns/ipns_test.go Outdated Show resolved Hide resolved
fuse/node/mount_test.go Outdated Show resolved Hide resolved
@Jorropo Jorropo mentioned this pull request May 12, 2022
Merged
@Jorropo
Copy link
Contributor

Jorropo commented May 12, 2022

replacing this PR with #8969 because this one is buggy (it's a usual bug that happen where CI wont run from certain forks)

@Jorropo Jorropo closed this May 12, 2022
@estensen estensen deleted the ioutil branch May 13, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jorropo Jorropo Jorropo left review comments

@guseggert guseggert Awaiting requested review from guseggert

Assignees
No one assigned
Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
Best Effort Track
Development

Successfully merging this pull request may close these issues.
4 participants
@estensen @guseggert @Jorropo @BigLep