Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace ioutil with io and os #8969

Merged
merged 1 commit into from
Jun 14, 2022
Merged

chore: replace ioutil with io and os #8969

merged 1 commit into from
Jun 14, 2022

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented May 12, 2022

replace #8903 due to the circle CI fork bug.

@Jorropo Jorropo requested a review from lidel as a code owner May 12, 2022 19:23
@Jorropo Jorropo mentioned this pull request May 12, 2022
Closed
@Jorropo Jorropo force-pushed the ioutil branch 2 times, most recently from 814c65a to 4f03208 Compare May 12, 2022 23:33
@Jorropo
Copy link
Contributor Author

Jorropo commented May 16, 2022

I think this PR is cursed, it keep failing no matter what I do. :D

@ajnavarro
Copy link
Member

Context: With Go 1.16, the ioutil package is being deprecated: https://tip.golang.org/doc/go1.16#ioutil

@ajnavarro
Copy link
Member

ajnavarro commented May 25, 2022 •
edited
Loading

@Jorropo you have compilation errors:
cmd/ipfs/runmain_test.go:9:2: imported and not used: "io/ioutil"

Sharness tests should stop if the binary cannot be compiled...

How to reproduce the error:
make -O -j 10 coverage/sharness_tests.coverprofile test/sharness/test-results/sharness.xml TEST_GENERATE_JUNIT=1 CONTINUE_ON_S_FAILURE=1

@Jorropo
Copy link
Contributor Author

Jorropo commented May 25, 2022

@ajnavarro thx

@Jorropo Jorropo added this to the go-ipfs 0.14 milestone May 26, 2022
@BigLep
Copy link
Contributor

BigLep commented Jun 14, 2022 •
edited
Loading

@lidel : do you need to take this review? If not, do you want to request review from someone else instead (e.g., ajnavarro, schomatis)?

@Jorropo
Copy link
Contributor Author

Jorropo commented Jun 14, 2022 •
edited
Loading

@BigLep I don't think we need to, this is a PR from someone else that I had to republish.

In other words, I am the reviewer, I can't merge due that stupid circle CI bug forcing me to repost with my account.

@BigLep BigLep requested review from guseggert and removed request for lidel June 14, 2022 16:35
@guseggert guseggert merged commit a433064 into ipfs:master Jun 14, 2022
@Jorropo
Copy link
Contributor Author

Jorropo commented Jun 14, 2022

@estensen thx for your patch, it got merged finaly 🎉

@Jorropo Jorropo deleted the ioutil branch June 14, 2022 17:05
@Jorropo Jorropo restored the ioutil branch December 12, 2022 22:33
@Jorropo Jorropo deleted the ioutil branch December 12, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guseggert guseggert guseggert approved these changes

Assignees

@Jorropo Jorropo

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
kubo 0.14
Development

Successfully merging this pull request may close these issues.
5 participants
@Jorropo @ajnavarro @BigLep @guseggert @estensen