Generates CMake rules with e2e test artifacts layer #10891
Merged
+1,356
−1,241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzread
changed the title
pzread
changed the title
pzread
added
infrastructure
pzread
requested review from
GMNGeoffrey,
antiagainst and
ScottTodd
as code owners
pzread
force-pushed
the
bench-artifacts-root
branch
from
b0b201f to
b6d2e78
Compare
pzread
changed the title
|
I decided to split the change into two:
|
hcindyl
reviewed
Oct 25, 2022
| @@ -9,8 +9,6 @@ | |||
| ################################################################################ | |||
| iree_package_name(_PACKAGE_NAME) | |||
There was a problem hiding this comment.
We had a discussion before about generating the file during the cmake configuration. It's a little bit tricky but doable.
Right now I think it's still in the tolerated level. But I'll spend some time revisiting the solutions.
There was a problem hiding this comment.
Could we please file an issue so we could look into this flow later?
hcindyl
reviewed
Oct 25, 2022
build_tools/python/e2e_test_artifacts/cmake_generator/iree_generator.py
Outdated
Show resolved
Hide resolved
build_tools/python/e2e_test_artifacts/cmake_generator/common_generators.py
Outdated
Show resolved
Hide resolved
Comment on lines
18
to
22
| @dataclass(frozen=True) | ||
| class IreeModelImportRule(object): | ||
| target_name: str | ||
| output_file_path: str | ||
| cmake_rules: List[str] |
There was a problem hiding this comment.
It looks like a rule that is more suitable for the model_generator module.
There was a problem hiding this comment.
This one is IREE specific rule, so I think it would be better to put it together with other IREE rules. model_generator will be used by other non-IREE benchmarks in the future, so we won't want them to import IREE rules.
pzread
force-pushed
the
bench-artifacts-root
branch
2 times, most recently
from
9971eca to
f796d82
Compare
hcindyl
reviewed
Oct 26, 2022
build_tools/python/e2e_test_artifacts/cmake_generator/rule_generator.py
Outdated
Show resolved
Hide resolved
| @@ -9,8 +9,6 @@ | |||
| ################################################################################ | |||
| iree_package_name(_PACKAGE_NAME) | |||
There was a problem hiding this comment.
Could we please file an issue so we could look into this flow later?
hcindyl
approved these changes
Oct 27, 2022
…erator.py Co-authored-by: CindyLiu <[email protected]>
pzread
force-pushed
the
bench-artifacts-root
branch
from
d46684a to
2223186
Compare
PhaneeshB
pushed a commit
to PhaneeshB/iree
that referenced
this pull request
Oct 31, 2022
Co-authored-by: CindyLiu <[email protected]>
hanhanW
pushed a commit
to hanhanW/iree
that referenced
this pull request
Nov 1, 2022
Co-authored-by: CindyLiu <[email protected]>
This was referenced Dec 9, 2022
This was referenced Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates the cmake rules from e2e test artifacts layer added in #10901
This PR includes the changes in #10901
Note for helping review: Most of the code in
build_tools/python/e2e_test_artifacts/cmake_generator/*.pyare moved frombuild_tools/python/e2e_test_framework/cmake_rule_generator.py