-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPU] Match TileAndFuse Matmul heuristics to VectorDistribute #19666
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nirvedh Meshram <[email protected]>
aabe983
to
b3f2c11
Compare
It appears punet (which I assume has convs and hence the IGEMM path) prefers the old configurations. Going to experiment to see if having different heuristics for those two has better perf on CI tests and update this PR accordingly. |
We could make the seeds a parameter to |
Yeah thats what I was thinking too, there is also the |
compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/ConfigUtils.cpp
Outdated
Show resolved
Hide resolved
dispatch_120 Old(bad) config is
New config is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to block it if improves performance on real-world programs, but I'd really hope we can explain our choice and derive it from the hw constants
Signed-off-by: Nirvedh Meshram <[email protected]>
282e5a7
to
fe2b43e
Compare
That is fair, I was able to derive from the hw constants, just need a larger |
Signed-off-by: Nirvedh Meshram <[email protected]>
Signed-off-by: Nirvedh Meshram <[email protected]>
a246ab1
to
342f49e
Compare
Signed-off-by: Nirvedh Meshram <[email protected]>
342f49e
to
31c26a4
Compare
I believe the regression seen after heuristic change, could be something to do with what we found in #19671. I am going to wait for that to land and then rebase and see how the CI does, |
This provides comparable performance for CI tests.