feat(j-s): Revoke Notifications

[gudjong]

Revoke Notifications

Afturköllun ákæru - Tölvupóstur

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Introduced new methods for handling notifications in various case states, ensuring accurate and timely communication for events like case deletions and indictments.

• Bug Fixes

  • Modified message content for legal notifications to include "talsmann" alongside "verjanda" for improved clarity.
  • Adjusted email notification templates to ensure correct and consistent messaging.

• Refactor

  • Simplified logic in several notification handling methods, enhancing maintainability and reducing complexity.
  • Streamlined test setups by removing redundant initialization and directly populating necessary data.

[kodiakhq]

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (2)

apps/judicial-system/backend/src/app/modules/case/test/caseController/transition.spec.ts (2)

Line range hint 161-166: Duplicate beforeEach setup detected.

The beforeEach hook inside the describe block for case transitions appears to be duplicated. This can lead to confusion and unnecessary repetition in test setup, which might affect test performance and clarity. Consider consolidating or uniquely configuring the necessary setup steps within a single beforeEach to maintain clean and efficient test code.

---

Line range hint 347-352: Duplicate beforeEach setup detected.

Similar to a previous finding, another beforeEach hook is duplicated within a different describe block. This repetition could be streamlined to improve the readability and execution efficiency of your test suite. Ensure that each beforeEach is necessary and distinct to avoid overlapping setups that could introduce side effects or redundant operations.

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a27d5e7 and f6da80e.

Files selected for processing (2)

• apps/judicial-system/backend/src/app/modules/case/case.service.ts (4 hunks)
• apps/judicial-system/backend/src/app/modules/case/test/caseController/transition.spec.ts (1 hunks)

Files not reviewed due to errors (1)

• apps/judicial-system/backend/src/app/modules/case/case.service.ts (no review received)

Additional context used

Path-based instructions (2)

apps/judicial-system/backend/src/app/modules/case/test/caseController/transition.spec.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

apps/judicial-system/backend/src/app/modules/case/case.service.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

Biome

apps/judicial-system/backend/src/app/modules/case/test/caseController/transition.spec.ts

[error] 161-166: Disallow duplicate setup and teardown hooks. (lint/suspicious/noDuplicateTestHooks)

Disallow beforeEach duplicacy inside the describe function.

---

[error] 347-352: Disallow duplicate setup and teardown hooks. (lint/suspicious/noDuplicateTestHooks)

Disallow beforeEach duplicacy inside the describe function.

---

[error] 614-621: Disallow duplicate setup and teardown hooks. (lint/suspicious/noDuplicateTestHooks)

Disallow beforeEach duplicacy inside the describe function.

apps/judicial-system/backend/src/app/modules/case/case.service.ts

[error] 356-356: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.

---

[error] 357-357: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.

---

[error] 358-358: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.

---

[error] 359-359: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.

---

[error] 361-361: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.

---

[error] 372-372: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f6da80e and e88ab2f.

Files selected for processing (1)

• apps/judicial-system/backend/src/app/modules/case/test/caseController/transition.spec.ts (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• apps/judicial-system/backend/src/app/modules/case/test/caseController/transition.spec.ts