feat(web): Add default header for landlaeknir organization #16023
Conversation
mannipje
added
the
deprecated:automerge
WalkthroughThe pull request introduces a new grid style for the "landlaeknir" header in the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1)
334-343: LGTM! Consider making the code more reusable.The change looks good and introduces the flexibility to render different headers based on the
usingDefaultHeaderflag from the organization's namespace.However, consider making the
imageURL andclassNameconfigurable through the organization's namespace as well. This will make the code more reusable across different organizations.
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- apps/web/components/Organization/Wrapper/OrganizationWrapper.css.ts (1 hunks)
- apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1 hunks)
Additional context used
Path-based instructions (2)
apps/web/components/Organization/Wrapper/OrganizationWrapper.css.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (1)
apps/web/components/Organization/Wrapper/OrganizationWrapper.css.ts (1)
37-47: LGTM!The new
landlaeknirHeaderGridContainerstyle declaration follows the established patterns and best practices:
- It adheres to the CSS-in-JS approach using the
@vanilla-extract/csslibrary.- The responsive styles are correctly defined using the
themeUtils.responsiveStyleutility.- The grid template rows and columns are tailored for the "landlaeknir" header layout.
The addition of this style enhances the component's styling capabilities and ensures a structured layout for the "landlaeknir" header on large screens.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16023 +/- ##
==========================================
- Coverage 36.81% 36.81% -0.01%
==========================================
Files 6721 6721
Lines 137872 137871 -1
Branches 39197 39199 +2
==========================================
- Hits 50757 50756 -1
Misses 87115 87115
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 84 Passed, 0 Skipped, 34.54s Total Time |
kodiakhq
bot
deleted the
feature/add-default-header-for-embaetti-landlaeknis
branch
Add default header for landlaeknir organization
What
Make it possible to use default header for Landlæknir organization via config.
Why
A design that was approved by Digital Iceland
Screenshots / Gifs
Before
After
Checklist:
Summary by CodeRabbit
OrganizationHeadercomponent, allowing for dynamic display based on theusingDefaultHeaderflag.These updates improve the overall user experience by providing a more organized layout and flexible header options.