Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Add default header for samgongustofa organization #16060

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

mannipje
Copy link
Member

@mannipje mannipje commented Sep 18, 2024

Add default header for samgongustofa organization

What

Make it possible to use default header for Samgöngustofa organization via config.

Why

A design that was approved by Digital Iceland

Screenshots / Gifs

Before

image

After

image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features
    • Introduced dynamic header rendering in the Organization component, allowing for a customizable header based on specific conditions.
    • Users will see either a DefaultHeader or a TransportAuthorityHeader depending on the organization context.

@mannipje mannipje added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Sep 18, 2024
@mannipje mannipje requested a review from a team as a code owner September 18, 2024 14:25
Copy link
Contributor

coderabbitai bot commented Sep 18, 2024

Walkthrough

The changes introduce conditional rendering logic in the OrganizationHeader component of the OrganizationWrapper.tsx file. Specifically, for the 'samgongustofa' case, the rendering behavior is modified to check the output of the function n('usingDefaultHeader', false). Depending on the result, either a DefaultHeader or a TransportAuthorityHeader is rendered, allowing for dynamic selection between these components based on the evaluation of the n function.

Changes

Files Change Summary
apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx Introduced conditional rendering logic for the 'samgongustofa' case in the OrganizationHeader component, checking n('usingDefaultHeader', false) to determine which header to render.

Possibly related PRs

Suggested reviewers

  • RunarVestmann

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 29890f2 and aa8ebdd.

Files selected for processing (1)
  • apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ab53cdc and 29890f2.

Files selected for processing (1)
  • apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1 hunks)
Additional context used
Path-based instructions (1)
apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (1)
apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1)

472-474: Changes look good and follow existing patterns

The conditional rendering logic introduced for 'samgongustofa' aligns with the existing patterns used for other organizations. This allows for dynamic selection between the DefaultHeader and TransportAuthorityHeader based on the namespace configuration.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.67%. Comparing base (7a3b1e8) to head (aa8ebdd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nents/Organization/Wrapper/OrganizationWrapper.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16060      +/-   ##
==========================================
+ Coverage   36.65%   36.67%   +0.01%     
==========================================
  Files        6749     6737      -12     
  Lines      138746   138453     -293     
  Branches    39410    39377      -33     
==========================================
- Hits        50863    50777      -86     
+ Misses      87883    87676     -207     
Flag Coverage Δ
api 3.39% <ø> (ø)
application-system-api 41.51% <ø> (ø)
application-template-api-modules 23.47% <ø> (ø)
application-ui-shell 21.29% <ø> (ø)
judicial-system-web 28.63% <ø> (ø)
web 1.85% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nents/Organization/Wrapper/OrganizationWrapper.tsx 0.00% <0.00%> (ø)

... and 46 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a3b1e8...aa8ebdd. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Sep 18, 2024

Datadog Report

All test runs 0caf8c2 🔗

6 Total Test Services: 0 Failed, 6 Passed
➡️ Test Sessions change in coverage: 11 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 3.22s 1 no change Link
application-system-api 0 0 0 111 2 3m 33.3s 1 no change Link
application-template-api-modules 0 0 0 109 0 1m 52.06s 1 no change Link
application-ui-shell 0 0 0 74 0 37.64s 1 no change Link
judicial-system-web 0 0 0 338 0 1m 11.7s 1 no change Link
web 0 0 0 84 0 30.62s 1 no change Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants