fix(j-s): E2E Test

[gudjong]

E2E Test

What

Fixes e2e test

Why

• It's broken

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Bug Fixes
  • Updated the text of the document upload button in the indictment case workflow to remove the asterisk indicating a required field, enhancing clarity for users during the upload process.

[coderabbitai]

Walkthrough

The changes in this pull request involve a modification to the text of a button within the indictment case workflow in the judicial system's test suite. Specifically, the button text for uploading a document labeled "Sakavottorð" has been updated by removing an asterisk that indicated it was a required field. This change affects the user interface during the document upload process but does not impact the functionality or logic of the test cases.

Changes

File Path	Change Summary
apps/system-e2e/src/tests/judicial-system/regression/indictment-tests.spec.ts	Modified button text for document upload by removing the asterisk indicating a required field.

Possibly related PRs

• chore(j-s): Display indictment review decision in correct places #15281: Changes to the indictment review decision display, potentially relevant to user interface aspects of the indictment case workflow.
• feat(j-s): Indictment overview for prison users #15357: Introduction of an indictment overview for prison users, relevant to the overall handling of indictment cases.
• feat(j-s): Show courtRecord files in indictments to everyone once uploaded #15817: Enhancements to the visibility of court record files in indictments, related to the document upload process.
• feat(j-s): Disable Next Button While Editing #15861: Functionality to disable the "Next" button while editing, which may connect to user interactions in the indictment case workflow.
• fix(j-s): Remove required criminal record upload in indictments #16563: Removal of the requirement for uploading a criminal record in indictments, directly related to the document upload process.

Suggested reviewers

• unakb

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.80%. Comparing base (514d8ce) to head (e38d047).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16628      +/-   ##
==========================================
+ Coverage   36.74%   36.80%   +0.06%     
==========================================
  Files        6856     6852       -4     
  Lines      142489   142223     -266     
  Branches    40599    40546      -53     
==========================================
- Hits        52354    52348       -6     
+ Misses      90135    89875     -260     

Flag	Coverage Δ
web	1.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 514d8ce...e38d047. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: j-s/fix-e2e-test-required
Commit report: 4b39d33
Test service: web

✅ 0 Failed, 84 Passed, 0 Skipped, 24.26s Total Time
➡️ Test Sessions change in coverage: 1 no change