feat(j-s): Indictment overview for prison users #15357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe updates focus on integrating new functionalities and enhancing existing features across various modules in the judicial system web and backend applications. This includes adding role-based routing, enhancing the Changes
Sequence DiagramssequenceDiagram
participant AuthController
participant User
participant RouteHandler
User->>AuthController: Access App
AuthController->>RouteHandler: Check User Role
RouteHandler->>User: Route Based on Role (i.e., PRISON_CASES_ROUTE)
sequenceDiagram
participant CaseService
participant Database
participant EventLogService
CaseService->>Database: Update Indictment Review Decision
Database->>CaseService: Indictment Review Decision Updated
CaseService->>EventLogService: Create INDICTMENT_REVIEWED Event
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15357 +/- ##
==========================================
+ Coverage 37.01% 37.03% +0.01%
==========================================
Files 6554 6543 -11
Lines 133952 133215 -737
Branches 38339 38211 -128
==========================================
- Hits 49585 49332 -253
+ Misses 84367 83883 -484
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 204 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ❌ 8 Total Test Services: 1 Failed, 7 Passed Test Services
❌ Failed Tests (1)
🔻 Code Coverage Decreases vs Default Branch (1)
|
…d-is/island.is into j-s/prison-indictments
…og' into j-s/prison-indictments-list
…n-indictments # Conflicts: # apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.tsx # # It looks like you may be committing a merge. # If this is not correct, please run # git update-ref -d MERGE_HEAD # and try again. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # On branch j-s/prison-indictments # All conflicts fixed but you are still merging. # # Changes to be committed: # modified: apps/judicial-system/web/src/components/AccordionItems/CaseFilesAccordionItem/CaseFilesAccordionItem.tsx # modified: apps/judicial-system/web/src/components/AccordionItems/CommentsAccordionItem/CommentsAccordionItem.tsx
…nd-is/island.is into j-s/prison-indictments-list
…land.is into j-s/prison-indictments
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
unakb
reviewed
Jul 5, 2024
unakb
reviewed
Jul 5, 2024
unakb
approved these changes
Jul 5, 2024
oddsson
added
the
deprecated:automerge
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- apps/judicial-system/web/pages/fangelsi/krofur.ts (1 hunks)
- apps/judicial-system/web/src/components/InfoCard/InfoCardIndictment.strings.ts (1 hunks)
- apps/judicial-system/web/src/routes/Shared/Cases/AllCases.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- apps/judicial-system/web/src/routes/Shared/Cases/AllCases.tsx
Files skipped from review as they are similar to previous changes (2)
- apps/judicial-system/web/pages/fangelsi/krofur.ts
- apps/judicial-system/web/src/components/InfoCard/InfoCardIndictment.strings.ts
Datadog ReportAll test runs ❌ 8 Total Test Services: 1 Failed, 7 Passed Test Services
❌ Failed Tests (1)
🔻 Code Coverage Decreases vs Default Branch (1)
|
…is into j-s/prison-indictments
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- apps/judicial-system/web/src/components/InfoCard/InfoCardClosedIndictment/InfoCardClosedIndictment.spec.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- apps/judicial-system/web/src/components/InfoCard/InfoCardClosedIndictment/InfoCardClosedIndictment.spec.ts
oskarjs
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Started working on indictment overview for prisons * Add indictment completed event type to event log * feat(j-s): FMST sees relevant indictment cases * Use event logs for completed indictments * Allow verdictDisplayedDate in info card * Add verdictViewDate to ClosedIndictmentInfoCard * Show indictmentReviewedDate on closedIndictmentInfoCard * feat(j-s): Prison cases * fix(j-s): cases filter test * Update indictmentCase.spec.ts * feat(j-s): return indictment completed date * Spesific prison routes * Add indictmentReviewer to limited access case * Add footer * Checkpoint * Change copy * Fix build * Fix tests --------- Co-authored-by: unakb <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
6 tasks
6 tasks
This was referenced Nov 7, 2024
6 tasks
This was referenced Dec 16, 2024
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indictment overview for prison users
Asana
What
This PR implements an indictment overview screen for prison users. It also changes the routing for prison users. Now their pages are prefixed with
/fangelsi/, i.e./fangelsi/krofurand/fangelsi/akaera/yfirlit/[id]Why
When S-cases go live, the prisons need to be able to see the cases.
Screenshots / Gifs
Checklist:
Summary by CodeRabbit
New Features
limitedAccessCaseGraphQL query to capture indictment and event log details.Bug Fixes
InfoCardClosedIndictmentto correctly display indictment review information.Improvements