fix(parental-leave): Change maximumStartDate calculation #16791
Conversation
WalkthroughThe changes in this pull request involve modifying the date calculation logic within the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16791 +/- ##
=======================================
Coverage 36.54% 36.54%
=======================================
Files 6892 6892
Lines 143900 143900
Branches 41016 41015 -1
=======================================
+ Hits 52584 52585 +1
+ Misses 91316 91315 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 18 Total Test Services: 0 Failed, 16 Passed Test ServicesThis report shows up to 10 services
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
libs/application/templates/parental-leave/src/lib/answerValidationSections/utils.ts (1)
145-145: LGTM: Date calculation aligns with requirementsThe new calculation correctly implements the business requirement of allowing applications up to two weeks before the child turns two years old.
Consider extracting the magic number
-15to a named constant likeMAXIMUM_START_DATE_BUFFER_DAYSfor better maintainability and documentation:+const MAXIMUM_START_DATE_BUFFER_DAYS = -15 - const maximumStartDate = addDays(addMonths(dob, usageMaxMonths), -15) + const maximumStartDate = addDays(addMonths(dob, usageMaxMonths), MAXIMUM_START_DATE_BUFFER_DAYS)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
libs/application/templates/parental-leave/src/lib/answerValidationSections/utils.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
libs/application/templates/parental-leave/src/lib/answerValidationSections/utils.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
🔇 Additional comments (1)
libs/application/templates/parental-leave/src/lib/answerValidationSections/utils.ts (1)
4-4: LGTM: Import follows established patterns
The addition of the addDays import maintains the existing pattern of granular imports from date-fns, which is optimal for tree-shaking.
ylfahfa
added
the
deprecated:automerge
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Fix maximumStartDate calculation
What
Fix maximumStartDate calculation to allow applicant to apply for leave the last two weeks before child turns 2.
Why
Specify why you need to achieve this
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit