fix(parental-leave): Correct endDate for month slider #16756
Conversation
When the start day is 17 and end month has 31 days it was giving wrong endDate
WalkthroughThe changes in this pull request focus on the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
helgifr
added
the
deprecated:automerge
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16756 +/- ##
==========================================
- Coverage 36.55% 36.53% -0.02%
==========================================
Files 6892 6893 +1
Lines 143810 143719 -91
Branches 40986 40932 -54
==========================================
- Hits 52564 52509 -55
+ Misses 91246 91210 -36
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 33 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 5 Total Test Services: 0 Failed, 5 Passed Test Services
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
libs/application/templates/parental-leave/src/lib/parentalLeaveUtils.ts (1)
1452-1454: LGTM! The fix correctly handles start dates on both 16th and 17th.The change properly addresses the issue by extending the end date adjustment to include both the 16th and 17th start dates for months with 31 days.
Consider adding test cases to verify the end date calculations for the following scenarios:
- Start date on 17th in a 31-day month
- Start date on 17th in a 30-day month
- Start date on 17th in February (both leap and non-leap years)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
libs/application/templates/parental-leave/src/lib/parentalLeaveUtils.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
libs/application/templates/parental-leave/src/lib/parentalLeaveUtils.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
helgifr
added
deprecated:automerge
When the start day is 17 and end month has 31 days it was giving wrong endDate Co-authored-by: hfhelgason <[email protected]> Co-authored-by: Ylfa <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
When the start day is 17 and end month has 31 days it was giving wrong endDate Co-authored-by: hfhelgason <[email protected]> Co-authored-by: Ylfa <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
When the start day is 17 and end month has 31 days it was giving wrong endDate
...
Attach a link to issue if relevant
What
Specify what you're trying to achieve
Why
Specify why you need to achieve this
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes