-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(native-app): bump app version to 1.4.7 #16807
Conversation
WalkthroughThe changes in this pull request involve updating the version number of an Android and an iOS application. Specifically, the version name in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Datadog ReportAll test runs ✅ 101 Total Test Services: 0 Failed, 98 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (1)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
apps/native/app/ios/IslandApp/Info.plist (1)
Line range hint
94-95
: Security concern: Exposed CodePushDeploymentKeyThe CodePushDeploymentKey is committed directly in the Info.plist file. This key should be managed through environment variables or secure configuration management to prevent potential misuse.
Consider:
- Moving this key to a secure configuration management system
- Using environment variables during build time
- Adding this key to .gitignore and providing a template instead
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
apps/native/app/android/app/build.gradle
(1 hunks)apps/native/app/ios/IslandApp/Info.plist
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
apps/native/app/android/app/build.gradle (1)
Pattern apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/native/app/ios/IslandApp/Info.plist (1)
Pattern apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (1)
apps/native/app/android/app/build.gradle (1)
106-106
: Version name update looks good, but version code needs attention
While the version name update to "1.4.7" is correct, the default version code (143) in getMyVersionCode(143)
appears outdated. This could potentially cause issues with Play Store updates.
Let's verify the version code usage:
Consider updating the fallback version code to match the new version:
- versionCode getMyVersionCode(143)
+ versionCode getMyVersionCode(147)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Bump version to 1.4.7
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation