Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(native-app): bump app version to 1.4.7 #16807

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

thoreyjona
Copy link
Contributor

@thoreyjona thoreyjona commented Nov 12, 2024

Bump version to 1.4.7

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Updated the Android and iOS applications to version 1.4.7, reflecting the latest enhancements and improvements.
  • Bug Fixes

    • No specific bug fixes were noted in this release.
  • Documentation

    • Versioning information has been updated for both Android and iOS platforms.

@thoreyjona thoreyjona requested a review from a team as a code owner November 12, 2024 09:18
Copy link
Contributor

coderabbitai bot commented Nov 12, 2024

Walkthrough

The changes in this pull request involve updating the version number of an Android and an iOS application. Specifically, the version name in the build.gradle file for Android has been changed from "1.4.6" to "1.4.7", and the CFBundleShortVersionString in the Info.plist file for iOS has been updated from "1.4.6" to "1.4.7". These modifications reflect a straightforward increment in the application's versioning scheme.

Changes

File Path Change Summary
apps/native/app/android/app/build.gradle Updated versionName from "1.4.6" to "1.4.7"
apps/native/app/ios/IslandApp/Info.plist Updated CFBundleShortVersionString from "1.4.6" to "1.4.7"

Possibly related PRs

Suggested labels

automerge

Suggested reviewers

  • snaerseljan

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.44%. Comparing base (92d04c8) to head (65fbad5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16807   +/-   ##
=======================================
  Coverage   36.44%   36.44%           
=======================================
  Files        6853     6853           
  Lines      143479   143479           
  Branches    40949    40949           
=======================================
+ Hits        52288    52291    +3     
+ Misses      91191    91188    -3     
Flag Coverage Δ
air-discount-scheme-backend 54.06% <ø> (ø)
air-discount-scheme-web 0.00% <ø> (ø)
api 3.34% <ø> (ø)
api-catalogue-services 77.85% <ø> (ø)
api-domains-air-discount-scheme 37.02% <ø> (ø)
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 48.48% <ø> (ø)
api-domains-communications 39.60% <ø> (ø)
api-domains-criminal-record 47.48% <ø> (ø)
api-domains-driving-license 44.47% <ø> (ø)
api-domains-education 30.55% <ø> (ø)
api-domains-health-insurance 34.33% <ø> (ø)
api-domains-mortgage-certificate 34.68% <ø> (ø)
api-domains-payment-schedule 41.25% <ø> (ø)
application-api-files 62.45% <ø> (ø)
application-core 70.75% <ø> (ø)
application-system-api 40.97% <ø> (ø)
application-template-api-modules 27.63% <ø> (+<0.01%) ⬆️
application-templates-accident-notification 28.98% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 25.87% <ø> (ø)
application-templates-estate 12.15% <ø> (ø)
application-templates-example-payment 24.80% <ø> (ø)
application-templates-financial-aid 15.48% <ø> (ø)
application-templates-general-petition 23.07% <ø> (ø)
application-templates-inheritance-report 6.52% <ø> (ø)
application-templates-marriage-conditions 15.04% <ø> (ø)
application-templates-mortgage-certificate 43.22% <ø> (ø)
application-templates-parental-leave 29.71% <ø> (-0.12%) ⬇️
application-types 6.60% <ø> (ø)
application-ui-components 1.27% <ø> (ø)
application-ui-shell 20.82% <ø> (ø)
auth-admin-web 2.43% <ø> (ø)
auth-nest-tools 30.20% <ø> (ø)
auth-react 21.84% <ø> (ø)
auth-shared 75.00% <ø> (ø)
clients-charge-fjs-v2 24.11% <ø> (ø)
clients-driving-license 40.20% <ø> (ø)
clients-driving-license-book 43.44% <ø> (ø)
clients-financial-statements-inao 48.98% <ø> (ø)
clients-license-client 1.26% <ø> (ø)
clients-middlewares 73.14% <ø> (+0.25%) ⬆️
clients-regulations 42.27% <ø> (ø)
clients-rsk-company-registry 29.76% <ø> (ø)
clients-rsk-personal-tax-return 38.00% <ø> (ø)
clients-smartsolutions 12.77% <ø> (ø)
clients-syslumenn 49.19% <ø> (ø)
clients-zendesk 50.37% <ø> (ø)
cms 0.42% <ø> (ø)
cms-translations 38.89% <ø> (ø)
content-search-index-manager 95.65% <ø> (ø)
content-search-toolkit 8.14% <ø> (ø)
contentful-apps 4.69% <ø> (ø)
dokobit-signing 62.58% <ø> (ø)
download-service 44.24% <ø> (ø)
email-service 60.41% <ø> (ø)
feature-flags 90.47% <ø> (ø)
file-storage 45.86% <ø> (ø)
financial-aid-backend 51.26% <ø> (ø)
financial-aid-shared 17.81% <ø> (ø)
icelandic-names-registry-backend 54.34% <ø> (ø)
infra-nest-server 48.37% <ø> (ø)
infra-tracing 43.24% <ø> (ø)
island-ui-core 28.86% <ø> (ø)
judicial-system-api 19.62% <ø> (ø)
judicial-system-audit-trail 68.70% <ø> (ø)
judicial-system-backend 55.18% <ø> (ø)
judicial-system-formatters 79.13% <ø> (ø)
judicial-system-message 66.86% <ø> (ø)
judicial-system-message-handler 47.81% <ø> (ø)
judicial-system-scheduler 70.47% <ø> (ø)
judicial-system-types 43.99% <ø> (ø)
judicial-system-web 27.51% <ø> (ø)
license-api 42.57% <ø> (-0.06%) ⬇️
localization 10.15% <ø> (ø)
logging 48.43% <ø> (ø)
message-queue 68.58% <ø> (ø)
nest-audit 68.20% <ø> (ø)
nest-aws 54.03% <ø> (ø)
nest-config 77.87% <ø> (ø)
nest-core 43.54% <ø> (ø)
nest-feature-flags 50.96% <ø> (ø)
nest-problem 45.82% <ø> (ø)
nest-sequelize 94.44% <ø> (ø)
nest-swagger 51.71% <ø> (ø)
nova-sms 61.90% <ø> (ø)
portals-admin-regulations-admin 1.85% <ø> (ø)
portals-core 15.89% <ø> (ø)
reference-backend 49.74% <ø> (ø)
regulations 16.78% <ø> (ø)
residence-history 85.00% <ø> (ø)
services-auth-admin-api 52.47% <ø> (ø)
services-auth-delegation-api 58.19% <ø> (ø)
services-auth-ids-api 52.08% <ø> (+<0.01%) ⬆️
services-auth-personal-representative 45.59% <ø> (+0.03%) ⬆️
services-auth-personal-representative-public 41.72% <ø> (ø)
services-auth-public-api 49.56% <ø> (+0.01%) ⬆️
services-documents 60.81% <ø> (ø)
services-endorsements-api 53.34% <ø> (ø)
services-sessions 65.39% <ø> (ø)
services-university-gateway 49.31% <ø> (+0.02%) ⬆️
services-user-notification 46.85% <ø> (ø)
services-user-profile 61.77% <ø> (+0.09%) ⬆️
shared-components 26.88% <ø> (ø)
shared-form-fields 31.24% <ø> (ø)
shared-mocking 60.89% <ø> (ø)
shared-pii 92.85% <ø> (ø)
shared-problem 87.50% <ø> (ø)
shared-utils 27.69% <ø> (ø)
skilavottord-ws 24.14% <ø> (ø)
testing-e2e 66.66% <ø> (ø)
web 1.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d04c8...65fbad5. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Nov 12, 2024

Datadog Report

All test runs 5882e89 🔗

101 Total Test Services: 0 Failed, 98 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.01%), 3 increased, 196 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 82 0 31.25s N/A Link
air-discount-scheme-web 0 0 0 2 0 6.98s N/A Link
api 0 0 0 4 0 2.35s N/A Link
api-catalogue-services 0 0 0 23 0 8.98s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 15.62s N/A Link
api-domains-assets 0 0 0 3 0 9.41s N/A Link
api-domains-auth-admin 0 0 0 18 0 9.95s N/A Link
api-domains-communications 0 0 0 5 0 32.72s N/A Link
api-domains-criminal-record 0 0 0 5 0 9.2s N/A Link
api-domains-driving-license 0 0 0 23 0 26.62s N/A Link

🔻 Code Coverage Decreases vs Default Branch (1)

  • license-api - jest 33.91% (-0.01%) - Details

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
apps/native/app/ios/IslandApp/Info.plist (1)

Line range hint 94-95: Security concern: Exposed CodePushDeploymentKey

The CodePushDeploymentKey is committed directly in the Info.plist file. This key should be managed through environment variables or secure configuration management to prevent potential misuse.

Consider:

  1. Moving this key to a secure configuration management system
  2. Using environment variables during build time
  3. Adding this key to .gitignore and providing a template instead
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3fd0888 and 7b47c1a.

📒 Files selected for processing (2)
  • apps/native/app/android/app/build.gradle (1 hunks)
  • apps/native/app/ios/IslandApp/Info.plist (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
apps/native/app/android/app/build.gradle (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/native/app/ios/IslandApp/Info.plist (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (1)
apps/native/app/android/app/build.gradle (1)

106-106: Version name update looks good, but version code needs attention

While the version name update to "1.4.7" is correct, the default version code (143) in getMyVersionCode(143) appears outdated. This could potentially cause issues with Play Store updates.

Let's verify the version code usage:

Consider updating the fallback version code to match the new version:

-        versionCode getMyVersionCode(143)
+        versionCode getMyVersionCode(147)

apps/native/app/ios/IslandApp/Info.plist Show resolved Hide resolved
@thoreyjona thoreyjona added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Nov 12, 2024
@kodiakhq kodiakhq bot merged commit c4b4548 into main Nov 12, 2024
261 checks passed
@kodiakhq kodiakhq bot deleted the chore/app-bump-version-1.4.7 branch November 12, 2024 17:01
jonnigs pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@coderabbitai coderabbitai bot mentioned this pull request Dec 3, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants