feat(service-portal): new design #5784

disaerna · 2021-11-29T09:44:27Z

New design for service portal 🎉

What

Implementing new design for Service Portal (Mínar síður).
Warning .... this is a HUGE PR

Changes can be seen and tested here: https://service-portalnew-design-demo-beta.dev01.devland.is/minarsidur

Sidebar fixed to left
New design for active items
Collapsable sidebar with icons
Collapsable sidebar has submenu modal on hover
Collapsable sidebar items
New design for UserMenu
Refactor how user sees actors and when viewing as an actor
Add language changer next to userMenu like main web for desktop
Layout changes on sidebar toggle + finance part has larger grid layout
Lock icon appears on locked nav items and returns lock screen instead of disabling sidebar item
Badge appears on "Pósthólf" when user has unread documents
UI core library modified:

Input, Select and Datepicker now has XS option, with label outside the box
ActionCard - Added prop "headingVariant" and 'h3' and 'h4' as available values, defaults to 'h3' and displays as 'h3'
UserAvatar - Added a medium size option and two props, 'color' that has two options, purple or blue and 'isUserMenu' that uses different css if true
ArrowLink - Added width: max-content to the css to prevent breaking in two lines on some screens

Why

New Design !

Screenshots / Gifs

Sidebar:

UserMenu:

Mobile:

Desktop:

Desktop - delegation:

Mobile Menu

Layout:

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

hover/active state for nav items

…-design-demo

…new-design-demo

darrikonn · 2022-01-03T12:14:12Z

apps/service-portal/src/components/Layout/Layout.css.ts

@@ -6,6 +6,9 @@ export const layoutWrapper = style({
  minHeight: `calc(100vh - ${SERVICE_PORTAL_HEADER_HEIGHT_LG}px)`,
 })

+export const layoutGrid = style({
+  transition: 'all 150ms ease-in-out',


Might be better to specify what you're actually transitioning ... and add will-change as well so that the browser can optimize before the element is actually changed.

darrikonn · 2022-01-03T12:17:43Z

apps/service-portal/src/components/Layout/helpers.ts

+      ? 'defaultClosed'
+      : !sidebarCollapsed && hasWideLayout
+      ? 'wide'
+      : 'default'


Nit-picky.. but hard to read ... can be simplified:

const getLayoutType = () => { if (sidebarCollapsed) { return hasWideLayout ? 'wideClosed' : 'defaultClosed' } return hasWideLayout ? 'wide' : 'default' } return gridlayout[getLayoutType()]

thanks! fixed

darrikonn · 2022-01-03T12:31:10Z

apps/service-portal/src/components/Sidebar/Sidebar.css.ts

-      width: 306,
+    md: {
+      paddingLeft: 26,
+      marginLeft: 37,


Why are we not following the spacings from theme for this?

This might look inconsistent.

darrikonn · 2022-01-03T12:33:40Z

libs/island-ui/core/src/lib/Input/Input.mixins.ts

+    padding: 8,
+    ...themeUtils.responsiveStyle({
+      md: {
+        padding: '10px 16px 10px 10px',


Ditto on this ^

Would also like to see it in the Button component.

darrikonn · 2022-01-03T12:35:51Z

libs/island-ui/core/src/lib/Select/Select.css.ts

+  ...themeUtils.responsiveStyle({
+    md: {
+      width: 24,
+      height: 24,


theme spacings?

darrikonn · 2022-01-03T12:36:51Z

libs/island-ui/core/src/lib/Tag/Tag.tsx

@@ -14,6 +14,7 @@ export type TagVariant =
  | 'rose'
  | 'blueberry'
  | 'dark'
+  | 'mint'


This can work if the font color is black and the background is lighter mint ... let's see what the design team thinks of that combination.

darrikonn · 2022-01-03T12:37:54Z

libs/service-portal/core/src/components/EducationCard/EducationCard.tsx

+        {img && (
+          <img
+            src={img}
+            alt={`skrautmynd fyrir ${title}`}


nit-picky ... but translations?

fixed + other files as well

darrikonn · 2022-01-03T12:38:04Z

libs/service-portal/core/src/components/IntroHeader/IntroHeader.tsx

@@ -39,7 +39,7 @@ export const IntroHeader = ({
        >
          <Hidden print={hideImgPrint}>
            <Box textAlign={['center', 'right']} padding={[6, 0]}>
-              <img src={img} alt="" />
+              <img src={img} alt={`skrautmynd fyrir ${title}`} />


darrikonn · 2022-01-03T12:44:28Z

Can you provide updated screenshots?
Have similar comments on the designs, but don't want to re-comment on something that has already been fixed/updated.

Design comment:
IMO this does not look good ... would probably look better with a lighter blue background color, or use the purple one like in the delegation dropdown:

darrikonn

Minor misusage of willChange prop ... otherwise approved.

darrikonn · 2022-01-03T14:50:40Z

apps/service-portal/src/components/Layout/Layout.css.ts

@@ -7,7 +7,8 @@ export const layoutWrapper = style({
 })

 export const layoutGrid = style({
-  transition: 'all 150ms ease-in-out',
+  transition: 'margin 150ms ease-in-out, flexBasis 150ms ease-in-out',
+  willChange: 'transition',


Shouldn't this be margin, flexBasis ... since you're transitioning the margin + flexBasis.

whops - I've never seen this before 😄 fixed

darrikonn · 2022-01-03T15:38:49Z

apps/service-portal/src/components/Layout/Layout.css.ts

@@ -8,7 +8,7 @@ export const layoutWrapper = style({

 export const layoutGrid = style({
  transition: 'margin 150ms ease-in-out, flexBasis 150ms ease-in-out',
-  willChange: 'transition',
+  willChange: 'margin, flexBasis',


This goes for the transitions prop as well ... not sure if I'm correct or not.

But I assume that values should follow CSS naming conventions (kebab) ... so this needs to be flex-basis.
Did the other one work?

lord help me, haha fixed 😅

eirikurn

Nice improvements all around. Submitting a bunch more design comments. But I think all of these are fairly minor. Happy to get this merged to main and fix rest in followup PRs. 🎉

eirikurn · 2022-01-05T14:39:35Z

libs/service-portal/settings/access-control/src/screens/GrantAccess/GrantAccess.tsx

@@ -168,6 +168,7 @@ function GrantAccess() {
                    defaultMessage: 'Aðgangshafi',
                  })}
                  disabled
+                  size="md"


There is some regression in the input style and whitespace on mobile:

eirikurn · 2022-01-05T14:47:52Z

libs/shared/components/src/auth/UserMenu/UserButton.tsx

+          <div className={styles.resetButtonPadding}>
+            {
+              <Inline space={1} alignY="center">
+                {profile.name.split(' ')[0]}


I like this change. However, it doesn't fit in Application System Mobile and barely fits in the Service Portal:

In the SP, it squeezes up to the Beta icon (hope we can get rid of that soon), and the menu button is pushed outside the grid:

In the AS, things drop into a new line in a weird way:

eirikurn · 2022-01-05T14:55:23Z

libs/shared/components/src/auth/UserMenu/UserDelegations.tsx

-          </Text>
-        ) : null}
-      </List>
+      <Box className={styles.userDelegationWrapper}>


I like how the whole modal scrolls on mobile. However, some users will have 10, 20 or 100 delegations (eg accountants). When we did the original design we wanted special UX to handle those edge cases, but there were some complications that made it out of scope.

But we made sure that the user can always easily sign out (pushed the signout button above the delegation list and also made the delegation list scroll instead of the whole modal).

20-100 delegations calls for a fuzzy search 🤔 ... might be worth checking in next projects

eirikurn · 2022-01-05T17:28:28Z

apps/service-portal/src/components/Sidebar/NavItem/NavItem.tsx

+    : collapsed
+    ? 'inactiveCollapsed'
+    : 'inactive'
+  const badgeActive: keyof typeof styles.badge = badge ? 'active' : 'inactive'


The hover/active states are a bit weird and provide strange UX, at least from what I'm used to.

Screen.Recording.2022-01-05.at.15.01.28.mov

Line should not disappear during active + hover (?).

The disclosure icon should not flip when hovering.

I expect to be able to collapse the disclosure by clicking it (and expand it without navigating?).

Spacing for expanded navigation items is a bit inconsistent, like there's more top padding than bottom padding.

The changes of font-weight on hover might also perform UI jumps to the next line if the text is long enough ... didn't test this myself, but is this being handled?

eirikurn · 2022-01-05T17:33:10Z

apps/service-portal/src/components/Sidebar/NavItem/NavItem.tsx

+    hasArray && !alwaysExpanded && !showLock && sidebarState === 'open'
+  const navItemActive: keyof typeof styles.navItemActive = active
+    ? collapsed
+      ? 'activeCollapsed'


I wish we could show a tooltip or something for icons when the menu is collapsed.

This menu is a bit weird IMO without any title:

Also:

The lock icon should not shrink in the submenu.

The submenu could have a dynamic width based on the widest navigation item, instead of flexing down and items falling into multiple lines.

DataDogHQ is a fine reference.

Screen.Recording.2022-01-05.at.21.30.15.mov

eirikurn · 2022-01-05T21:47:56Z

apps/service-portal/src/components/Sidebar/Sidebar.tsx


  return (
-    <aside className={styles.sidebar}>
-      {navigation.map((rootItem, rootIndex) => (
+    <aside className={cn(styles.sidebar, collapsed && styles.collapsed)}>


Sorry. This still looks weird to me.

There is similar inconsistency in larger screens.

IMHO, our content container should always have the same spacing on left and right (to sidebar and page edge). On smaller screen sizes, we should use all available space except for 24px or whatever whitespace aligns with the overall page margin.

eirikurn · 2022-01-05T21:50:56Z

apps/service-portal/src/components/Sidebar/Sidebar.tsx


  return (
-    <aside className={styles.sidebar}>
-      {navigation.map((rootItem, rootIndex) => (
+    <aside className={cn(styles.sidebar, collapsed && styles.collapsed)}>


It looks like the horizontal whitespace of the page content is now spread over 3 elements. It would be nice if they could be simplified somehow. Happy to jump on a call to discuss the issue or brainstorm css for this.

commit f30fbdc Author: Ívar Oddsson <[email protected]> Date: Tue Jan 11 13:39:13 2022 +0000 fix(judicial-system): Fix iCal end time (#6207) Co-authored-by: Ívar Oddsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 61bb744 Author: Sævar Már Atlason <[email protected]> Date: Tue Jan 11 12:57:42 2022 +0000 chore(core): Rename user to auth for dependents of Audit library (#6188) * Renamed user->auth in audit library and fixed tests. * Renaming user->auth in dependents using the Audit library. * Updating the library readme. commit 0527d7a Author: Rúnar Vestmann <[email protected]> Date: Tue Jan 11 10:37:30 2022 +0000 fix(web): Organization subpage not updating the data regarding Organization page on sync (#6199) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit de2b254 Author: Ásdís Erna Guðmundsdóttir <[email protected]> Date: Tue Jan 11 10:27:50 2022 +0000 feat(service-portal): Tablet UI (#6184) * feat: add sidebar menu state * feat: sidebar fixed to left and hover/active state for nav items * refactor: heading and font sizes * refactor: make button smaller on greeting link * refactor: white background on mobile menu * feat: add xs size to datePicker, Input and Select CORE * feat: add sidebar as a variant option * refactor: rearrange finance data * refactor: add keywords to messages * refactor: remove image from screens * refactor: move school tag * refactor: family screens * refactor: use xs input in settings * refactor: make headings smaller in settings * refactor: put search input in grid * refactor: move title for student assessment tables * refactor: sidebar positioned absolute instead of fixed * fix: undo removing image from access control * feat: add fullScreen prop to UserDropdown * fix: add logo back when on mobile * refactor: toggle animation * refactor: add transition to layout grid * refactor: speed up layoutgrid transition time * feat: new userMenu design * refactor: add close on userMenu click * fix: rollback changes on shared userMenu add service portal userMenu instead * feat: design changes to mobilemenu * feat: add new general error screen * refactor: more space for main content * refactor: cleanup * feat: add lock icon to disabled nav items * feat: add graphql function to get unreadDocumentsCount WIP * feat: badge for unread mail + lock screen * refactor: make unread mail bold + smaller font * fix: lint warnings * refactor: cleanup * fix: hide text on smaller screens on finance row * refactor: more cleanup * fix: build error on styleVariants * fix: default value for unread documents * fix: default value for unread documents counter * fix: remove sidebar variant from text ui core lib * refactor: image on greeting screen * fix: bug after removing sidebar variant from text * fix: add back button "back to my pages" * fix: sidebar stopping on scroll * fix: userMenu should not be part of grid * fix: small logo disappearing when sidebar collapses * feat: headingVariant prop added to island-ui core ActionCard * refactor: assets overview * fix: add bottom spacing to main content * fix: remove header from assetsDetail * refactor: smaller font for assetDisclaimer * refactor: refactoring unused stuff * refactor: cleanup grid in Layout * fix: revert fixing lint warnings * fix: remove activeIcon from masterNavigation * fix: userMenu active state WIP * fix: larger font on tables * fix: smaller heading + intro text on petitions * fix: hide family relation tags until fixed * fix: broken test on UserMenu * refactor: finance status screen * refactor: move data fetch for userDelegations to parent * fix: font weight on user info content * refactor: make headings h3 and add xs size variant for input * fix: build errors * fix: undefined error on e2e test * fix: temp removal of e2e test * fix: removal of kennitala function * fix: spacing on sidebar + removal of unused text * refactor: sidebar nav items * fix: uncomment e2e test bug * fix: removal of company icon in user dropdown * feat: add change lang button next to user menu * fix: add max-content to arrow Link to prevent breaking * fix: switch profile and actor names on user dropdown * refactor: make font color darker in sidebar * fix: wrong tag color on access denied * feat: new collapsed sidebar * feat: add lock icon to subnav + hide if parent is disabled * fix: position of lock icons * Minor fixes * fix: subitems +1 pixel .... * refactor: xs for Datepicker components * refactor: xs for Input & InputController components * refactor: xs for Select component * refactor: add text medium and force styling on table * feat: add missing tag variant mint * feat: add stories for Action Card using small heading * feat: add stories for input * feat: add stories to Select * feat: add stories for DatePicker * refactor: cleanup * refactor: test for switching languages * fix: add scroll on userDelegations * feat: add darkBlue color option for UserAvatar * feat: add or edit alt on images * refactor: remove {} wrapping when using string values * refactor: grid layout in SP layout * fix: hopefully fixing buggy hover on sidebar * refactor: classnames usage * fix: dry pattern on Layout helpers * fix: remove unec classname use * fix: wrong path for hourglass svg * refactor: remove dry pattern in select return * fix: subitems not closing menu on click * fix: avatar color when delegation * feat: add medium variant as button text option * refactor: smaller font on search results * fix: remove settings from sidebar * feat: add path header to accessDenied * refactor: temp change to make button smaller * refactor: smaller text on access table * fix: forgot to commit checkox changes * refactor: input sizes on documents datepicker * refactor: text changes * refactor: smaller padding on mobile logo * fix: delete endorsments like on main * fix: back to SM input for access detail table * fix: link not working outside service portal * fix: remove table styling on access items * fix: revert changes on grant access component * fix: userMenu not responsive + other comments * fix: base url for settings * fix: remove temp data * fix: layout * fix: remove text on plus button for finance tables * fix: put grid container back * fix: sidebar animation * fix: revert changes for small input * fix: relative links on userDropdown * feat: fixes after comment + dropdown lang for mobile * refactor: cleanup on Layout helpers * feat: add breadcrumbs for settings * feat: ui changes on menu + userMenu on mobile * fix: finance content going under on smaller screens * fix: spacing on mobile menu * fix: dont display collapsed state on mobilemenu * fix: revert padding changes * fix: fixing userMenu test * fix: display heading as heading * fix: revert adding mint variant on Tag * fix: fixing menu bug * refactor: layout * fix: revert pushing mock data! * fix: spacing should use theme * fix: use translations for alt text * fix: wrong usage of willChange * fix: casing issue * feat: changes on menu * fix: wrong color on collapsed active item * feat: add tablet layout changes * fix: spacing on submenu * fix: missing pixel Co-authored-by: Ólafur Sverrir Kjartansson <[email protected]> Co-authored-by: Þórður Hafliðason <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 795fb6d Author: arnorhs <[email protected]> Date: Tue Jan 11 10:17:48 2022 +0000 chore(application-templates-driving-license): instrumenting more logging in the submit application action (#6197) * chore(application-templates-driving-license): instrumenting more logging in the submit application action * import type Logger Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 29380fe Author: albinagu <[email protected]> Date: Tue Jan 11 09:03:05 2022 +0000 fix(web): correcting the look of the back buttons on news article screens (#6091) * using link instead of link provider? for the correct look :3 * Add truncate option for Button * Remove use of link context Co-authored-by: Kristjan Albert Loftsson <[email protected]> commit 1e3b3a5 Author: Ívar Oddsson <[email protected]> Date: Mon Jan 10 22:05:34 2022 +0000 feat(judicial-system): End of session bookings (#6162) * Replaces custody restrictions and other restrictions with is custody isolation and end of session bookings * Add end of session bookings to restriction cases * Add end of session bookings to restriction cases * Add end of session bookings to investigation cases * Add other restriction request to autofill * Use isCustodyIsolation instead of ISOLATION in caseRestrictions * Fix tests * Remove unused check from if statement * Remove validation from endOfSessionBookings * Remove unused code * Remove validation from end of session bookinsg * Fix tests * Add end of session bookings title in court record accordion to CF * Fix e2e tests * Fix e2e tests * Fix e2e test * Fix e2e test Co-authored-by: Guðjón Guðjónsson <[email protected]> Co-authored-by: Ívar Oddsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit d268e5a Author: miamiultras <[email protected]> Date: Mon Jan 10 16:31:44 2022 +0000 feat(skilavottord): pagination and infinite scroll (#6195) * Where and before should be optional * Relay like pagination of skilavottordAllDeregisteredVehicles * Cleanup schema * add infinite scroll * Provide default type for generic Co-authored-by: Darri Steinn Konradsson <[email protected]> commit 82120a8 Author: Eiríkur Heiðar Nilsson <[email protected]> Date: Mon Jan 10 16:11:46 2022 +0000 chore(codeowners): Simplify aranja teams (#6196) commit cb72222 Author: Ívar Oddsson <[email protected]> Date: Mon Jan 10 15:24:57 2022 +0000 fix(judicial-system): Fixes to iCal invites (#6193) Co-authored-by: Ívar Oddsson <[email protected]> commit 5129b31 Author: Darri Steinn Konráðsson <[email protected]> Date: Mon Jan 10 12:27:14 2022 +0000 fix(skilavottord): fix permno of undefined (#6189) * Verify that items in list are not undefined * Only check if vehicle exists if the user is requesting deregistration commit e2e939c Author: Rúnar Vestmann <[email protected]> Date: Mon Jan 10 11:44:31 2022 +0000 fix(web): Article organization slug not changing on sync (#6185) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 7c3a0e8 Author: Kristján Albert <[email protected]> Date: Mon Jan 10 11:35:59 2022 +0000 feat(island-ui): allow no heading for AlertMessage (#6179) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 1b7888c Author: Sævar Már Atlason <[email protected]> Date: Mon Jan 10 11:21:29 2022 +0000 feat(audit): Updating audit to support auditing from auth object without nationalId. (#6165) * Updating audit to support auditing from auth object without nationalId. * Removing comment. Sort imports. Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 9c010ae Author: Davíð Guðni Halldórsson <[email protected]> Date: Mon Jan 10 12:08:05 2022 +0100 fix(auth-nest-tools): Use x-forwarded-for in audit logs (#6166) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 026f7d6 Author: Eiríkur Heiðar Nilsson <[email protected]> Date: Mon Jan 10 08:14:35 2022 +0000 chore(dependabot): Remove hard-coded reviewers (#6182) These PRs should use the codeowners rules like any other PRs. Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 13ff809 Author: Eiríkur Heiðar Nilsson <[email protected]> Date: Sun Jan 9 10:28:10 2022 +0000 chore(assets): Configure token exchange for Properties API (#6131) * Refactor assets configuration * Configure token exchange in properties api * Remove properties scope from service portal * Charts * Feedback * Fixes * Format Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 4f24b0a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 7 19:10:36 2022 +0000 chore(deps-dev): bump jest from 27.4.6 to 27.4.7 in /.github/actions (#6145) Bumps [jest](https://github.com/facebook/jest) from 27.4.6 to 27.4.7. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](jestjs/jest@v27.4.6...v27.4.7) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 293cd8d Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 7 19:06:43 2022 +0000 chore(deps-dev): bump typescript from 4.4.4 to 4.5.2 in /.github/actions (#5676) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.4.4 to 4.5.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.4.4...v4.5.2) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sindri Guðmundsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 94e4f1c Author: Sindri Guðmundsson <[email protected]> Date: Fri Jan 7 18:52:53 2022 +0000 feat(testing): Infra/support for external contract tests (#5771) * Getting started with external contract tests "app" * Build with esbuild and first test Set limits on cronjob Run at 11 * Remove entrypoint * bringing back jest-to-dd script * switching to using the new NationalRegistry client * cleaning up and fixing minor issues * a bit better docs * Revert "a bit better docs" This reverts commit ebe542e. * Revert "cleaning up and fixing minor issues" This reverts commit 5a4d596. * Revert "switching to using the new NationalRegistry client" This reverts commit a0b95b0. * renaming the spec file to match with the test target Co-authored-by: Petar Shomov <[email protected]> commit fbb5db8 Author: arnorhs <[email protected]> Date: Fri Jan 7 17:11:56 2022 +0000 chore(user-notification): removing worker health check (#6177) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 080da8e Author: Kristján Albert <[email protected]> Date: Fri Jan 7 17:01:15 2022 +0000 chore(web): a11y tweaks (#6170) * Move id for main-content further up on sidebar layout * Make direct link suggestions selectable with keyboard like other items * Refactor a bit * One more change Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 9024040 Author: albinagu <[email protected]> Date: Fri Jan 7 14:47:36 2022 +0000 fix(general-petition): adding access to endorsement id with externalData for signaturee (#6176) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 595511c Author: Ásdís Erna Guðmundsdóttir <[email protected]> Date: Fri Jan 7 13:30:45 2022 +0000 feat(service-portal): new design (#5784) * feat: add sidebar menu state * feat: sidebar fixed to left and hover/active state for nav items * refactor: heading and font sizes * refactor: make button smaller on greeting link * refactor: white background on mobile menu * feat: add xs size to datePicker, Input and Select CORE * feat: add sidebar as a variant option * refactor: rearrange finance data * refactor: add keywords to messages * refactor: remove image from screens * refactor: move school tag * refactor: family screens * refactor: use xs input in settings * refactor: make headings smaller in settings * refactor: put search input in grid * refactor: move title for student assessment tables * refactor: sidebar positioned absolute instead of fixed * fix: undo removing image from access control * feat: add fullScreen prop to UserDropdown * fix: add logo back when on mobile * refactor: toggle animation * refactor: add transition to layout grid * refactor: speed up layoutgrid transition time * feat: new userMenu design * refactor: add close on userMenu click * fix: rollback changes on shared userMenu add service portal userMenu instead * feat: design changes to mobilemenu * feat: add new general error screen * refactor: more space for main content * refactor: cleanup * feat: add lock icon to disabled nav items * feat: add graphql function to get unreadDocumentsCount WIP * feat: badge for unread mail + lock screen * refactor: make unread mail bold + smaller font * fix: lint warnings * refactor: cleanup * fix: hide text on smaller screens on finance row * refactor: more cleanup * fix: build error on styleVariants * fix: default value for unread documents * fix: default value for unread documents counter * fix: remove sidebar variant from text ui core lib * refactor: image on greeting screen * fix: bug after removing sidebar variant from text * fix: add back button "back to my pages" * fix: sidebar stopping on scroll * fix: userMenu should not be part of grid * fix: small logo disappearing when sidebar collapses * feat: headingVariant prop added to island-ui core ActionCard * refactor: assets overview * fix: add bottom spacing to main content * fix: remove header from assetsDetail * refactor: smaller font for assetDisclaimer * refactor: refactoring unused stuff * refactor: cleanup grid in Layout * fix: revert fixing lint warnings * fix: remove activeIcon from masterNavigation * fix: userMenu active state WIP * fix: larger font on tables * fix: smaller heading + intro text on petitions * fix: hide family relation tags until fixed * fix: broken test on UserMenu * refactor: finance status screen * refactor: move data fetch for userDelegations to parent * fix: font weight on user info content * refactor: make headings h3 and add xs size variant for input * fix: build errors * fix: undefined error on e2e test * fix: temp removal of e2e test * fix: removal of kennitala function * fix: spacing on sidebar + removal of unused text * refactor: sidebar nav items * fix: uncomment e2e test bug * fix: removal of company icon in user dropdown * feat: add change lang button next to user menu * fix: add max-content to arrow Link to prevent breaking * fix: switch profile and actor names on user dropdown * refactor: make font color darker in sidebar * fix: wrong tag color on access denied * feat: new collapsed sidebar * feat: add lock icon to subnav + hide if parent is disabled * fix: position of lock icons * Minor fixes * fix: subitems +1 pixel .... * refactor: xs for Datepicker components * refactor: xs for Input & InputController components * refactor: xs for Select component * refactor: add text medium and force styling on table * feat: add missing tag variant mint * feat: add stories for Action Card using small heading * feat: add stories for input * feat: add stories to Select * feat: add stories for DatePicker * refactor: cleanup * refactor: test for switching languages * fix: add scroll on userDelegations * feat: add darkBlue color option for UserAvatar * feat: add or edit alt on images * refactor: remove {} wrapping when using string values * refactor: grid layout in SP layout * fix: hopefully fixing buggy hover on sidebar * refactor: classnames usage * fix: dry pattern on Layout helpers * fix: remove unec classname use * fix: wrong path for hourglass svg * refactor: remove dry pattern in select return * fix: subitems not closing menu on click * fix: avatar color when delegation * feat: add medium variant as button text option * refactor: smaller font on search results * fix: remove settings from sidebar * feat: add path header to accessDenied * refactor: temp change to make button smaller * refactor: smaller text on access table * fix: forgot to commit checkox changes * refactor: input sizes on documents datepicker * refactor: text changes * refactor: smaller padding on mobile logo * fix: delete endorsments like on main * fix: back to SM input for access detail table * fix: link not working outside service portal * fix: remove table styling on access items * fix: revert changes on grant access component * fix: userMenu not responsive + other comments * fix: base url for settings * fix: remove temp data * fix: layout * fix: remove text on plus button for finance tables * fix: put grid container back * fix: sidebar animation * fix: revert changes for small input * fix: relative links on userDropdown * feat: fixes after comment + dropdown lang for mobile * refactor: cleanup on Layout helpers * feat: add breadcrumbs for settings * feat: ui changes on menu + userMenu on mobile * fix: finance content going under on smaller screens * fix: spacing on mobile menu * fix: dont display collapsed state on mobilemenu * fix: revert padding changes * fix: fixing userMenu test * fix: display heading as heading * fix: revert adding mint variant on Tag * fix: fixing menu bug * refactor: layout * fix: revert pushing mock data! * fix: spacing should use theme * fix: use translations for alt text * fix: wrong usage of willChange * fix: casing issue * feat: changes on menu * fix: wrong color on collapsed active item * fix: hover states on nav items * fix: padding variable * fix: spacing on small screens * revert: changes on collapsed nav items Co-authored-by: Ólafur Sverrir Kjartansson <[email protected]> Co-authored-by: Þórður Hafliðason <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 50f5d0f Author: Alexandra Diljá Birkisdóttir <[email protected]> Date: Fri Jan 7 13:10:09 2022 +0000 fix(endorsement-system): Text fixes (#6174) * template text adjustments * lock list text for admin * format * messageId Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 70083b6 Author: miamiultras <[email protected]> Date: Fri Jan 7 11:57:58 2022 +0000 fix(island-ui): fix datepicker without label (#6175) commit 3b39f78 Author: Alexandra Diljá Birkisdóttir <[email protected]> Date: Fri Jan 7 11:25:51 2022 +0000 fix(P-Sign-application): Adding to json (#6172) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit eb719d2 Author: Kristján Albert <[email protected]> Date: Fri Jan 7 11:17:25 2022 +0000 feat(island-ui): image/logo option for CategoryCard (#6125) * Add image option for CategoryCard * Change hasImage check Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 66cf7bc Author: Ívar Oddsson <[email protected]> Date: Fri Jan 7 10:35:29 2022 +0000 chore(judicial-system): Use "Varnaraðili" instead of "Sakborningur" everywhere (#6171) * Change Sakborningur to varnaraðili * Use Varnaradili in info card * Use Varnaradili in policeRequestAccordionItem * Use accused from core in requests table * Fix tests Co-authored-by: Ívar Oddsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit ec500fe Author: Rúnar Vestmann <[email protected]> Date: Fri Jan 7 09:43:42 2022 +0000 fix(web): Organization searchbox should appear when language is set to english (#6169) * Changed WITH_SEARCH list to also contain english slugs * Removed unused imports Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit bba751c Author: miamiultras <[email protected]> Date: Fri Jan 7 09:21:09 2022 +0000 fix(island-ui): revisit disabled state, fix missing disabled states, add missing stories (#6154) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 88a84cc Author: albinagu <[email protected]> Date: Fri Jan 7 09:07:31 2022 +0000 feat(p-sign): P-Sign Application Template (#5874) * innitial commit: P-Sign application template * adding p-sign to codeowners * gitbook * upload photo logic * using JurisdictionProvider for dropdown options * updating dataSchema * alert on no photo and some touching up * tweak * build fix * more of photo fixing up * generate types fixed in workspace * missing } * fixing bad conflict merge * ready for prod: false * review fixes * updating providers texts * using dataproviders from shared folder * no api modules * build fix * adding doctors note provider setup and updating texts * formatting date in overview * certificate and district providers * submit * provider * format * dataproviders stop if no data from syslumenn * update test * update application state on submit * clean up * fixing linitng * bullets fix í ph upload * tweak photo view * tweaks * linting and config * cleanup * getFileContentAsBase64 * attachment * updating texts file with unique translation namespace * application type translation id * photo preview * submission photo * quality photo or upload * rm cl * use quality or upload * minor format * preview * cleanup * qualityphoto from external * submission s3 * cleaning up preview on upload * rm getFileContentAsBase64 * clean and format * photp upload * comments addressed * cleanup * x Co-authored-by: Alexandra Diljá <[email protected]> Co-authored-by: Alexandra Diljá Birkisdóttir <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit c2c47d1 Author: miamiultras <[email protected]> Date: Fri Jan 7 07:52:21 2022 +0000 fix(island-ui): fix icon size for small button (#6163) commit dff7388 Author: rafnarnason <[email protected]> Date: Thu Jan 6 19:49:41 2022 +0000 fix(user-profile): Hook up to new user profile client (#6159) * hooked api domains user profile to clients * removed unecessary generator * format Co-authored-by: Rafn Árnason <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 33aed9a Author: kksteini <[email protected]> Date: Thu Jan 6 17:20:53 2022 +0000 chore(cms): Removed unused content model, 'location' (#6164) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 7ea180d Author: Ívar Oddsson <[email protected]> Date: Thu Jan 6 16:25:29 2022 +0000 feat(judicial-system): Send a calendar invite with court date notification to defender and prosecutor (#6132) * Send a calendar invite with court date notification to defender and prosecutor * Revert env changes * Always send an ical invite to defenders * Skip flaky tests Co-authored-by: Ívar Oddsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 16e3913 Author: arnorhs <[email protected]> Date: Thu Jan 6 16:12:52 2022 +0000 chore(services-user-notification): set worker argument correctly (#6124) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 6f6fc45 Author: Guðjón Guðjónsson <[email protected]> Date: Thu Jan 6 15:22:35 2022 +0000 chore(judicial-system): Improved error responses (#6062) * Improved error responses * Improves error handling * Improves error handling * Fixes broken unit test * Renames exception filter * Improves logging and error handling * Rewrite find by id and create * Rewrites update and extend * Makes return value optional on update * Fixes type errors * Fixes linting issues * Renames case variables * Rewrites contentful access * Fixes broken tests * Rewrites logging * Rewrites error handling and logging * Rewrites logging * Rewrites logging * Rewrites logging * Renames arguments and rewrites loggin * Adds http exception filter to xrd api * Improves logging * Uses shared problem filters in backend and xrd api * Rewrites error handling * Uses shared problem filters in api * Fixes unit tests * Fixes e2e test * Fixes e2e test * Fixes handling of existing problems and logging of problems with no status * Fixes build error * Removes console log * Adds tests * Update libs/nest/problem/src/lib/base-problem.filter.spec.ts Fix test desctiption Co-authored-by: Eiríkur Heiðar Nilsson <[email protected]> Co-authored-by: Eiríkur Heiðar Nilsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit e147674 Author: albinagu <[email protected]> Date: Thu Jan 6 15:06:41 2022 +0000 fix(web): SearchBox update for search in /s/syslumenn (#5767) * Search all on icon click * changing SearchBox to use AsyncSearch * smá tweak * debounce and a few minor tweaks * format * Show loading icon while typing, enabled english search and improved keyboard navigation (tab, enter and arrow keys) (#6160) Co-authored-by: Rúnar Vestmann <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 34fe46f Author: Rikard Arnar B. Birgisson <[email protected]> Date: Thu Jan 6 14:31:43 2022 +0000 chore(as): Remove dead code (#6142) * Removes unused application * Removes joint custody from core files Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 80457d2 Author: Guðjón Ingi Magnússon <[email protected]> Date: Thu Jan 6 12:26:12 2022 +0000 feat(personal-representative): personal representative delegation support (#6122) * Added personal representative delegation support for client and api-scopes * Added properties to Client and ApiScope models Co-authored-by: Gudjon <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 14e3532 Author: MargretFinnboga <[email protected]> Date: Thu Jan 6 11:55:19 2022 +0000 fix(fa): Fixing click outside of aid amount modal (#6147) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit f85c833 Author: Petar Shomov <[email protected]> Date: Thu Jan 6 11:25:52 2022 +0000 fix(ci): giving CI last good build script bigger window of SHAs to choose from (#6157) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

disaerna added 30 commits November 18, 2021 11:17

feat: add sidebar menu state

e31ec21

feat: sidebar fixed to left and

6147fd0

hover/active state for nav items

refactor: heading and font sizes

3b94ce4

refactor: make button smaller on greeting link

0aa9690

refactor: white background on mobile menu

306ebf7

feat: add xs size to datePicker, Input and Select CORE

1b6fbc3

feat: add sidebar as a variant option

2b69d14

refactor: rearrange finance data

dffcaf6

refactor: add keywords to messages

8eae727

refactor: remove image from screens

e51357c

refactor: move school tag

f0eab54

refactor: family screens

da92a2b

fix: merge conflict - resolve messages

93b1c4a

refactor: use xs input in settings

14a5004

refactor: make headings smaller in settings

5a400e8

refactor: put search input in grid

1b68bf4

refactor: move title for student assessment tables

382ce42

Merge branch 'main' into service-portal/new-design-sidebar

ce97c18

refactor: sidebar positioned absolute instead of fixed

573b33a

Merge branch 'service-portal/new-design-main' into service-portal/new…

741b09c

…-design-demo

fix: undo removing image from access control

835ea75

feat: add fullScreen prop to UserDropdown

eed8586

Merge branch 'service-portal/new-design-main' into service-portal/new…

9ad5f33

…-design-demo

Merge branch 'service-portal/new-design-sidebar' into service-portal/…

55f07a8

…new-design-demo

fix: add logo back when on mobile

0372ace

refactor: toggle animation

85f1727

Merge branch 'service-portal/new-design-sidebar' into service-portal/…

6d44b0c

…new-design-demo

refactor: add transition to layout grid

2e38aa3

refactor: speed up layoutgrid transition time

a0eed54

feat: new userMenu design

e088299

darrikonn suggested changes Jan 3, 2022

View reviewed changes

disaerna added 6 commits January 3, 2022 13:16

fix: fixing menu bug

468ccd2

refactor: layout

0203f89

fix: revert pushing mock data!

59f8104

fix: spacing should use theme

bdbd7c3

fix: use translations for alt text

6b8cfba

Merge branch 'main' into service-portal/new-design-demo

b932201

darrikonn suggested changes Jan 3, 2022

View reviewed changes

fix: wrong usage of willChange

24f8082

darrikonn reviewed Jan 3, 2022

View reviewed changes

fix: casing issue

3803687

darrikonn approved these changes Jan 3, 2022

View reviewed changes

disaerna added 3 commits January 4, 2022 12:24

feat: changes on menu

ed0bc23

Merge branch 'main' into service-portal/new-design-demo

01df60d

fix: wrong color on collapsed active item

b3b4903

oddsson approved these changes Jan 5, 2022

View reviewed changes

eirikurn approved these changes Jan 5, 2022

View reviewed changes

disaerna added 3 commits January 6, 2022 15:20

fix: hover states on nav items

88127e0

fix: padding variable

4432fae

fix: spacing on small screens

d144902

DavidBachmann approved these changes Jan 7, 2022

View reviewed changes

disaerna removed the request for review from saevarma January 7, 2022 09:32

disaerna added 2 commits January 7, 2022 09:59

Merge branch 'main' into service-portal/new-design-demo

e426287

revert: changes on collapsed nav items

ca69f21

disaerna added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Jan 7, 2022

Merge branch 'main' into service-portal/new-design-demo

c97b240

kodiakhq bot merged commit 595511c into main Jan 7, 2022

kodiakhq bot deleted the service-portal/new-design-demo branch January 7, 2022 13:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(service-portal): new design #5784

feat(service-portal): new design #5784

disaerna commented Nov 29, 2021 •

edited

Loading

darrikonn Jan 3, 2022

disaerna Jan 3, 2022

darrikonn Jan 3, 2022

disaerna Jan 3, 2022

darrikonn Jan 3, 2022

disaerna Jan 3, 2022

darrikonn Jan 3, 2022

darrikonn Jan 3, 2022

disaerna Jan 3, 2022

darrikonn Jan 3, 2022

darrikonn Jan 3, 2022

disaerna Jan 3, 2022

darrikonn Jan 3, 2022

disaerna Jan 3, 2022

darrikonn commented Jan 3, 2022

darrikonn left a comment

darrikonn Jan 3, 2022

disaerna Jan 3, 2022

darrikonn Jan 3, 2022

disaerna Jan 3, 2022

eirikurn left a comment

eirikurn Jan 5, 2022

eirikurn Jan 5, 2022

eirikurn Jan 5, 2022

darrikonn Jan 6, 2022

eirikurn Jan 5, 2022

darrikonn Jan 6, 2022

eirikurn Jan 5, 2022

eirikurn Jan 5, 2022

eirikurn Jan 5, 2022

feat(service-portal): new design #5784

feat(service-portal): new design #5784

Conversation

disaerna commented Nov 29, 2021 • edited Loading

New design for service portal 🎉

What

Why

Screenshots / Gifs

Sidebar:

UserMenu:

Mobile Menu

Layout:

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darrikonn commented Jan 3, 2022

darrikonn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eirikurn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

disaerna commented Nov 29, 2021 •

edited

Loading