fix(auth-nest-tools): Use x-forwarded-for in audit logs #6166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabbeg
force-pushed
the
use-x-forwarded-for-in-audit-logs
branch
from
db120ec to
44ebe28
Compare
Codecov Report
@@ Coverage Diff @@
## main #6166 +/- ##
=======================================
Coverage 29.64% 29.64%
=======================================
Files 2926 2926
Lines 47194 47194
Branches 11408 11408
=======================================
Hits 13989 13989
Misses 33205 33205
Flags with carried forward coverage won't be shown. Click here to find out more. |
dabbeg
force-pushed
the
use-x-forwarded-for-in-audit-logs
branch
from
44ebe28 to
6dc30bd
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
dabbeg
force-pushed
the
use-x-forwarded-for-in-audit-logs
branch
from
6dc30bd to
258283d
Compare
eirikurn
reviewed
Jan 6, 2022
| @@ -54,7 +54,7 @@ export class JwtStrategy extends PassportStrategy(Strategy) { | |||
| nationalId: actor.nationalId, | |||
| scope: this.parseScopes(actor.scope), | |||
| }, | |||
| ip: String(request.headers['x-real-ip']) ?? request.ip, | |||
| ip: String(request.headers['x-forwarded-for'] ?? request.ip), | |||
There was a problem hiding this comment.
The plan was originally to use Express's built in support for parsing X-Forwarded-For:
http://expressjs.com/en/guide/behind-proxies.html
There's already an environment variable set up which we can use to configure this everywhere.
The tricky thing is that all of this needs to also support requests within our infrastructure, which currently set the x-real-ip header.
We at least need to switch that to set the x-forwarded-for header, but I would really like for us to configure the "trust proxy" value correctly and just use express's calculated request.ip here.
Our internal APIs could have EXPRESS_TRUST_PROXY=1. But our "public" apps might need some environment-specific value, either the correct number of proxies, or an array with whitelisted IP ranges.
There was a problem hiding this comment.
I like the whitelist approach but because the cloudfront ips can change it might be troublesome to hardcode them.
The number approach feels a bit fragile, if either the number of ip's would increase or decrease it would break.
If it would decrease the user could enter any ip in the X-Forwarded-For header and we would use it.
I would choose to log them all for the time being, but I know this is not a great solution for the long term.
dabbeg
force-pushed
the
use-x-forwarded-for-in-audit-logs
branch
from
258283d to
8491910
Compare
eirikurn
approved these changes
Jan 7, 2022
dabbeg
added
the
deprecated:automerge
johannaagma
added a commit
that referenced
this pull request
Jan 11, 2022
commit f30fbdc Author: Ívar Oddsson <[email protected]> Date: Tue Jan 11 13:39:13 2022 +0000 fix(judicial-system): Fix iCal end time (#6207) Co-authored-by: Ívar Oddsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 61bb744 Author: Sævar Már Atlason <[email protected]> Date: Tue Jan 11 12:57:42 2022 +0000 chore(core): Rename user to auth for dependents of Audit library (#6188) * Renamed user->auth in audit library and fixed tests. * Renaming user->auth in dependents using the Audit library. * Updating the library readme. commit 0527d7a Author: Rúnar Vestmann <[email protected]> Date: Tue Jan 11 10:37:30 2022 +0000 fix(web): Organization subpage not updating the data regarding Organization page on sync (#6199) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit de2b254 Author: Ásdís Erna Guðmundsdóttir <[email protected]> Date: Tue Jan 11 10:27:50 2022 +0000 feat(service-portal): Tablet UI (#6184) * feat: add sidebar menu state * feat: sidebar fixed to left and hover/active state for nav items * refactor: heading and font sizes * refactor: make button smaller on greeting link * refactor: white background on mobile menu * feat: add xs size to datePicker, Input and Select CORE * feat: add sidebar as a variant option * refactor: rearrange finance data * refactor: add keywords to messages * refactor: remove image from screens * refactor: move school tag * refactor: family screens * refactor: use xs input in settings * refactor: make headings smaller in settings * refactor: put search input in grid * refactor: move title for student assessment tables * refactor: sidebar positioned absolute instead of fixed * fix: undo removing image from access control * feat: add fullScreen prop to UserDropdown * fix: add logo back when on mobile * refactor: toggle animation * refactor: add transition to layout grid * refactor: speed up layoutgrid transition time * feat: new userMenu design * refactor: add close on userMenu click * fix: rollback changes on shared userMenu add service portal userMenu instead * feat: design changes to mobilemenu * feat: add new general error screen * refactor: more space for main content * refactor: cleanup * feat: add lock icon to disabled nav items * feat: add graphql function to get unreadDocumentsCount WIP * feat: badge for unread mail + lock screen * refactor: make unread mail bold + smaller font * fix: lint warnings * refactor: cleanup * fix: hide text on smaller screens on finance row * refactor: more cleanup * fix: build error on styleVariants * fix: default value for unread documents * fix: default value for unread documents counter * fix: remove sidebar variant from text ui core lib * refactor: image on greeting screen * fix: bug after removing sidebar variant from text * fix: add back button "back to my pages" * fix: sidebar stopping on scroll * fix: userMenu should not be part of grid * fix: small logo disappearing when sidebar collapses * feat: headingVariant prop added to island-ui core ActionCard * refactor: assets overview * fix: add bottom spacing to main content * fix: remove header from assetsDetail * refactor: smaller font for assetDisclaimer * refactor: refactoring unused stuff * refactor: cleanup grid in Layout * fix: revert fixing lint warnings * fix: remove activeIcon from masterNavigation * fix: userMenu active state WIP * fix: larger font on tables * fix: smaller heading + intro text on petitions * fix: hide family relation tags until fixed * fix: broken test on UserMenu * refactor: finance status screen * refactor: move data fetch for userDelegations to parent * fix: font weight on user info content * refactor: make headings h3 and add xs size variant for input * fix: build errors * fix: undefined error on e2e test * fix: temp removal of e2e test * fix: removal of kennitala function * fix: spacing on sidebar + removal of unused text * refactor: sidebar nav items * fix: uncomment e2e test bug * fix: removal of company icon in user dropdown * feat: add change lang button next to user menu * fix: add max-content to arrow Link to prevent breaking * fix: switch profile and actor names on user dropdown * refactor: make font color darker in sidebar * fix: wrong tag color on access denied * feat: new collapsed sidebar * feat: add lock icon to subnav + hide if parent is disabled * fix: position of lock icons * Minor fixes * fix: subitems +1 pixel .... * refactor: xs for Datepicker components * refactor: xs for Input & InputController components * refactor: xs for Select component * refactor: add text medium and force styling on table * feat: add missing tag variant mint * feat: add stories for Action Card using small heading * feat: add stories for input * feat: add stories to Select * feat: add stories for DatePicker * refactor: cleanup * refactor: test for switching languages * fix: add scroll on userDelegations * feat: add darkBlue color option for UserAvatar * feat: add or edit alt on images * refactor: remove {} wrapping when using string values * refactor: grid layout in SP layout * fix: hopefully fixing buggy hover on sidebar * refactor: classnames usage * fix: dry pattern on Layout helpers * fix: remove unec classname use * fix: wrong path for hourglass svg * refactor: remove dry pattern in select return * fix: subitems not closing menu on click * fix: avatar color when delegation * feat: add medium variant as button text option * refactor: smaller font on search results * fix: remove settings from sidebar * feat: add path header to accessDenied * refactor: temp change to make button smaller * refactor: smaller text on access table * fix: forgot to commit checkox changes * refactor: input sizes on documents datepicker * refactor: text changes * refactor: smaller padding on mobile logo * fix: delete endorsments like on main * fix: back to SM input for access detail table * fix: link not working outside service portal * fix: remove table styling on access items * fix: revert changes on grant access component * fix: userMenu not responsive + other comments * fix: base url for settings * fix: remove temp data * fix: layout * fix: remove text on plus button for finance tables * fix: put grid container back * fix: sidebar animation * fix: revert changes for small input * fix: relative links on userDropdown * feat: fixes after comment + dropdown lang for mobile * refactor: cleanup on Layout helpers * feat: add breadcrumbs for settings * feat: ui changes on menu + userMenu on mobile * fix: finance content going under on smaller screens * fix: spacing on mobile menu * fix: dont display collapsed state on mobilemenu * fix: revert padding changes * fix: fixing userMenu test * fix: display heading as heading * fix: revert adding mint variant on Tag * fix: fixing menu bug * refactor: layout * fix: revert pushing mock data! * fix: spacing should use theme * fix: use translations for alt text * fix: wrong usage of willChange * fix: casing issue * feat: changes on menu * fix: wrong color on collapsed active item * feat: add tablet layout changes * fix: spacing on submenu * fix: missing pixel Co-authored-by: Ólafur Sverrir Kjartansson <[email protected]> Co-authored-by: Þórður Hafliðason <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 795fb6d Author: arnorhs <[email protected]> Date: Tue Jan 11 10:17:48 2022 +0000 chore(application-templates-driving-license): instrumenting more logging in the submit application action (#6197) * chore(application-templates-driving-license): instrumenting more logging in the submit application action * import type Logger Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 29380fe Author: albinagu <[email protected]> Date: Tue Jan 11 09:03:05 2022 +0000 fix(web): correcting the look of the back buttons on news article screens (#6091) * using link instead of link provider? for the correct look :3 * Add truncate option for Button * Remove use of link context Co-authored-by: Kristjan Albert Loftsson <[email protected]> commit 1e3b3a5 Author: Ívar Oddsson <[email protected]> Date: Mon Jan 10 22:05:34 2022 +0000 feat(judicial-system): End of session bookings (#6162) * Replaces custody restrictions and other restrictions with is custody isolation and end of session bookings * Add end of session bookings to restriction cases * Add end of session bookings to restriction cases * Add end of session bookings to investigation cases * Add other restriction request to autofill * Use isCustodyIsolation instead of ISOLATION in caseRestrictions * Fix tests * Remove unused check from if statement * Remove validation from endOfSessionBookings * Remove unused code * Remove validation from end of session bookinsg * Fix tests * Add end of session bookings title in court record accordion to CF * Fix e2e tests * Fix e2e tests * Fix e2e test * Fix e2e test Co-authored-by: Guðjón Guðjónsson <[email protected]> Co-authored-by: Ívar Oddsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit d268e5a Author: miamiultras <[email protected]> Date: Mon Jan 10 16:31:44 2022 +0000 feat(skilavottord): pagination and infinite scroll (#6195) * Where and before should be optional * Relay like pagination of skilavottordAllDeregisteredVehicles * Cleanup schema * add infinite scroll * Provide default type for generic Co-authored-by: Darri Steinn Konradsson <[email protected]> commit 82120a8 Author: Eiríkur Heiðar Nilsson <[email protected]> Date: Mon Jan 10 16:11:46 2022 +0000 chore(codeowners): Simplify aranja teams (#6196) commit cb72222 Author: Ívar Oddsson <[email protected]> Date: Mon Jan 10 15:24:57 2022 +0000 fix(judicial-system): Fixes to iCal invites (#6193) Co-authored-by: Ívar Oddsson <[email protected]> commit 5129b31 Author: Darri Steinn Konráðsson <[email protected]> Date: Mon Jan 10 12:27:14 2022 +0000 fix(skilavottord): fix permno of undefined (#6189) * Verify that items in list are not undefined * Only check if vehicle exists if the user is requesting deregistration commit e2e939c Author: Rúnar Vestmann <[email protected]> Date: Mon Jan 10 11:44:31 2022 +0000 fix(web): Article organization slug not changing on sync (#6185) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 7c3a0e8 Author: Kristján Albert <[email protected]> Date: Mon Jan 10 11:35:59 2022 +0000 feat(island-ui): allow no heading for AlertMessage (#6179) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 1b7888c Author: Sævar Már Atlason <[email protected]> Date: Mon Jan 10 11:21:29 2022 +0000 feat(audit): Updating audit to support auditing from auth object without nationalId. (#6165) * Updating audit to support auditing from auth object without nationalId. * Removing comment. Sort imports. Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 9c010ae Author: Davíð Guðni Halldórsson <[email protected]> Date: Mon Jan 10 12:08:05 2022 +0100 fix(auth-nest-tools): Use x-forwarded-for in audit logs (#6166) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 026f7d6 Author: Eiríkur Heiðar Nilsson <[email protected]> Date: Mon Jan 10 08:14:35 2022 +0000 chore(dependabot): Remove hard-coded reviewers (#6182) These PRs should use the codeowners rules like any other PRs. Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 13ff809 Author: Eiríkur Heiðar Nilsson <[email protected]> Date: Sun Jan 9 10:28:10 2022 +0000 chore(assets): Configure token exchange for Properties API (#6131) * Refactor assets configuration * Configure token exchange in properties api * Remove properties scope from service portal * Charts * Feedback * Fixes * Format Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 4f24b0a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 7 19:10:36 2022 +0000 chore(deps-dev): bump jest from 27.4.6 to 27.4.7 in /.github/actions (#6145) Bumps [jest](https://github.com/facebook/jest) from 27.4.6 to 27.4.7. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](jestjs/jest@v27.4.6...v27.4.7) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 293cd8d Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 7 19:06:43 2022 +0000 chore(deps-dev): bump typescript from 4.4.4 to 4.5.2 in /.github/actions (#5676) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.4.4 to 4.5.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.4.4...v4.5.2) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sindri Guðmundsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 94e4f1c Author: Sindri Guðmundsson <[email protected]> Date: Fri Jan 7 18:52:53 2022 +0000 feat(testing): Infra/support for external contract tests (#5771) * Getting started with external contract tests "app" * Build with esbuild and first test Set limits on cronjob Run at 11 * Remove entrypoint * bringing back jest-to-dd script * switching to using the new NationalRegistry client * cleaning up and fixing minor issues * a bit better docs * Revert "a bit better docs" This reverts commit ebe542e. * Revert "cleaning up and fixing minor issues" This reverts commit 5a4d596. * Revert "switching to using the new NationalRegistry client" This reverts commit a0b95b0. * renaming the spec file to match with the test target Co-authored-by: Petar Shomov <[email protected]> commit fbb5db8 Author: arnorhs <[email protected]> Date: Fri Jan 7 17:11:56 2022 +0000 chore(user-notification): removing worker health check (#6177) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 080da8e Author: Kristján Albert <[email protected]> Date: Fri Jan 7 17:01:15 2022 +0000 chore(web): a11y tweaks (#6170) * Move id for main-content further up on sidebar layout * Make direct link suggestions selectable with keyboard like other items * Refactor a bit * One more change Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 9024040 Author: albinagu <[email protected]> Date: Fri Jan 7 14:47:36 2022 +0000 fix(general-petition): adding access to endorsement id with externalData for signaturee (#6176) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 595511c Author: Ásdís Erna Guðmundsdóttir <[email protected]> Date: Fri Jan 7 13:30:45 2022 +0000 feat(service-portal): new design (#5784) * feat: add sidebar menu state * feat: sidebar fixed to left and hover/active state for nav items * refactor: heading and font sizes * refactor: make button smaller on greeting link * refactor: white background on mobile menu * feat: add xs size to datePicker, Input and Select CORE * feat: add sidebar as a variant option * refactor: rearrange finance data * refactor: add keywords to messages * refactor: remove image from screens * refactor: move school tag * refactor: family screens * refactor: use xs input in settings * refactor: make headings smaller in settings * refactor: put search input in grid * refactor: move title for student assessment tables * refactor: sidebar positioned absolute instead of fixed * fix: undo removing image from access control * feat: add fullScreen prop to UserDropdown * fix: add logo back when on mobile * refactor: toggle animation * refactor: add transition to layout grid * refactor: speed up layoutgrid transition time * feat: new userMenu design * refactor: add close on userMenu click * fix: rollback changes on shared userMenu add service portal userMenu instead * feat: design changes to mobilemenu * feat: add new general error screen * refactor: more space for main content * refactor: cleanup * feat: add lock icon to disabled nav items * feat: add graphql function to get unreadDocumentsCount WIP * feat: badge for unread mail + lock screen * refactor: make unread mail bold + smaller font * fix: lint warnings * refactor: cleanup * fix: hide text on smaller screens on finance row * refactor: more cleanup * fix: build error on styleVariants * fix: default value for unread documents * fix: default value for unread documents counter * fix: remove sidebar variant from text ui core lib * refactor: image on greeting screen * fix: bug after removing sidebar variant from text * fix: add back button "back to my pages" * fix: sidebar stopping on scroll * fix: userMenu should not be part of grid * fix: small logo disappearing when sidebar collapses * feat: headingVariant prop added to island-ui core ActionCard * refactor: assets overview * fix: add bottom spacing to main content * fix: remove header from assetsDetail * refactor: smaller font for assetDisclaimer * refactor: refactoring unused stuff * refactor: cleanup grid in Layout * fix: revert fixing lint warnings * fix: remove activeIcon from masterNavigation * fix: userMenu active state WIP * fix: larger font on tables * fix: smaller heading + intro text on petitions * fix: hide family relation tags until fixed * fix: broken test on UserMenu * refactor: finance status screen * refactor: move data fetch for userDelegations to parent * fix: font weight on user info content * refactor: make headings h3 and add xs size variant for input * fix: build errors * fix: undefined error on e2e test * fix: temp removal of e2e test * fix: removal of kennitala function * fix: spacing on sidebar + removal of unused text * refactor: sidebar nav items * fix: uncomment e2e test bug * fix: removal of company icon in user dropdown * feat: add change lang button next to user menu * fix: add max-content to arrow Link to prevent breaking * fix: switch profile and actor names on user dropdown * refactor: make font color darker in sidebar * fix: wrong tag color on access denied * feat: new collapsed sidebar * feat: add lock icon to subnav + hide if parent is disabled * fix: position of lock icons * Minor fixes * fix: subitems +1 pixel .... * refactor: xs for Datepicker components * refactor: xs for Input & InputController components * refactor: xs for Select component * refactor: add text medium and force styling on table * feat: add missing tag variant mint * feat: add stories for Action Card using small heading * feat: add stories for input * feat: add stories to Select * feat: add stories for DatePicker * refactor: cleanup * refactor: test for switching languages * fix: add scroll on userDelegations * feat: add darkBlue color option for UserAvatar * feat: add or edit alt on images * refactor: remove {} wrapping when using string values * refactor: grid layout in SP layout * fix: hopefully fixing buggy hover on sidebar * refactor: classnames usage * fix: dry pattern on Layout helpers * fix: remove unec classname use * fix: wrong path for hourglass svg * refactor: remove dry pattern in select return * fix: subitems not closing menu on click * fix: avatar color when delegation * feat: add medium variant as button text option * refactor: smaller font on search results * fix: remove settings from sidebar * feat: add path header to accessDenied * refactor: temp change to make button smaller * refactor: smaller text on access table * fix: forgot to commit checkox changes * refactor: input sizes on documents datepicker * refactor: text changes * refactor: smaller padding on mobile logo * fix: delete endorsments like on main * fix: back to SM input for access detail table * fix: link not working outside service portal * fix: remove table styling on access items * fix: revert changes on grant access component * fix: userMenu not responsive + other comments * fix: base url for settings * fix: remove temp data * fix: layout * fix: remove text on plus button for finance tables * fix: put grid container back * fix: sidebar animation * fix: revert changes for small input * fix: relative links on userDropdown * feat: fixes after comment + dropdown lang for mobile * refactor: cleanup on Layout helpers * feat: add breadcrumbs for settings * feat: ui changes on menu + userMenu on mobile * fix: finance content going under on smaller screens * fix: spacing on mobile menu * fix: dont display collapsed state on mobilemenu * fix: revert padding changes * fix: fixing userMenu test * fix: display heading as heading * fix: revert adding mint variant on Tag * fix: fixing menu bug * refactor: layout * fix: revert pushing mock data! * fix: spacing should use theme * fix: use translations for alt text * fix: wrong usage of willChange * fix: casing issue * feat: changes on menu * fix: wrong color on collapsed active item * fix: hover states on nav items * fix: padding variable * fix: spacing on small screens * revert: changes on collapsed nav items Co-authored-by: Ólafur Sverrir Kjartansson <[email protected]> Co-authored-by: Þórður Hafliðason <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 50f5d0f Author: Alexandra Diljá Birkisdóttir <[email protected]> Date: Fri Jan 7 13:10:09 2022 +0000 fix(endorsement-system): Text fixes (#6174) * template text adjustments * lock list text for admin * format * messageId Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 70083b6 Author: miamiultras <[email protected]> Date: Fri Jan 7 11:57:58 2022 +0000 fix(island-ui): fix datepicker without label (#6175) commit 3b39f78 Author: Alexandra Diljá Birkisdóttir <[email protected]> Date: Fri Jan 7 11:25:51 2022 +0000 fix(P-Sign-application): Adding to json (#6172) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit eb719d2 Author: Kristján Albert <[email protected]> Date: Fri Jan 7 11:17:25 2022 +0000 feat(island-ui): image/logo option for CategoryCard (#6125) * Add image option for CategoryCard * Change hasImage check Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 66cf7bc Author: Ívar Oddsson <[email protected]> Date: Fri Jan 7 10:35:29 2022 +0000 chore(judicial-system): Use "Varnaraðili" instead of "Sakborningur" everywhere (#6171) * Change Sakborningur to varnaraðili * Use Varnaradili in info card * Use Varnaradili in policeRequestAccordionItem * Use accused from core in requests table * Fix tests Co-authored-by: Ívar Oddsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit ec500fe Author: Rúnar Vestmann <[email protected]> Date: Fri Jan 7 09:43:42 2022 +0000 fix(web): Organization searchbox should appear when language is set to english (#6169) * Changed WITH_SEARCH list to also contain english slugs * Removed unused imports Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit bba751c Author: miamiultras <[email protected]> Date: Fri Jan 7 09:21:09 2022 +0000 fix(island-ui): revisit disabled state, fix missing disabled states, add missing stories (#6154) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 88a84cc Author: albinagu <[email protected]> Date: Fri Jan 7 09:07:31 2022 +0000 feat(p-sign): P-Sign Application Template (#5874) * innitial commit: P-Sign application template * adding p-sign to codeowners * gitbook * upload photo logic * using JurisdictionProvider for dropdown options * updating dataSchema * alert on no photo and some touching up * tweak * build fix * more of photo fixing up * generate types fixed in workspace * missing } * fixing bad conflict merge * ready for prod: false * review fixes * updating providers texts * using dataproviders from shared folder * no api modules * build fix * adding doctors note provider setup and updating texts * formatting date in overview * certificate and district providers * submit * provider * format * dataproviders stop if no data from syslumenn * update test * update application state on submit * clean up * fixing linitng * bullets fix í ph upload * tweak photo view * tweaks * linting and config * cleanup * getFileContentAsBase64 * attachment * updating texts file with unique translation namespace * application type translation id * photo preview * submission photo * quality photo or upload * rm cl * use quality or upload * minor format * preview * cleanup * qualityphoto from external * submission s3 * cleaning up preview on upload * rm getFileContentAsBase64 * clean and format * photp upload * comments addressed * cleanup * x Co-authored-by: Alexandra Diljá <[email protected]> Co-authored-by: Alexandra Diljá Birkisdóttir <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit c2c47d1 Author: miamiultras <[email protected]> Date: Fri Jan 7 07:52:21 2022 +0000 fix(island-ui): fix icon size for small button (#6163) commit dff7388 Author: rafnarnason <[email protected]> Date: Thu Jan 6 19:49:41 2022 +0000 fix(user-profile): Hook up to new user profile client (#6159) * hooked api domains user profile to clients * removed unecessary generator * format Co-authored-by: Rafn Árnason <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 33aed9a Author: kksteini <[email protected]> Date: Thu Jan 6 17:20:53 2022 +0000 chore(cms): Removed unused content model, 'location' (#6164) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 7ea180d Author: Ívar Oddsson <[email protected]> Date: Thu Jan 6 16:25:29 2022 +0000 feat(judicial-system): Send a calendar invite with court date notification to defender and prosecutor (#6132) * Send a calendar invite with court date notification to defender and prosecutor * Revert env changes * Always send an ical invite to defenders * Skip flaky tests Co-authored-by: Ívar Oddsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 16e3913 Author: arnorhs <[email protected]> Date: Thu Jan 6 16:12:52 2022 +0000 chore(services-user-notification): set worker argument correctly (#6124) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 6f6fc45 Author: Guðjón Guðjónsson <[email protected]> Date: Thu Jan 6 15:22:35 2022 +0000 chore(judicial-system): Improved error responses (#6062) * Improved error responses * Improves error handling * Improves error handling * Fixes broken unit test * Renames exception filter * Improves logging and error handling * Rewrite find by id and create * Rewrites update and extend * Makes return value optional on update * Fixes type errors * Fixes linting issues * Renames case variables * Rewrites contentful access * Fixes broken tests * Rewrites logging * Rewrites error handling and logging * Rewrites logging * Rewrites logging * Rewrites logging * Renames arguments and rewrites loggin * Adds http exception filter to xrd api * Improves logging * Uses shared problem filters in backend and xrd api * Rewrites error handling * Uses shared problem filters in api * Fixes unit tests * Fixes e2e test * Fixes e2e test * Fixes handling of existing problems and logging of problems with no status * Fixes build error * Removes console log * Adds tests * Update libs/nest/problem/src/lib/base-problem.filter.spec.ts Fix test desctiption Co-authored-by: Eiríkur Heiðar Nilsson <[email protected]> Co-authored-by: Eiríkur Heiðar Nilsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit e147674 Author: albinagu <[email protected]> Date: Thu Jan 6 15:06:41 2022 +0000 fix(web): SearchBox update for search in /s/syslumenn (#5767) * Search all on icon click * changing SearchBox to use AsyncSearch * smá tweak * debounce and a few minor tweaks * format * Show loading icon while typing, enabled english search and improved keyboard navigation (tab, enter and arrow keys) (#6160) Co-authored-by: Rúnar Vestmann <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 34fe46f Author: Rikard Arnar B. Birgisson <[email protected]> Date: Thu Jan 6 14:31:43 2022 +0000 chore(as): Remove dead code (#6142) * Removes unused application * Removes joint custody from core files Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 80457d2 Author: Guðjón Ingi Magnússon <[email protected]> Date: Thu Jan 6 12:26:12 2022 +0000 feat(personal-representative): personal representative delegation support (#6122) * Added personal representative delegation support for client and api-scopes * Added properties to Client and ApiScope models Co-authored-by: Gudjon <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 14e3532 Author: MargretFinnboga <[email protected]> Date: Thu Jan 6 11:55:19 2022 +0000 fix(fa): Fixing click outside of aid amount modal (#6147) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit f85c833 Author: Petar Shomov <[email protected]> Date: Thu Jan 6 11:25:52 2022 +0000 fix(ci): giving CI last good build script bigger window of SHAs to choose from (#6157) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
island-is/infrastructure#1003
Problem
Currently
X-Real-IPholds the cloudfront ip on production and on dev and staging it holds the value127.0.0.1. So all our audit logs have those ips instead of the real client ip. The difference between environments is because linkerd is running on dev and staging but not yet in production. See the example below to see why.What
Use full computed X-Forwarded-For in audit logs.
We will configure our ingress controller to use https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/#compute-full-forwarded-for which will append ip's instead of replacing the header.
So it will look like this:
So when we go through our audit logs we will need to parse the correct ip.
Why
Because there is not a fully supported way of getting the exact client ip with our infrastructure setup. Parsing the right client ip automatically before we set it in the audit log would be error prone.
Checklist: