Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8] fix cluster early warm up #285

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Conversation

lambdai
Copy link

@lambdai lambdai commented Nov 10, 2020

Description:
cherry-pick below PRs from envoy upstream
cluster manager: avoid immediate activation for dynamic inserted cluster when initialize (envoyproxy#12783)
cluster: unstuck cluster manager when update the initializing cluster (envoyproxy#13875)

Risk Level: LOW
Testing:
Docs Changes:
Release Notes:

@google-cla
Copy link

google-cla bot commented Nov 10, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@bianpengyuan
Copy link

@lizan fyi

@lambdai lambdai requested review from bianpengyuan and a team and removed request for a team November 10, 2020 22:35
@lambdai
Copy link
Author

lambdai commented Nov 10, 2020

@istio/release-managers-1-8

@lambdai
Copy link
Author

lambdai commented Nov 10, 2020

Is it a github outrage that I cannot assign release-managers-1.8?

@lambdai
Copy link
Author

lambdai commented Nov 10, 2020

/assign @istio/release-managers-1-8

@lambdai
Copy link
Author

lambdai commented Nov 10, 2020

^^ I gave up on assign the correct group since @bianpengyuan already approved.

Thanks!

@lambdai
Copy link
Author

lambdai commented Nov 11, 2020

/retest

@istio-testing istio-testing merged commit cd87e82 into istio:release-1.8 Nov 11, 2020
@lambdai lambdai deleted the release-1.8 branch November 11, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants