Update HUB to gcr.io/istio #1995
Conversation
Signed-off-by: JimmyCYJ <[email protected]>
googlebot
added
the
cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -3,7 +3,7 @@ version: 2 | |||
| jobs: | |||
| build: | |||
| docker: | |||
| - image: istio/ci:go1.10-bazel0.15-clang6.0 | |||
| - image: gcr.io/istio/ci:go1.10-bazel0.15-clang6.0 | |||
There was a problem hiding this comment.
should be
gcr.io/istio-testing/ci:go1.10-bazel0.15-clang6.0
There was a problem hiding this comment.
?? Why are you changing this? For those of us outside of google, how do we update this image or do we have to hunt one person down for the update? Atleast for the dockerhub, multiple people (google and outside) have access.
There was a problem hiding this comment.
@rshriram It seems that we could not locate any Google people with the access. Who owns the docker hub with admin permission to update the access list? We like to add some Google test-infra people to the list too. I like to have access too as istio/proxy maintainer.
There was a problem hiding this comment.
@rshriram I was trying to update Envoy SHA, and found some build errors in circleCI PR, so I ask around and learn that I need to update circleCI image PR. We don't have write permission to the docker hub, could you add @qiwzhang, me and test-infra people to the access list? Is there any instruction to build images for circleCI?
|
Thanks a lot @mandarjog, for helping us to build and push the images. |
Signed-off-by: JimmyCYJ [email protected]