Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HUB to gcr.io/istio #1995

Closed
wants to merge 1 commit into from
Closed

Update HUB to gcr.io/istio #1995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2
jobs:
build:
docker:
- image: istio/ci:go1.10-bazel0.15-clang6.0
- image: gcr.io/istio/ci:go1.10-bazel0.15-clang6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be
gcr.io/istio-testing/ci:go1.10-bazel0.15-clang6.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?? Why are you changing this? For those of us outside of google, how do we update this image or do we have to hunt one person down for the update? Atleast for the dockerhub, multiple people (google and outside) have access.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rshriram It seems that we could not locate any Google people with the access. Who owns the docker hub with admin permission to update the access list? We like to add some Google test-infra people to the list too. I like to have access too as istio/proxy maintainer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rshriram I was trying to update Envoy SHA, and found some build errors in circleCI PR, so I ask around and learn that I need to update circleCI image PR. We don't have write permission to the docker hub, could you add @qiwzhang, me and test-infra people to the access list? Is there any instruction to build images for circleCI?

environment:
- BAZEL_TEST_ARGS: "--test_env=ENVOY_IP_TEST_VERSIONS=v4only --test_output=all"
resource_class: xlarge
Expand Down