Update envoy sha and fix bulid break #2179

yangminzhu · 2019-04-18T00:07:42Z

There are a couple of breaking changes in upstream Envoy, they are resolved as following:

Change to use Ssl::ConnectionInfo from Ssl::Connection as renamed in access logging: pass downstream TLS information to access logs envoyproxy/envoy#6144
Change to return the first item of uriSanPeerCertificate() and uriSanLocalCertificate() as it now returns a vector, changed in access logging: pass downstream TLS information to access logs envoyproxy/envoy#6144
Include envoy_api_dependencies in WORKSPACE as introduced in ci: remove ci workspace envoyproxy/envoy#6229
Use getStringView() to replace c_str() in HeaderString as removed in Remove HeaderString::c_str() and migrate callers to getStringView() envoyproxy/envoy#6564
Pass Envoy::Filesystem::fileSystemForTest() to Envoy::Api::Impl as introduced in filesystem: add Windows implementation envoyproxy/envoy#6072

Fixes #2177

@kyessenov for the mixer changes.

yangminzhu · 2019-04-18T00:58:13Z

The tests on prow failed to build, probably due to the gcc version (5.4.0) is too low. The tests on circle-ci passed as we use gcc-6 in circle-ci.

W0418 00:24:06.754] /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/ext/new_allocator.h:120:23: error: no matching constructor for initialization of 'std::pair<Envoy::Http::LowerCaseString, std::__cxx11::basic_string<char> >'

yangminzhu · 2019-04-18T01:30:41Z

/test proxy-presubmit-asan
/test proxy-presubmit

diemtvu

/lgtm

kyessenov

/lgtm
/approve

lizan · 2019-04-18T22:47:52Z

LGTM, waiting for prow toolchains update

yangminzhu · 2019-04-19T18:31:26Z

/test proxy-presubmit
/test proxy-presubmit-asan
/test proxy-presubmit-tsan

lizan · 2019-04-19T18:43:42Z

/lgtm
/approve

istio-testing · 2019-04-19T18:43:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: diemtvu, kyessenov, lizan, yangminzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kyessenov,lizan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yangminzhu · 2019-04-19T19:09:10Z

/test proxy-presubmit-asan

@PiotrSikora

* Forwarded attributes override statically configured Local Attributes (#2097) * WIP * add local and override tests * revert attributes_builder * white list forward attributes * add tests with whitelist * fix builder test for white listed attributes * ignore istio.mixer in report (#2098) Signed-off-by: Lizan Zhou <[email protected]> * whitelist kSourceNamespace attribute (#2100) * Update software in the build image used by CircleCI. (#2110) Signed-off-by: Piotr Sikora <[email protected]> * Add flag indicating current semantics of report batch (#2111) * Add flag indicating current semantics of report batch * Fix Unit Test * Update Envoy SHA to latest with deterministic hash (master). (#2108) * Update Envoy SHA to latest with deterministic hash (master). Signed-off-by: Piotr Sikora <[email protected]> * review: use lld linker for clang-asan and clang-tsan. Signed-off-by: Piotr Sikora <[email protected]> * review: export PATH. Signed-off-by: Piotr Sikora <[email protected]> * Update Envoy SHA to latest with deterministic hash (release-1.1). (#2109) * Update Envoy SHA to latest with deterministic hash (release-1.1). Signed-off-by: Piotr Sikora <[email protected]> * review: use lld linker for clang-asan and clang-tsan. Signed-off-by: Piotr Sikora <[email protected]> * review: export PATH. Signed-off-by: Piotr Sikora <[email protected]> * remove unused bytestring include from sni_verifier for openssl (#2112) * Added client/server load test framework to find mixer faults. (#2105) This is a load generator client + origin server I created to test the Mixer filter under various fault conditions using Envoy's client and server stacks. This work falls under [istio/istio#8224](istio/istio#8224) @PiotrSikora @jplevyak would love your feedback because it could be used for the wasm work and especially because this is the first >=C++11 code I've written See test/integration/int_client_server_test.cc if you want to start with an example for context. Another example that uses this framework to sandwich Envoy+Mixer filter between the load generator and multiple origin servers simulating Mixer servers can be found in [istio/istio#8224](istio/istio#8224) * Warn user of using mTLS PERMISSIVE mode and suggest to upgrade to STRICT mode (#2114) * Warn user of using mTLS PERMISSIVE mode and suggest to upgrade to STRICT mode. Signed-off-by: Yangmin Zhu <[email protected]> * fix format * check in constructor * Update to latest istio/api on release-1.1 branch (#2115) * Update to latest istio/api on release-1.1 branch * Update istio/api to latest release-1.1 * Added simple logging abstraction so mixer client logs can be relayed to envoy logs. (#2116) * Added simple logging abstraction so mixer client logs can be relayed to envoy logs when running inside envoy, stderr when running standalone. * Log threshold guards that prevent needless serialization of logging arguments are now embedded in the log macros. * Format * Added do/while guards around logging statements. * Coalesce all memory for checks and reports into shared pointers (#2117) * Coalesce all memory for policy check requests and telemetry reports into shared pointers that live as long as a request's mixer filter instance. * A few small fixups for the code review. * Address some minor nits from code review. * Additional counters for mixer policy check (#2118) * Coalesce all memory for policy check requests and telemetry reports into shared pointers that live as long as a request's mixer filter instance. * A few small fixups for the code review. * Added finer-grained counters to mixer policy check * Add retries to policy checks on failed transport error (#2113) * Add configurable retry to policy/quota checks that failed due to transport error. * Added assertions on mixer filter stats to mixer fault test. * Reformat * Fix inaccurate comment. ` * Fix asan warning (thanks @silentdai!) and exclude mixer_fault_test from the asan and tsan sanitizers since it always times out. * Fix bad prefix check * Pull in latest istio/api from release-1.1 branch (#2120) * Add Joshua into proxy OWNER (#2121) * log authn permissive mode only when config is received (#2125) * log authn permissive mode only when config is received Signed-off-by: Yangmin Zhu <[email protected]> * fix format * fix build * clang-6/gcc: compiler barking fix (#2123) * compiler barking Signed-off-by: Kuat Yessenov <[email protected]> * piotrs fix Signed-off-by: Kuat Yessenov <[email protected]> * Add additional telemetry report counters (#2128) * Added counters to track telemetry report result. * reformat * replace tabs with spaces * Replace more tab with spaces. * New api sha for proxy (#2130) * API sha just changed, chanign it again for proxy (#2131) * Remove myself from owners add utka instead (#2129) * implement upstream secure bit (#2133) Signed-off-by: Kuat Yessenov <[email protected]> * Deflake macos MixerFaultTest by broadening assertion ranges. (#2126) * Deflake macos MixerFaultTest by broadening assertion ranges. Fix flake in macos tests that was introduced by #2113 * Cleanup a few readability issues and add an assertion. * More redability changes. * API sha for proxy (#2136) * Revert "implement upstream secure bit (#2133)" (#2135) This reverts commit d857bdd. * Add the support of bypassing JWT authn for CORS requests (#2139) * Add the support of bypassing JWT authn for CORS requests * Bail out earlier for CORS preflight requests * Use OPTIONS constant value from Envoy * Remove changing to lowercase * Add more checks for CORS preflight requests (#2140) * Rc3. new API sha for proxy. (#2146) * API sha for proxy * API sha for proxy * update envoy with latest build fixes (#2147) * update envoy with latest build fixes Signed-off-by: Lizan Zhou <[email protected]> * update protobuf to match envoy Signed-off-by: Lizan Zhou <[email protected]> * timeSystem -> timeSource Signed-off-by: Lizan Zhou <[email protected]> * requesting to add myself as a reviewer/approver (#2148) I have 39 commits in this repo. * update envoy to pick up TLS logging for HTTP upstream (#2149) Signed-off-by: Lizan Zhou <[email protected]> * Building 1.1rc4 (#2150) * fix build Signed-off-by: Lizan Zhou <[email protected]> * fix format Signed-off-by: Lizan Zhou <[email protected]> * fix status match Signed-off-by: Lizan Zhou <[email protected]> * Fixes environment-dependent failures in MixerFaultTest (#2156) * Removed explicit log-level setting from tests, as it was interfering with cli '-l' option (#2155) * Update_Dependencies (#2178) * Update envoy sha and fix bulid break (#2179) * update envoy sha * fix build * Remove bazel shutdown from make deb * Ignore error code returned from bazel shutdown

yangminzhu added 2 commits April 17, 2019 14:57

update envoy sha

20f2b19

fix build

15d2e1a

yangminzhu requested review from lizan, kyessenov and diemtvu April 18, 2019 00:07

googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Apr 18, 2019

istio-testing requested a review from utka April 18, 2019 00:07

yangminzhu changed the title ~~Envoy sha~~ Update envoy sha and fix bulid break Apr 18, 2019

yangminzhu mentioned this pull request Apr 18, 2019

update prowbazel to 0.5.2 to use gcc-7/g++-7 istio/test-infra#1219

Merged

diemtvu approved these changes Apr 18, 2019

View reviewed changes

istio-testing assigned diemtvu Apr 18, 2019

istio-testing added the lgtm label Apr 18, 2019

kyessenov reviewed Apr 18, 2019

View reviewed changes

istio-testing assigned kyessenov Apr 18, 2019

istio-testing added the approved label Apr 18, 2019

yangminzhu mentioned this pull request Apr 18, 2019

update istio/proxy to use prowbazel 0.5.2 with gcc-7/g++-7 istio/test-infra#1221

Merged

istio-testing assigned lizan Apr 19, 2019

istio-testing merged commit e613d1c into istio:master Apr 19, 2019

yangminzhu deleted the envoy-sha branch April 19, 2019 19:37

lambdai mentioned this pull request May 17, 2019

Merge release-1.1 to master #2220

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update envoy sha and fix bulid break #2179

Update envoy sha and fix bulid break #2179

yangminzhu commented Apr 18, 2019 •

edited

Loading

yangminzhu commented Apr 18, 2019 •

edited

Loading

yangminzhu commented Apr 18, 2019

diemtvu left a comment

kyessenov left a comment

lizan commented Apr 18, 2019

yangminzhu commented Apr 19, 2019

lizan commented Apr 19, 2019

istio-testing commented Apr 19, 2019

yangminzhu commented Apr 19, 2019

Update envoy sha and fix bulid break #2179

Update envoy sha and fix bulid break #2179

Conversation

yangminzhu commented Apr 18, 2019 • edited Loading

yangminzhu commented Apr 18, 2019 • edited Loading

yangminzhu commented Apr 18, 2019

diemtvu left a comment

Choose a reason for hiding this comment

kyessenov left a comment

Choose a reason for hiding this comment

lizan commented Apr 18, 2019

yangminzhu commented Apr 19, 2019

lizan commented Apr 19, 2019

istio-testing commented Apr 19, 2019

yangminzhu commented Apr 19, 2019

yangminzhu commented Apr 18, 2019 •

edited

Loading

yangminzhu commented Apr 18, 2019 •

edited

Loading