ci: remove ci workspace #6229
Merged
ci: remove ci workspace #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizan Zhou <[email protected]>
htuch
reviewed
Mar 11, 2019
ci/do_ci.sh
Outdated
| @@ -268,7 +268,7 @@ elif [[ "$1" == "bazel.coverage" ]]; then | |||
| exit 0 | |||
| elif [[ "$1" == "bazel.clang_tidy" ]]; then | |||
| setup_clang_toolchain | |||
| cd "${ENVOY_CI_DIR}" | |||
| cd "${ENVOY_SRCDIR}" | |||
There was a problem hiding this comment.
Aren't we already in ENVOY_SRCDIR in all ofthese?
|
Yeah I might have to roll #6186 into this PR to make it pass all CI runs. |
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
|
/sub |
|
@lizan Any update on PR? I think this will allow us to get rid of envoy_select_quiche |
|
/retest |
|
🔨 rebuilding |
|
/retest |
|
🔨 rebuilding |
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
wu-bin
approved these changes
Apr 8, 2019
htuch
approved these changes
Apr 8, 2019
This was referenced Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou [email protected]
Description:
We no longer have prebuilt dependencies, so ci/WORKSPACE is no longer needed. Simplifies how CI runs.
Risk Level: Med for depending projects
Testing: CI
Docs Changes:
Release Notes: