Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ivanytskay/Create Entity Repository #28

Merged
merged 15 commits into from
Feb 11, 2021
Merged

Ivanytskay/Create Entity Repository #28

merged 15 commits into from
Feb 11, 2021

Conversation

Elizabeth129
Copy link
Contributor

No description provided.

dmitrykiev
dmitrykiev reviewed Feb 5, 2021
View reviewed changes
OutOfSchool/OutOfSchool.DataAccess/Models/Child.cs
{
public long ChildId { get; set; }
[DataType(DataType.Text)]
[Required(ErrorMessage = "First name is required")]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move strings to resources so that we can localize them later?

@Elizabeth129 Elizabeth129 merged commit 1900fc8 into develop Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrykiev dmitrykiev dmitrykiev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elizabeth129 @dmitrykiev