Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add multiple description #674

Merged
merged 3 commits into from
Jun 20, 2022
Merged

add multiple description #674

merged 3 commits into from
Jun 20, 2022

Conversation

v08uka
Copy link
Contributor

@v08uka v08uka commented Jun 15, 2022 •
edited
Loading

#651

Created another one because dat GitHub is a hard nut to crack :)

Multiple Description Added which includes:

  • New Entity and Dto models
  • Elastic search aggregation mapping
  • Custom validation on WorkshopDto added (but I would like to use Fluent Validation instead of Data Annotations)
  • Mapping fixed
  • Few unit tests fixed

Also in the scope of this task

  • Fixed Naming of Property ProviderSectionItemDto. @litvinets please take a look on Dtos
  • Added SEPARATOR constant ElasticsearchMappingExtensions

@v08uka v08uka self-assigned this Jun 15, 2022
@v08uka v08uka requested review from DmyMi, RBiyovskiy and litvinets June 15, 2022 17:23
@v08uka v08uka mentioned this pull request Jun 16, 2022
Closed
@v08uka v08uka linked an issue Jun 16, 2022 that may be closed by this pull request
Implement list of subsection for Workshop description #651
Closed
@v08uka v08uka force-pushed the v08uka/add-multiple-descriptions branch from a67bba5 to ea1d8d4 Compare June 20, 2022 16:13
@v08uka v08uka force-pushed the v08uka/add-multiple-descriptions branch from 12e6207 to adfce40 Compare June 20, 2022 18:15
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@DmyMi DmyMi merged commit 5bc42be into develop Jun 20, 2022
@DmyMi DmyMi deleted the v08uka/add-multiple-descriptions branch June 20, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmyMi DmyMi DmyMi approved these changes

@litvinets litvinets litvinets approved these changes

@RBiyovskiy RBiyovskiy Awaiting requested review from RBiyovskiy

Assignees

@v08uka v08uka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement list of subsection for Workshop description
3 participants
@v08uka @DmyMi @litvinets