Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid deprecation warnings #1288

Merged
merged 2 commits into from
Dec 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions bin/cml/repo/prepare.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,7 @@ describe('CML e2e', () => {
environment]
--repo Repository URL or slug[string] [default: infer from the environment]
--token Personal access token [string] [default: infer from the environment]
--help Show help [boolean]

Options:
--fetch-depth Number of commits to fetch (use \`0\` for all branches & tags)
[number]
--user-email Git user email [string] [default: \\"[email protected]\\"]
--user-name Git user name [string] [default: \\"Olivaw[bot]\\"]"
--help Show help [boolean]"
`);
});
});
7 changes: 1 addition & 6 deletions bin/legacy/commands/ci.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
const { addDeprecationNotice } = require('../deprecation');
const { builder, handler } = require('../../cml/repo/prepare');
const { handler } = require('../../cml/repo/prepare');

exports.command = 'ci';
exports.description = 'Prepare Git repository for CML operations';
exports.handler = handler;
exports.builder = addDeprecationNotice({
builder,
notice: '"cml ci" is deprecated, please use "cml repo prepare"'
});
3 changes: 2 additions & 1 deletion bin/legacy/commands/publish.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ exports.description = false;
exports.handler = handler;
exports.builder = addDeprecationNotice({
builder,
notice: '"cml publish" is deprecated, please use "cml asset publish"'
notice:
'"cml publish" is deprecated since "cml comment" now supports "![inline](./asset.png)"'
});