remove: Add support for removing tracked files / directories #5757
Conversation
| stages = self.stage.from_target(target) | ||
| stages_info = self.stage.collect_granular(target) |
There was a problem hiding this comment.
Does the target argument description string (argparse) need an update? 🙂
There was a problem hiding this comment.
Indeed, although I think I should wait for some clarifications regarding the doc update (iterative/dvc.org#2357) before updating the argument description
|
|
||
| dvc.remove("foo") | ||
| assert "/foo" not in get_gitignore_content() | ||
| assert "/bar" in get_gitignore_content() |
There was a problem hiding this comment.
Maybe checking contents in dvc.yaml directly is better?
There was a problem hiding this comment.
I'm not sure if I fully understand your suggestion. As far as I know, using dvc.remove("foo") will not update the contents in dvc.yaml; it will remove foo from both the file system and the .gitignore
There was a problem hiding this comment.
There was a problem hiding this comment.
I understand the source of confusion, we surely need to improve the documentation related with this change
tests/func/test_remove.py
Outdated
| assert not (tmp_dir / ".gitignore").exists() | ||
|
|
||
|
|
||
| def test_remove_file_in_subdir_as_target(tmp_dir, scm, dvc): |
There was a problem hiding this comment.
These two tests can be merged into one? Generating a stage output both file and path, then remove them.
There was a problem hiding this comment.
I felt like the 2 tests are better separated because one is asserting a successful behavior and the other is asserting that a specific exception is being raised
|
Will this fix #2575? If so please link them in the description of this PR. |
daavoo
changed the title
It will not fix the original premise of the issue (you still have to use |
|
Unfortunately, even though this works, but the code is convoluted 🙁 We'll need a more general solution once we have a better architecture in this department. Closing this in favor of the path outlined in #6300 |
Fixes #5288
Fixes #5772
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Docs: iterative/dvc.org#2357