Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use phpstan-drupal for code analysis #134

Merged
merged 12 commits into from
Feb 14, 2023
Merged

Use phpstan-drupal for code analysis #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
44959a6
Used phpstan-drupal for code analysis
jekuaitk Feb 10, 2023
d0a9b9e
Merge branch 'develop' into feature/apply-code-analysis
martinyde Feb 10, 2023
5aa223c
FORMS-718: Changed phpstan setup
martinyde Feb 10, 2023
f565140
Changed github action
martinyde Feb 10, 2023
2bff69d
Changed github action
martinyde Feb 10, 2023
e6d84b3
Changed github action
martinyde Feb 10, 2023
80ad4dd
Changed github action
martinyde Feb 10, 2023
1682776
Changed github action
martinyde Feb 14, 2023
0e310dc
Changed github action
martinyde Feb 14, 2023
00d007d
Applied phpstan drupal-check
martinyde Feb 14, 2023
239debe
Removed type error from phpstan ignore errors
martinyde Feb 14, 2023
26394e8
Changed usage of phpstan
martinyde Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ jobs:
run: |
# Using `--no-scripts` breaks something with mglaman/drupal-check.
composer install --no-interaction --no-progress --no-scripts
- name: drupal-check
- name: code-analysis
run: |
composer code-analysis/drupal-check
composer code-analysis

coding-standards-custom-themes:
name: Yarn - Check Coding Standards in custom themes
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Nedenfor ses dato for release og beskrivelse af opgaver som er implementeret.

* Installerede [OS2Forms organisation
1.0.0](https://github.com/itk-dev/os2forms_organisation/releases/tag/1.0.0).
* Phpstan config

### Opdateret

Expand Down
15 changes: 9 additions & 6 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,10 @@
"require-dev": {
"drupal/core-dev": "^9.1",
"drupal/mail_debugger": "^1.4",
"mglaman/drupal-check": "^1.3"
"mglaman/phpstan-drupal": "^1.1",
"phpstan/extension-installer": "^1.2",
"phpstan/phpstan": "^1.9",
"phpstan/phpstan-deprecation-rules": "^1.1"
},
"conflict": {
"drupal/drupal": "*"
Expand All @@ -99,7 +102,8 @@
"composer/installers": true,
"drupal/core-composer-scaffold": true,
"drupal/core-project-message": true,
"dealerdirect/phpcodesniffer-composer-installer": true
"dealerdirect/phpcodesniffer-composer-installer": true,
"phpstan/extension-installer": true
}
},
"extra": {
Expand Down Expand Up @@ -190,11 +194,11 @@
"install-codestandards": [
"Dealerdirect\\Composer\\Plugin\\Installers\\PHPCodeSniffer\\Plugin::run"
],
"code-analysis/drupal-check": [
"vendor/bin/drupal-check --deprecations --analysis web/modules/custom"
"code-analysis/phpstan": [
"vendor/bin/phpstan analyse"
],
"code-analysis": [
"@code-analysis/drupal-check"
"@code-analysis/phpstan"
],
"coding-standards-check/phpcs": [
"vendor/bin/phpcs --standard=phpcs.xml.dist"
Expand All @@ -208,6 +212,5 @@
"coding-standards-apply": [
"@coding-standards-apply/phpcs"
]

}
}
Loading