Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepared audit logging v1 #342

Merged
merged 5 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ Nedenfor ses dato for release og beskrivelse af opgaver som er implementeret.

## [Under udvikling]

* Opdaterede til OS2Forms 3.17.0
* Audit logging af CPR og CVR opslag

## [3.0.1] 2024-11-18

* Håndterede ingen vedhæftede filer i forbindelse med
Expand Down
46 changes: 26 additions & 20 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 22 additions & 20 deletions config/sync/config_ignore.settings.yml
Original file line number Diff line number Diff line change
@@ -1,31 +1,33 @@
_core:
default_config_hash: UVH1aJ4b44UM-VdPVN7hNNuuVqfReJxwfVeDQH1Hvsk
langcode: da
mode: simple
ignored_config_entities:
- 'maestro.maestro_template.*'
- system.site
- 'webform.webform.*'
- 'webform.webform_options.*'
- os2web_nemlogin.settings
- '# Ignore encryption key and os2forms_encrypt settings'
- '# Ignore global header, colophon and footer settings'
- 'webform.settings:third_party_settings.webform_entity_print.template'
- 'os2forms_attachment.os2forms_attachment_component.*'
- '# Ignore leaflet layers'
- '# Ignore most settings on /admin/config/system/os2web-datalookup/datafordeler-cvr'
- 'os2web_datalookup.datafordeler_cvr:cert_path_live'
- 'os2web_datalookup.datafordeler_cvr:cert_passphrase_live'
- '# Ignore most settings on /admin/config/system/os2web-datalookup/serviceplatformen-cpr-extended'
- key.key.webform
- 'leaflet_layers.map_bundle.*'
- 'leaflet_layers.map_layer.*'
- 'maestro.maestro_template.*'
- 'os2forms_attachment.os2forms_attachment_component.*'
- os2forms_encrypt.settings
- os2forms_forloeb.settings
- 'os2web_audit.*'
- 'os2web_datalookup.datafordeler_cvr:cert_passphrase_live'
- 'os2web_datalookup.datafordeler_cvr:cert_path_live'
- 'os2web_datalookup.serviceplatformen_cpr_extended:certfile'
- 'os2web_datalookup.serviceplatformen_cpr_extended:certfile_passphrase'
- 'os2web_datalookup.serviceplatformen_cpr_extended:certfile_test'
- 'os2web_datalookup.serviceplatformen_cpr_extended:mode_selector'
- 'os2web_datalookup.serviceplatformen_cpr_extended:serviceagreementuuid'
- 'os2web_datalookup.serviceplatformen_cpr_extended:wsdl'
- 'os2web_datalookup.serviceplatformen_cpr_extended:usersystemuuid'
- 'os2web_datalookup.serviceplatformen_cpr_extended:useruuid'
- 'os2web_datalookup.serviceplatformen_cpr_extended:certfile_passphrase'
- 'os2web_datalookup.serviceplatformen_cpr_extended:certfile'
- 'os2web_datalookup.serviceplatformen_cpr_extended:certfile_test'
- '# Ignore leaflet layers'
- 'leaflet_layers.map_bundle.*'
- 'leaflet_layers.map_layer.*'
- os2forms_forloeb.settings
- '# Ignore encryption key and os2forms_encrypt settings'
- key.key.webform
- os2forms_encrypt.settings
- 'os2web_datalookup.serviceplatformen_cpr_extended:wsdl'
- os2web_nemlogin.settings
- system.site
- 'webform.settings:third_party_settings.webform_entity_print.template'
- 'webform.webform.*'
- 'webform.webform_options.*'
4 changes: 3 additions & 1 deletion config/sync/core.extension.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ module:
os2forms_webform_list: 0
os2forms_webform_maps: 0
os2forms_webform_submission_log: 0
os2web_audit: 0
os2web_audit_user: 0
os2web_datalookup: 0
os2web_nemlogin: 0
os2web_simplesaml: 0
Expand Down Expand Up @@ -159,9 +161,9 @@ module:
content_translation: 10
externalauth: 10
views: 10
minimal: 1000
eu_cookie_compliance: 1001
os2forms_encrypt: 9999
minimal: 1000
theme:
claro: 0
gin: 0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Drupal\os2forms_selvbetjening\Commands;

use Drupal\os2web_datalookup\Plugin\DataLookupManager;
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupInterfaceCpr;
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupCprInterface;
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DatafordelerCVR;
use Drush\Commands\DrushCommands;
use Symfony\Component\Yaml\Yaml;
Expand Down Expand Up @@ -40,7 +40,7 @@ public function lookUpCpr(
) {
try {
$instance = $this->dataLookupManager->createDefaultInstanceByGroup('cpr_lookup');
assert($instance instanceof DataLookupInterfaceCpr);
assert($instance instanceof DataLookupCprInterface);

if ($options['dump-configuration']) {
$this->output()->writeln([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
use Drupal\os2web_datalookup\LookupResult\CompanyLookupResult;
use Drupal\os2web_datalookup\LookupResult\CprLookupResult;
use Drupal\os2web_datalookup\Plugin\DataLookupManager;
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupInterfaceCompany;
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupInterfaceCpr;
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupCompanyInterface;
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupCprInterface;
use Drupal\os2web_nemlogin\Service\AuthProviderService;
use Symfony\Component\DependencyInjection\ContainerInterface;

Expand Down Expand Up @@ -247,7 +247,7 @@ private function getPageEntity() {
*/
public function lookupCpr(string $cpr): CprLookupResult {
$instance = $this->dataLookupManager->createDefaultInstanceByGroup('cpr_lookup');
if (!($instance instanceof DataLookupInterfaceCpr)) {
if (!($instance instanceof DataLookupCprInterface)) {
throw new RuntimeException('Cannot get CPR data lookup instance');
}
$lookupResult = $instance->lookup($cpr);
Expand All @@ -263,7 +263,7 @@ public function lookupCpr(string $cpr): CprLookupResult {
*/
public function lookupCvr(string $cvr): CompanyLookupResult {
$instance = $this->dataLookupManager->createDefaultInstanceByGroup('cvr_lookup');
if (!($instance instanceof DataLookupInterfaceCompany)) {
if (!($instance instanceof DataLookupCompanyInterface)) {
throw new RuntimeException('Cannot get CVR data lookup instance');
}
$lookupResult = $instance->lookup($cvr);
Expand Down
Loading