DW-579: Updated email handler default bodies #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
approved these changes
Sep 9, 2022
jekuaitk
force-pushed
the
feature/DW-579-update-email-handler-default-body
branch
from
895e61b to
6aa4c38
Compare
rimi-itk
requested changes
Sep 9, 2022
README.md
Outdated
| description should be configured in the `settings.local.php` file: | ||
|
|
||
| ```php | ||
| $config['os2forms_selvbetjening']['email_body_description'] = "Brug enten standardsvaret eller definer dit eget svar. Se <a href=\"https://os2forms.os2.eu/mail-tekster\">OS2Forms Loop</a> for andre standarder og eksempler."; |
There was a problem hiding this comment.
Use ' to simplify the description content (\ can be removed).
README.md
Outdated
| $config['os2forms_selvbetjening']['email_body_description'] = "Brug enten standardsvaret eller definer dit eget svar. Se <a href=\"https://os2forms.os2.eu/mail-tekster\">OS2Forms Loop</a> for andre standarder og eksempler."; | ||
| ``` | ||
|
|
||
| If it is not, no description is added. |
There was a problem hiding this comment.
Are you missing a “set” here, i.e. should it read “If it is not set, …”?
| description: 'Provides changes to webform email handler.' | ||
| package: 'OS2Forms' | ||
| core: 8.x | ||
| core_version_requirement: ^8 || ^9 |
There was a problem hiding this comment.
Remove ^8 || – Drupal 8 is not supported anymore.
rimi-itk
approved these changes
Sep 9, 2022
jekuaitk
deleted the
feature/DW-579-update-email-handler-default-body
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.itkdev.dk/browse/DW-579
OS2Forms Selvbetjeningmodule to allow setting a description for the message body section of the email handler configuration.