updates in CRUD operation section. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexMesser
reviewed
May 8, 2024
README.md
Outdated
| Here is how create operation works: | ||
|
|
||
| - The create DID request is parsed by the ITN agent, which validates its syntax as well as the value of each field to follow specific rules. | ||
| - The ITN agent generates the DID identifier based on the `did:itn` method specification, then the network stores the Hash(DID) and Hash(DID Document) in a smart contract on all the utilized ledger (one private and one public) |
There was a problem hiding this comment.
DID identifier is generated by the sender, not by ITN Agent.
AlexMesser
reviewed
May 8, 2024
README.md
Outdated
| @@ -126,6 +133,10 @@ Requirements: | |||
| - A DID string MUST be provided. | |||
| - The provided DID MUST be compliant with the `did:itn` method. | |||
|
|
|||
| Here is how resolve operation works: | |||
|
|
|||
| - The ITN Agent validates the provided DID, retrieves the DID Document from the federated content-addressable storage solution, retrieves the DID Document proof from one or more utilized ledger (either private or public) and returns the DID Document along with the DID Document proof to the requestor. | |||
There was a problem hiding this comment.
ITN Agent is not involved in resolution process. The request goes directly to the DID Resolver.
AlexMesser
reviewed
May 8, 2024
README.md
Outdated
| @@ -137,6 +148,10 @@ Requirements: | |||
| - The provided DID string MUST be compliant with the `did:itn` method. | |||
| - The provided DID document MUST be compliant with the DID V1.0 DID document specification. | |||
|
|
|||
| Here is how update operation works: | |||
|
|
|||
| - The ITN agent is responsible to verify that the initiator of the update request is the controller of the DID subject that will be updated. The authentication method defined in the DID Document will be used to authenticate the controller. | |||
There was a problem hiding this comment.
Update request sender must be specified as a DID Document controller and is authenticated by verifying the update request signature. It must be signed by the recovery key which is used before to generate the DID identifier.
There was a problem hiding this comment.
Also we need to mention that DID Document is updated in CAS and in ledgers.
AlexMesser
reviewed
May 8, 2024
| Here is how revoke operation works: | ||
|
|
||
| - The ITN agent is responsible to verify that the initiator of the revoke request is the controller of the DID subject that will be revoked. The authentication method defined in the DID Document will be used to authenticate the controller. Then ITN agent perform the revoke DID operation. | ||
|
|
There was a problem hiding this comment.
Same as Update DID flow
AlexMesser
reviewed
May 8, 2024
| Here is how recover operation works: | ||
|
|
||
| - The ITN agent is responsible to verify that the initiator of the recover request is the controller of the DID subject that will be recovered. The authentication method defined in the DID Document will be used to authenticate the controller. Then ITN agent perform the recover DID operation. | ||
|
|
There was a problem hiding this comment.
Same as Update DID flow
pleerock
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pleerock @AlexMesser cc: @Therecanbeonlyone1969
Please review the updates. These updates are based on the comments from Manu Sporny here is the link
Note: Once we merge this PR - I will comment and reply back to Manu that we have updated the specification for details.