Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add did:itn method #556

Merged
merged 4 commits into from
May 15, 2024
Merged

Add did:itn method #556

merged 4 commits into from
May 15, 2024

Conversation

bparth24
Copy link
Contributor

DID Method Registration

As a DID method registrant, I have ensured that my DID method registration complies with the following statements:

@bparth24 bparth24 requested a review from msporny as a code owner April 19, 2024 20:33
@bparth24
Copy link
Contributor Author

Hello @msporny - May I request your review of the PR on GitHub? Thank you!

@msporny
Copy link
Member

msporny commented Apr 29, 2024

New DID Method review volunteers, please review this DID Method.

/cc @apuchitnis @stenreijers @gatemezing @esaung @michallis @richardwinputra @adam-burns @Steffytan @MizukiSonoko @rajivrajani @genaris @harleyjackthomas @ajile-in @KDean-Dolphin

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DID Method meets minimum requirements for registration.

Non-blocking feedback:

  • The CRUD operations in the specification should detail exactly how each operation works.

@bparth24
Copy link
Contributor Author

bparth24 commented May 8, 2024

DID Method meets minimum requirements for registration.

Non-blocking feedback:

  • The CRUD operations in the specification should detail exactly how each operation works.

@msporny I have updated the ITN DID Method Specification with the details of how each CRUD operation works. Any estimate of when the second reviewer will get assigned and review the PR?

Copy link
Collaborator

@gatemezing gatemezing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DID Method meets minimum requirements for registration.

Copy link
Collaborator

@MizukiSonoko MizukiSonoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Non-blocking feedback:
  In DID-Method Format section, I think it would be easier to understand if there was Backus–Naur form or example

@bparth24
Copy link
Contributor Author

Ok

Non-blocking feedback:   In DID-Method Format section, I think it would be easier to understand if there was Backus–Naur form or example

@MizukiSonoko thank you for reviewing and feedback. Added the Backus-Naur form of ITN DID.

@bparth24
Copy link
Contributor Author

@MizukiSonoko @gatemezing @msporny thank you all for reviewing the PR. I appreciate your time and efforts. I want to know what else is pending on my end - I noticed 1 workflow awaiting approval from the maintainer.

@msporny msporny merged commit 1990fa2 into w3c:main May 15, 2024
1 check passed
@bparth24
Copy link
Contributor Author

@msporny thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants