-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: Fix channel search #3699
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good!
Deployed and tested on https://test.invidious.io, works flawlessly! |
Thank you for contributing! |
I think you want to follow this issue 🙂#1923 |
My comment was meant as a response to the closing of #2344, since it was wrongfully closed by this "fix". |
@SkMyPP I've reopened the aforementioned issue |
Parses ItemSectionRenderer to fix channel search
closes #3594
Test
channel:UCHqwzhcFOsoFFh33Uy8rAgQ antenna
(notice that it now only says antenna in the search bar)
Urls
/search?q=antenna&channel=UCHqwzhcFOsoFFh33Uy8rAgQ?page=1
/api/v1/channels/UCHqwzhcFOsoFFh33Uy8rAgQ/search?q=antenna?page=1
different results are shown
Urls
/search?q=antenna&channel=UCHqwzhcFOsoFFh33Uy8rAgQ&page=2
/api/v1/channels/UCHqwzhcFOsoFFh33Uy8rAgQ/search?q=antenna&page=2