Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Fix channel search #3699

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

ChunkyProgrammer
Copy link
Contributor

@ChunkyProgrammer ChunkyProgrammer commented Mar 22, 2023

Parses ItemSectionRenderer to fix channel search
closes #3594

Test

  1. In the Invidious search bar, search channel:UCHqwzhcFOsoFFh33Uy8rAgQ antenna
    image
    (notice that it now only says antenna in the search bar)
Urls

/search?q=antenna&channel=UCHqwzhcFOsoFFh33Uy8rAgQ?page=1
/api/v1/channels/UCHqwzhcFOsoFFh33Uy8rAgQ/search?q=antenna?page=1

  1. click next page
    image
    different results are shown
Urls

/search?q=antenna&channel=UCHqwzhcFOsoFFh33Uy8rAgQ&page=2
/api/v1/channels/UCHqwzhcFOsoFFh33Uy8rAgQ/search?q=antenna&page=2

@ChunkyProgrammer ChunkyProgrammer requested a review from a team as a code owner March 22, 2023 01:42
@ChunkyProgrammer ChunkyProgrammer requested review from unixfox and removed request for a team March 22, 2023 01:42
Copy link
Member

@SamantazFox SamantazFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@SamantazFox
Copy link
Member

Deployed and tested on https://test.invidious.io, works flawlessly!

@SamantazFox SamantazFox changed the title Fix channel search Search: Fix channel search Apr 1, 2023
@SamantazFox SamantazFox merged commit 8db2a93 into iv-org:master Apr 1, 2023
@SamantazFox
Copy link
Member

Thank you for contributing!

@ChunkyProgrammer ChunkyProgrammer deleted the fix-channel-search branch April 2, 2023 03:14
@ghost
Copy link

ghost commented Apr 22, 2023

Why can't searching for videos on a channel be like it used to be? Whenever you visited a channel's main page the search bar was automatically populated with the channel ID to search for specific videos from that channel:
image host

The "fix" mentioned above is too much of a pain to go through. People just want to go to a channel and be able to search their videos from the get-go, nobody wants to painstakingly copy the channel ID evey single time they want to search for a specific video from that channel.

@ChunkyProgrammer
Copy link
Contributor Author

The "fix" mentioned above is too much of a pain to go through. People just want to go to a channel and be able to search their videos from the get-go, nobody wants to painstakingly copy the channel ID evey single time they want to search for a specific video from that channel.

I think you want to follow this issue 🙂#1923

@ghost
Copy link

ghost commented Apr 22, 2023

My comment was meant as a response to the closing of #2344, since it was wrongfully closed by this "fix".

@SamantazFox
Copy link
Member

@SkMyPP I've reopened the aforementioned issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Channel: parameter search returns no results
3 participants