Add Zipkin protobuf support and remove zipkin from roadmap #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
objectiser
approved these changes
Sep 2, 2019
| @@ -53,5 +53,5 @@ also supported). Logs are written to standard out using the structured logging l | |||
| Although we recommend instrumenting applications with OpenTracing API and binding to Jaeger client libraries to benefit | |||
| from advanced features not available elsewhere, if your organization has already invested in the instrumentation | |||
| using Zipkin libraries, you do not have to rewrite all that code. Jaeger provides backwards compatibility with Zipkin | |||
| by accepting spans in Zipkin formats (Thrift or JSON v1/v2) over HTTP. Switching from Zipkin backend is just a matter | |||
| by accepting spans in Zipkin formats (Thrift, JSON v1/v2 and Protobof) over HTTP. Switching from Zipkin backend is just a matter | |||
There was a problem hiding this comment.
"Protocof" -> "Protobuf"
Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #292