Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for Zipkin Proto support #313

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

jan25
Copy link
Contributor

@jan25 jan25 commented Oct 12, 2019

Signed-off-by: Abhilash Gnan [email protected]

Which problem is this PR solving?

Short description of the changes

  • Update 1.14/getting-started.md

@jan25 jan25 force-pushed the zipkin-proto-docs branch from 95cb9bd to a2051c4 Compare October 12, 2019 08:26
@pavolloffay
Copy link
Member

Could you please add the same changes to nex-release files?

We should also proto to https://www.jaegertracing.io/docs/1.14/deployment/#collectors

Signed-off-by: Abhilash Gnan <[email protected]>
@jan25 jan25 force-pushed the zipkin-proto-docs branch from bf3612b to e8f8b35 Compare October 14, 2019 18:37
@jan25
Copy link
Contributor Author

jan25 commented Oct 14, 2019

Good idea. Changed next-release as well. Thanks!

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 0e60028 into jaegertracing:master Oct 15, 2019
@jan25 jan25 deleted the zipkin-proto-docs branch October 15, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants