This repository was archived by the owner on Jul 1, 2022. It is now read-only.
Bump thrift version #768
Closed
Bump thrift version #768
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apache Thrift community recently released 0.14.1 due to some bug fixes. We should upgrade to 0.14.1. |
Signed-off-by: Georgios Andrianakis <[email protected]>
|
we cannot merge this until #765 is done as we have no CI to validate. |
adoroszlai
suggested changes
Mar 16, 2021
There was a problem hiding this comment.
Thanks @geoand for working on this fix. Some code change is necessary for compiling with Thrift 0.14+:
jaeger-thrift/src/main/java/io/jaegertracing/thrift/internal/senders/ThriftSenderBase.java:67: error: constructor AutoExpandingBufferWriteTransport in class AutoExpandingBufferWriteTransport cannot be applied to given types;
memoryTransport = new AutoExpandingBufferWriteTransport(maxPacketSize, 2);
^
required: TConfiguration,int,int
found: int,int
reason: actual and formal argument lists differ in length
jaeger-thrift/src/main/java/io/jaegertracing/thrift/internal/reporters/protocols/ThriftUdpTransport.java:33: error: ThriftUdpTransport is not abstract and does not override abstract method checkReadBytesAvailable(long) in TTransport
public class ThriftUdpTransport extends TTransport implements Closeable {
^
2 errors
> Task :jaeger-thrift:compileJava FAILED
|
Oh darn. I am afraid I don't really know much about Thift so I would just be shooting in the dark. |
|
fixed in #774 |
JoakimLofgren
added a commit
to JoakimLofgren/java-spring-jaeger
that referenced
this pull request
May 5, 2021
This was referenced May 5, 2021
pavolloffay
pushed a commit
to opentracing-contrib/java-spring-jaeger
that referenced
this pull request
Jun 3, 2021
* Bump jaeger client Fixes #121 See jaegertracing/jaeger-client-java#768 * Add throws for new Exception from Jaeger client Also fix assert to not strip leading zeros, see jaegertracing/jaeger-client-java#746
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.