-
Notifications
You must be signed in to change notification settings - Fork 231
Update the version of libthrift to 0.14.1 (#772). #774
Update the version of libthrift to 0.14.1 (#772). #774
Conversation
This change updates the version of the dependency libthrift to 0.14.1. The primary impact of this is the requirement to handle a new checked exception, TTransportException, and a new base class TEndpointTransport which is used instead of TTransport and provides a useful implementation of some additional methods that were added to the TTransport base class. Signed-off-by: Robert Greig <[email protected]>
818294b
to
5125d00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good, but we can't merge until we fix the CI in #765
Codecov Report
@@ Coverage Diff @@
## master #774 +/- ##
============================================
- Coverage 89.11% 89.03% -0.08%
Complexity 605 605
============================================
Files 73 73
Lines 2259 2261 +2
Branches 295 295
============================================
Hits 2013 2013
- Misses 155 157 +2
Partials 91 91
Continue to review full report at Codecov.
|
Hi - I'm also looking for the changes in this PR to address the CVE that the previous libthrift version had. What's the process to get a released version of this? Happy to do anything to help push this forward if needed! |
Thank you for working on this.When can we expect the official release version with the fix. Please let us know. |
We are waiting on the official release for this .Please let us know the plan or the process to get a released version of this?Thank you for your support on this |
@gorsr01 The PR to make a new 1.6.0 release has merged: #777 |
Hi All .. I can see the tag release-1.6.0 tag. Can we get the 1.6.0 libraries from maven repo .. or do we need to compile the release-1.6.0 tag and then prepare new jaeger libraries . please help us. Thank you for your support |
Can anyone share the ETA for 1.6.0 release. We are waiting eagerly for this 1.6.0 libraries. |
Which problem is this PR solving?
Short description of the changes