Skip to content
This repository was archived by the owner on Jul 1, 2022. It is now read-only.

Update the version of libthrift to 0.14.1 (#772). #774

Merged
merged 2 commits into from
Mar 21, 2021

Conversation

rgreig
Copy link
Contributor

@rgreig rgreig commented Mar 19, 2021

Which problem is this PR solving?

Short description of the changes

  • This change updates the version of the dependency libthrift to 0.14.1. The primary impact of this is the requirement to handle a new checked exception, TTransportException, and a new base class TEndpointTransport which is used instead of TTransport and provides a useful implementation of some additional methods that were added to the TTransport base class.

This change updates the version of the dependency libthrift to 0.14.1. The primary impact of this is the requirement to handle a new checked exception, TTransportException, and a new base class TEndpointTransport which is used instead of TTransport and provides a useful implementation of some additional methods that were added to the TTransport base class.

Signed-off-by: Robert Greig <[email protected]>
@rgreig rgreig force-pushed the issue-772-upgrade-thrift branch from 818294b to 5125d00 Compare March 19, 2021 12:35
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, but we can't merge until we fix the CI in #765

@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #774 (e3c6bba) into master (6b314cd) will decrease coverage by 0.07%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #774      +/-   ##
============================================
- Coverage     89.11%   89.03%   -0.08%     
  Complexity      605      605              
============================================
  Files            73       73              
  Lines          2259     2261       +2     
  Branches        295      295              
============================================
  Hits           2013     2013              
- Misses          155      157       +2     
  Partials         91       91              
Impacted Files Coverage Δ Complexity Δ
...egertracing/zipkin/internal/ThriftSpanEncoder.java 70.58% <33.33%> (-9.42%) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b314cd...e3c6bba. Read the comment docs.

@yurishkuro yurishkuro mentioned this pull request Mar 21, 2021
@yurishkuro yurishkuro merged commit 4f828cf into jaegertracing:master Mar 21, 2021
@andydfleming
Copy link

Hi - I'm also looking for the changes in this PR to address the CVE that the previous libthrift version had. What's the process to get a released version of this? Happy to do anything to help push this forward if needed!

@gorsr01
Copy link

gorsr01 commented Mar 24, 2021

Thank you for working on this.When can we expect the official release version with the fix. Please let us know.

@gorsr01
Copy link

gorsr01 commented Mar 29, 2021

We are waiting on the official release for this .Please let us know the plan or the process to get a released version of this?Thank you for your support on this

@mehta-ankit
Copy link
Member

We are waiting on the official release for this .Please let us know the plan or the process to get a released version of this?Thank you for your support on this

@gorsr01 The PR to make a new 1.6.0 release has merged: #777
I think the release should happen soon.
More info on this thread:
https://cloud-native.slack.com/archives/CGG7NFUJ3/p1615881074000400

@gorsr01
Copy link

gorsr01 commented Mar 31, 2021

Hi All .. I can see the tag release-1.6.0 tag. Can we get the 1.6.0 libraries from maven repo .. or do we need to compile the release-1.6.0 tag and then prepare new jaeger libraries . please help us. Thank you for your support

@gorsr01
Copy link

gorsr01 commented Apr 6, 2021

Can anyone share the ETA for 1.6.0 release. We are waiting eagerly for this 1.6.0 libraries.
Thank you for your support on this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.5.0 incompatibility with libthrift 0.14.1 ( CVE-2020-13949 vulnerability found in libthrift 0.13.0)
5 participants