Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: upgraded to version 3.11.0 #2557

Closed
wants to merge 1 commit into from

Conversation

upsaurav12
Copy link

@upsaurav12 upsaurav12 commented Jan 6, 2025

Which problem is this PR solving?

Fixes #339

Description of the changes

  • upgrading @viz-js/viz to version 3.11.0

How was this change tested?

Checklist

@upsaurav12 upsaurav12 requested a review from a team as a code owner January 6, 2025 16:03
@upsaurav12 upsaurav12 requested review from pavolloffay and removed request for a team January 6, 2025 16:03
@yurishkuro
Copy link
Member

why at the root level? and what tests did you run? I am skeptical that this upgrade is just a bump without any code changes.

@upsaurav12
Copy link
Author

i am new to contribution, and i really didn't know how to actually fix these kind issues (upgrading versions). i just updated the version. can i get help on how can solve this issue?

@upsaurav12
Copy link
Author

upsaurav12 commented Jan 7, 2025

@yurishkuro i am still working on the PR. I have made some changes

  1. Removed the @viz-js/viz from the root directory.
  2. Upgraded viz.js in the packages/plexus.
    but i am still not sure if any other dependencies are need to be upgrade .

@yurishkuro
Copy link
Member

solved in #2568

@yurishkuro yurishkuro closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade plexus to use [email protected]
2 participants