[anonymizer] Update Makefile and Dockerfile #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashmita Bohara <[email protected]>
Ashmita152
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2632 +/- ##
=======================================
Coverage 95.06% 95.06%
=======================================
Files 210 210
Lines 9410 9410
=======================================
Hits 8946 8946
Misses 387 387
Partials 77 77 Continue to review full report at Codecov.
|
|
@jpkrohling do you think it's necessary to publish a Docker image for this? I feel like since we already distribute binaries, and the use case for the anonymizer is pretty narrow, it may be sufficient to only publish the binary. |
|
If we can, sure. It's useful for people who aren't on the target arch that we publish binary for, or people facing bugs on target arches that we don't test (Windows for instance). |
|
OK, I created jaeger-anonymizer repo on Docker hub. |
yurishkuro
approved these changes
Nov 19, 2020
quinniup
pushed a commit
to k8battleship/jaeger
that referenced
this pull request
Nov 23, 2020
Signed-off-by: Ashmita Bohara <[email protected]>
quinniup
added a commit
to k8battleship/jaeger
that referenced
this pull request
Nov 23, 2020
* Bump opentelemetry-collector to v0.14.0 (jaegertracing#2617) * bump opentelemetry-collector to v0.14.0 Signed-off-by: Pavel Kositsyn <[email protected]> * initialize traceid and spanid explicitly Signed-off-by: Pavel Kositsyn <[email protected]> * fix comments and empty parent span check Signed-off-by: Pavel Kositsyn <[email protected]> * fasten convert traceID/spanID Signed-off-by: Pavel Kositsyn <[email protected]> * fix convertTraceID + fix tests Signed-off-by: Pavel Kositsyn <[email protected]> * Update CodeQL to latest best practices (jaegertracing#2615) This will parallelize your analysis and speed things up a bunch. Signed-off-by: jhutchings1 <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> * Fix flaky TestReload (jaegertracing#2624) Signed-off-by: albertteoh <[email protected]> * Update x/text to v0.3.4 (jaegertracing#2625) Signed-off-by: Gary Brown <[email protected]> * Bump to latest UI for snapshot builds (jaegertracing#2626) Signed-off-by: Yuri Shkuro <[email protected]> * Implement anonymizer's main program (jaegertracing#2621) * Preparing release 1.21.0 (jaegertracing#2630) * updated changelog Signed-off-by: Joe Elliott <[email protected]> * Added ui changelog Signed-off-by: Joe Elliott <[email protected]> * Fixed UI changelog to point to 1.12.0 Signed-off-by: Joe Elliott <[email protected]> * Updated jaeger-ui to v1.12.0 Signed-off-by: Joe Elliott <[email protected]> * Resolving concerns Signed-off-by: Joe Elliott <[email protected]> * [anonymizer] Save trace in UI format (jaegertracing#2629) * Use fossa-contrib/fossa-action instead (jaegertracing#2571) * Use fossa-contrib/fossa-action instead Signed-off-by: Sora Morimoto <[email protected]> * Make step name clearer Signed-off-by: Sora Morimoto <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> * Update Makefile and Dockerfile for anonymizer (jaegertracing#2632) Signed-off-by: Ashmita Bohara <[email protected]> * Fix listen IP in unit test (jaegertracing#2636) Signed-off-by: zouyu <[email protected]> * Bump opentelemetry to v0.15.0 (jaegertracing#2634) * Bump opentelemetry to v0.15.0 Signed-off-by: Pavel Kositsyn <[email protected]> * add default value instead of nil value for jaegerreceiver config Signed-off-by: Pavel Kositsyn <[email protected]> * make lint Signed-off-by: Pavel Kositsyn <[email protected]> Co-authored-by: Kositsyn Pavel <[email protected]> Co-authored-by: Justin Hutchings <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Albert <[email protected]> Co-authored-by: Gary Brown <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Co-authored-by: Ashmita <[email protected]> Co-authored-by: Joe Elliott <[email protected]> Co-authored-by: Sora Morimoto <[email protected]> Co-authored-by: ZouYu <[email protected]> Co-authored-by: Kositsyn Pavel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashmita Bohara [email protected]
Which problem is this PR solving?
I realised in v1.21.0 we didn't had the anonymizer binary and docker image due to missing Makefile targets. This PR adds those.
Short description of the changes