Bump opentelemetry to v0.15.0 #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Kositsyn <[email protected]>
pkositsyn
force-pushed
the
bump_opentelemetry_v15
branch
from
666419d to
d2b1318
Compare
Codecov Report
@@ Coverage Diff @@
## master #2634 +/- ##
==========================================
- Coverage 95.08% 95.05% -0.03%
==========================================
Files 213 213
Lines 9492 9492
==========================================
- Hits 9025 9023 -2
- Misses 390 391 +1
- Partials 77 78 +1
Continue to review full report at Codecov.
|
Signed-off-by: Pavel Kositsyn <[email protected]>
joe-elliott
previously approved these changes
Nov 20, 2020
| @@ -248,7 +248,7 @@ func traceIDToString(high, low uint64) string { | |||
| } | |||
|
|
|||
| func (c *Translator) process(resource pdata.Resource) *dbmodel.Process { | |||
| if resource.IsNil() || resource.Attributes().Len() == 0 { | |||
| if resource.Attributes().Len() == 0 { | |||
There was a problem hiding this comment.
It seems that IsNil() was removed and the resource is guaranteed to never be nil?
I find these generate proto wrappers very confusing. Do you have any insight into why this was removed?
There was a problem hiding this comment.
Well, that went from my issue about panic in marshalling open-telemetry/opentelemetry-collector#1985. Then gradually all proto things became non-nullable. I believe, that using pointers was a mistake from the very beginning
There was a problem hiding this comment.
Yes, you're right, resource now cannot be nil
| @@ -206,13 +206,15 @@ func createExporters(component ComponentType, storageTypes string, factories com | |||
|
|
|||
| func enableAgentUDPEndpoints(jaeger *jaegerreceiver.Config) { | |||
| if jaeger.ThriftCompact == nil { | |||
| jaeger.ThriftCompact = &confignet.TCPAddr{ | |||
| jaeger.ThriftCompact = &jaegerreceiver.ProtocolUDP{ | |||
There was a problem hiding this comment.
Nice. This will allow us to support max udp packet size in the Jaeger otel collectors.
There was a problem hiding this comment.
Yeah, it is already configurable in otel receiver config
There was a problem hiding this comment.
Alongwith socket buffer size, number of workers and server queue size
Signed-off-by: Pavel Kositsyn <[email protected]>
mergify
bot
dismissed
joe-elliott’s stale review
Pull request has been modified.
|
This is a flaky test I suppose. Locally, tests pass periodically. |
yurishkuro
approved these changes
Nov 21, 2020
quinniup
pushed a commit
to k8battleship/jaeger
that referenced
this pull request
Nov 23, 2020
* Bump opentelemetry to v0.15.0 Signed-off-by: Pavel Kositsyn <[email protected]> * add default value instead of nil value for jaegerreceiver config Signed-off-by: Pavel Kositsyn <[email protected]> * make lint Signed-off-by: Pavel Kositsyn <[email protected]>
quinniup
added a commit
to k8battleship/jaeger
that referenced
this pull request
Nov 23, 2020
* Bump opentelemetry-collector to v0.14.0 (jaegertracing#2617) * bump opentelemetry-collector to v0.14.0 Signed-off-by: Pavel Kositsyn <[email protected]> * initialize traceid and spanid explicitly Signed-off-by: Pavel Kositsyn <[email protected]> * fix comments and empty parent span check Signed-off-by: Pavel Kositsyn <[email protected]> * fasten convert traceID/spanID Signed-off-by: Pavel Kositsyn <[email protected]> * fix convertTraceID + fix tests Signed-off-by: Pavel Kositsyn <[email protected]> * Update CodeQL to latest best practices (jaegertracing#2615) This will parallelize your analysis and speed things up a bunch. Signed-off-by: jhutchings1 <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> * Fix flaky TestReload (jaegertracing#2624) Signed-off-by: albertteoh <[email protected]> * Update x/text to v0.3.4 (jaegertracing#2625) Signed-off-by: Gary Brown <[email protected]> * Bump to latest UI for snapshot builds (jaegertracing#2626) Signed-off-by: Yuri Shkuro <[email protected]> * Implement anonymizer's main program (jaegertracing#2621) * Preparing release 1.21.0 (jaegertracing#2630) * updated changelog Signed-off-by: Joe Elliott <[email protected]> * Added ui changelog Signed-off-by: Joe Elliott <[email protected]> * Fixed UI changelog to point to 1.12.0 Signed-off-by: Joe Elliott <[email protected]> * Updated jaeger-ui to v1.12.0 Signed-off-by: Joe Elliott <[email protected]> * Resolving concerns Signed-off-by: Joe Elliott <[email protected]> * [anonymizer] Save trace in UI format (jaegertracing#2629) * Use fossa-contrib/fossa-action instead (jaegertracing#2571) * Use fossa-contrib/fossa-action instead Signed-off-by: Sora Morimoto <[email protected]> * Make step name clearer Signed-off-by: Sora Morimoto <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> * Update Makefile and Dockerfile for anonymizer (jaegertracing#2632) Signed-off-by: Ashmita Bohara <[email protected]> * Fix listen IP in unit test (jaegertracing#2636) Signed-off-by: zouyu <[email protected]> * Bump opentelemetry to v0.15.0 (jaegertracing#2634) * Bump opentelemetry to v0.15.0 Signed-off-by: Pavel Kositsyn <[email protected]> * add default value instead of nil value for jaegerreceiver config Signed-off-by: Pavel Kositsyn <[email protected]> * make lint Signed-off-by: Pavel Kositsyn <[email protected]> Co-authored-by: Kositsyn Pavel <[email protected]> Co-authored-by: Justin Hutchings <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Albert <[email protected]> Co-authored-by: Gary Brown <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Co-authored-by: Ashmita <[email protected]> Co-authored-by: Joe Elliott <[email protected]> Co-authored-by: Sora Morimoto <[email protected]> Co-authored-by: ZouYu <[email protected]> Co-authored-by: Kositsyn Pavel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Update of dependency
Short description of the changes
The only real thing is that any
pdata.Tracescomponent is non-nullable now, soIsNil()andInitEmpty()became deprecated.No changes applied to logic. The config for jaegerreceiver was updated in opentelemetry (initiated and implemented by me actually), but it is orthogonal to current jaeger code.