Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some struct names in comment #6253

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/collector/app/sanitizer/service_name_sanitizer.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ func NewServiceNameSanitizer(c cache.Cache) SanitizeSpan {
return sanitizer.Sanitize
}

// ServiceNameSanitizer sanitizes the service names in span annotations given a source of truth alias to service cache.
// serviceNameSanitizer sanitizes the service names in span annotations given a source of truth alias to service cache.
type serviceNameSanitizer struct {
cache cache.Cache
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/jaeger/internal/integration/span_reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ var (
_ io.Closer = (*spanReader)(nil)
)

// SpanReader retrieve span data from Jaeger-v2 query with api_v2.QueryServiceClient.
// spanReader retrieve span data from Jaeger-v2 query with api_v2.QueryServiceClient.
type spanReader struct {
logger *zap.Logger
clientConn *grpc.ClientConn
Expand Down
2 changes: 1 addition & 1 deletion cmd/jaeger/internal/integration/span_writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ var (
_ io.Closer = (*spanWriter)(nil)
)

// SpanWriter utilizes the OTLP exporter to send span data to the Jaeger-v2 receiver
// spanWriter utilizes the OTLP exporter to send span data to the Jaeger-v2 receiver
type spanWriter struct {
logger *zap.Logger
exporter exporter.Traces
Expand Down
2 changes: 1 addition & 1 deletion pkg/es/client/index_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ type Alias struct {
Index string
// Alias name.
Name string
// IsWritedIndex option
// IsWriteIndex option
IsWriteIndex bool
}

Expand Down
2 changes: 1 addition & 1 deletion storage_v2/spanstore/writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (

// Writer writes spans to storage.
type Writer interface {
// WriteTrace writes a batch of spans to storage. Idempotent.
// WriteTraces writes a batch of spans to storage. Idempotent.
// Implementations are not required to support atomic transactions,
// so if any of the spans fail to be written an error is returned.
// Compatible with OTLP Exporter API.
Expand Down
Loading