Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clarification]: copyedit javadoc before release #519

Closed
gavinking opened this issue Mar 3, 2024 · 3 comments
Closed

[clarification]: copyedit javadoc before release #519

gavinking opened this issue Mar 3, 2024 · 3 comments
Labels
question Further information is requested
Milestone

Comments

@gavinking
Copy link
Contributor

Specification

javadoc

I need clarification on ...

formatting and style.

Additional information

Before release, I think we need to go over the javadoc completely looking for minor things like the following:

  • Jagged line-lengths and lines which overflow the screen. Recent version of IntelliJ do a much better job of displaying javadoc, and of course in some cases it's very hard to make the line lengths consistent due to the use of {@ link} but even so, we can do better.
  • Use of <code> instead of {@code}
  • Use of informal language which addresses the user directly, e.g. "If you define a method...".

I would also prefer to see the work "keyset" go away if possible.

@gavinking gavinking added the question Further information is requested label Mar 3, 2024
@njr-11
Copy link
Contributor

njr-11 commented Mar 4, 2024

  • Jagged line-lengths and lines which overflow the screen. Recent version of IntelliJ do a much better job of displaying javadoc, and of course in some cases it's very hard to make the line lengths consistent due to the use of {@ link} but even so, we can do better.

  • Use of <code> instead of {@code}

I'm fine with this, but would consider it low priority because it can be adjusted at any point and is not a breaking change.
What is a good guideline for line length? If everyone has the same number in mind, it will help ensure it gets written in a compliant manner the first time.

  • Use of informal language which addresses the user directly, e.g. "If you define a method..."

The guideline that I would use here is that this sort of language is appropriate in JavaDoc that is meant for the end user, but it does not belong in the specification, which tends to be targeted toward implementors.

I would also prefer to see the word "keyset" go away if possible.

This makes sense if the pull that switches to CursoredPage goes in because we will no longer have a class name with keyset in it.

@gavinking
Copy link
Contributor Author

This is was mostly solved by #528 and #525.

gavinking added a commit to gavinking/data that referenced this issue Mar 8, 2024
including some fixes to out of date info in module-info.java

see jakartaee#519
@KyleAure KyleAure added this to the Jakarta Data 1.0 milestone Apr 22, 2024
@KyleAure
Copy link
Contributor

KyleAure commented Jul 1, 2024

Closing issue as completed for the Jakarta Data 1.0 milestone

@KyleAure KyleAure closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants