Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use {@code } everywhere #528

Merged
merged 7 commits into from
Mar 7, 2024
Merged

use {@code } everywhere #528

merged 7 commits into from
Mar 7, 2024

Conversation

gavinking
Copy link
Contributor

@gavinking gavinking commented Mar 7, 2024 •
edited
Loading

and fix two spelling errors.

@gavinking gavinking marked this pull request as ready for review March 7, 2024 20:40
njr-11
njr-11 requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@njr-11 njr-11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When {@code } is added around text with &lt; and &gt; those characters show literally rather than as < and >. I noticed a few occurrences of that and suggested fixes.

api/src/main/java/module-info.java Outdated Show resolved Hide resolved
api/src/main/java/module-info.java Outdated Show resolved Hide resolved
api/src/main/java/module-info.java Outdated Show resolved Hide resolved
api/src/main/java/module-info.java Outdated Show resolved Hide resolved
api/src/main/java/module-info.java Outdated Show resolved Hide resolved
@gavinking
Copy link
Contributor Author

When {@code } is added around text with &lt; and &gt; those characters show literally rather than as < and >. I noticed a few occurrences of that and suggested fixes.

Damnit, I looked for that, and missed these.

njr-11
njr-11 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@njr-11 njr-11 merged commit b2c5735 into jakartaee:main Mar 7, 2024
3 checks passed
@gavinking gavinking mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njr-11 njr-11 njr-11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavinking @njr-11